[INFO] fetching crate test-data-generation 0.3.4... [INFO] checking test-data-generation-0.3.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate test-data-generation 0.3.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate test-data-generation 0.3.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate test-data-generation 0.3.4 [INFO] finished tweaking crates.io crate test-data-generation 0.3.4 [INFO] tweaked toml for crates.io crate test-data-generation 0.3.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate test-data-generation 0.3.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4f9b85adb76834cac613660e125e0cff32a3ac804a962492054fa458fcd75159 [INFO] running `Command { std: "docker" "start" "-a" "4f9b85adb76834cac613660e125e0cff32a3ac804a962492054fa458fcd75159", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4f9b85adb76834cac613660e125e0cff32a3ac804a962492054fa458fcd75159", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f9b85adb76834cac613660e125e0cff32a3ac804a962492054fa458fcd75159", kill_on_drop: false }` [INFO] [stdout] 4f9b85adb76834cac613660e125e0cff32a3ac804a962492054fa458fcd75159 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0b868ac6cd8df99890da8850e65e4ebe5a69e2564576d6ad1d8d018d8c6e548d [INFO] running `Command { std: "docker" "start" "-a" "0b868ac6cd8df99890da8850e65e4ebe5a69e2564576d6ad1d8d018d8c6e548d", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.81 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Checking libc v0.2.107 [INFO] [stderr] Checking memchr v2.4.1 [INFO] [stderr] Checking ryu v1.0.5 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Compiling crossbeam-queue v0.3.2 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking traitobject v0.1.0 [INFO] [stderr] Checking ppv-lite86 v0.2.15 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Checking unsafe-any v0.4.2 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking anyhow v1.0.45 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking typemap v0.3.3 [INFO] [stderr] Checking levenshtein v1.0.5 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking arc-swap v0.4.8 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking crossbeam-epoch v0.9.5 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking crossbeam v0.8.1 [INFO] [stderr] Checking num-integer v0.1.44 [INFO] [stderr] Checking ordered-float v2.8.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking serde v1.0.130 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking serde_json v1.0.70 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking serde_yaml v0.8.21 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking log4rs v1.0.0 [INFO] [stderr] Checking test-data-generation v0.3.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/data_sample_parser.rs:395:24 [INFO] [stdout] | [INFO] [stdout] 395 | for headers in rdr.headers() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 395 | while let Ok(headers) = rdr.headers() { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 395 | for headers in rdr.headers()? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 395 | if let Ok(headers) = rdr.headers() { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/mod.rs:66:27 [INFO] [stdout] | [INFO] [stdout] 66 | RE.get_or_init(|| regex::Regex::new($re).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 247 | regex_consonant_upper: regex!(r"(?-u)[B-DF-HJ-NP-TV-Z]"), [INFO] [stdout] | --------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `regex` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/mod.rs:66:27 [INFO] [stdout] | [INFO] [stdout] 66 | RE.get_or_init(|| regex::Regex::new($re).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 248 | regex_consonant_lower: regex!(r"(?-u)[b-df-hj-np-tv-z]"), [INFO] [stdout] | --------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `regex` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/mod.rs:66:27 [INFO] [stdout] | [INFO] [stdout] 66 | RE.get_or_init(|| regex::Regex::new($re).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 249 | regex_vowel_upper: regex!(r"(?-u)[A|E|I|O|U]"), [INFO] [stdout] | --------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `regex` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/mod.rs:66:27 [INFO] [stdout] | [INFO] [stdout] 66 | RE.get_or_init(|| regex::Regex::new($re).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 250 | regex_vowel_lower: regex!(r"(?-u)[a|e|i|o|u]"), [INFO] [stdout] | --------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `regex` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/mod.rs:66:27 [INFO] [stdout] | [INFO] [stdout] 66 | RE.get_or_init(|| regex::Regex::new($re).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 251 | regex_numeric: regex!(r"(?-u)[0-9]"), [INFO] [stdout] | --------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `regex` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/mod.rs:66:27 [INFO] [stdout] | [INFO] [stdout] 66 | RE.get_or_init(|| regex::Regex::new($re).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 252 | regex_punctuation: regex!(r"(?-u)[.,\\/#!$%\\^&\\*;:{}=\\-_`~()\\?]"), [INFO] [stdout] | -------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `regex` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/mod.rs:66:27 [INFO] [stdout] | [INFO] [stdout] 66 | RE.get_or_init(|| regex::Regex::new($re).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 253 | regex_space: regex!(r"(?-u)[\s]"), [INFO] [stdout] | -------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `regex` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `test-data-generation` (lib) due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "0b868ac6cd8df99890da8850e65e4ebe5a69e2564576d6ad1d8d018d8c6e548d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b868ac6cd8df99890da8850e65e4ebe5a69e2564576d6ad1d8d018d8c6e548d", kill_on_drop: false }` [INFO] [stdout] 0b868ac6cd8df99890da8850e65e4ebe5a69e2564576d6ad1d8d018d8c6e548d