[INFO] fetching crate test-case-core 3.3.1... [INFO] checking test-case-core-3.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate test-case-core 3.3.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate test-case-core 3.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate test-case-core 3.3.1 [INFO] finished tweaking crates.io crate test-case-core 3.3.1 [INFO] tweaked toml for crates.io crate test-case-core 3.3.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b6bf3948122d899a8773b7f092b0a1f509a0d22661a4de6e23f86ffbcc4f7fc4 [INFO] running `Command { std: "docker" "start" "-a" "b6bf3948122d899a8773b7f092b0a1f509a0d22661a4de6e23f86ffbcc4f7fc4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b6bf3948122d899a8773b7f092b0a1f509a0d22661a4de6e23f86ffbcc4f7fc4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6bf3948122d899a8773b7f092b0a1f509a0d22661a4de6e23f86ffbcc4f7fc4", kill_on_drop: false }` [INFO] [stdout] b6bf3948122d899a8773b7f092b0a1f509a0d22661a4de6e23f86ffbcc4f7fc4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1a2b1d08cee8f71a12bde400e7f743342b0ebb92ffc88295dcd88e74000011b6 [INFO] running `Command { std: "docker" "start" "-a" "1a2b1d08cee8f71a12bde400e7f743342b0ebb92ffc88295dcd88e74000011b6", kill_on_drop: false }` [INFO] [stderr] Checking test-case-core v3.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/complex_expr.rs:122:12 [INFO] [stdout] | [INFO] [stdout] 120 | let item = Self::parse_single_item(input)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | [INFO] [stdout] 122 | Ok(if input.peek(kw::and) { [INFO] [stdout] | ____________^ [INFO] [stdout] 123 | | ComplexTestCase::And(parse_kw_repeat::(item, input)?) [INFO] [stdout] 124 | | } else if input.peek(kw::or) { [INFO] [stdout] 125 | | ComplexTestCase::Or(parse_kw_repeat::(item, input)?) [INFO] [stdout] 126 | | } else { [INFO] [stdout] 127 | | item [INFO] [stdout] 128 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:179:8 [INFO] [stdout] | [INFO] [stdout] 172 | extra_keywords: HashSet, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | mapping: Mapping, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | Ok(TestCaseExpression { [INFO] [stdout] | ________^ [INFO] [stdout] 180 | | _token: token, [INFO] [stdout] 181 | | extra_keywords, [INFO] [stdout] 182 | | result: mapping(input.parse()?), [INFO] [stdout] 183 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:197:8 [INFO] [stdout] | [INFO] [stdout] 189 | extra_keywords: HashSet, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | mapping: Mapping, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | let result = (!input.is_empty()).then(|| input.parse()).transpose()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | Ok(TestCaseExpression { [INFO] [stdout] | ________^ [INFO] [stdout] 198 | | _token: token, [INFO] [stdout] 199 | | extra_keywords, [INFO] [stdout] 200 | | result: mapping(result), [INFO] [stdout] 201 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_case.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 19 | let args = Punctuated::parse_separated_nonempty_with(input, Expr::parse)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let expression = (!input.is_empty()).then(|| input.parse()).transpose(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let comment = (!input.is_empty()).then(|| input.parse()).transpose(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let (expression, comment) = match (expression, comment) { [INFO] [stdout] | ---------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | (Err(expression), Err(_comment)) => return Err(expression), [INFO] [stdout] 27 | (expression, comment) => (expression.ok().flatten(), comment.ok().flatten()), [INFO] [stdout] | ---------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Ok(Self::new_from_parsed(args, expression, comment)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_case.rs:39:31 [INFO] [stdout] | [INFO] [stdout] 35 | args: I, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | expression: Option, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | comment: Option, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | ) -> Self { [INFO] [stdout] 39 | Self::new_from_parsed(args.into_iter().collect(), expression, comment) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_case.rs:167:29 [INFO] [stdout] | [INFO] [stdout] 160 | args: I, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | .unwrap_or_else(|| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 168 | | let mut acc = String::new(); [INFO] [stdout] 169 | | for arg in args { [INFO] [stdout] 170 | | acc.push_str(&fmt_syn(&arg)); [INFO] [stdout] ... | [INFO] [stdout] 178 | | acc [INFO] [stdout] 179 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_matrix/mod.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 28 | let expression = self.expression.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let comment = self.comment.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | matrix_product::multi_cartesian_product(self.variables.iter().cloned()).map(move |v| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_matrix/mod.rs:31:85 [INFO] [stdout] | [INFO] [stdout] 28 | let expression = self.expression.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let comment = self.comment.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | matrix_product::multi_cartesian_product(self.variables.iter().cloned()).map(move |v| { [INFO] [stdout] | _____________________________________________________________________________________^ [INFO] [stdout] 32 | | if let Some(comment) = comment.clone() { [INFO] [stdout] 33 | | TestCase::new_with_prefixed_name( [INFO] [stdout] 34 | | v, [INFO] [stdout] ... | [INFO] [stdout] 40 | | } [INFO] [stdout] 41 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_matrix/mod.rs:82:40 [INFO] [stdout] | [INFO] [stdout] 80 | ... let mut lit = Lit::new(Literal::isize_unsuffixed(n)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | ... lit.set_span(arg.span()); [INFO] [stdout] 82 | ... Expr::from(ExprLit { lit, attrs: vec![] }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_matrix/matrix_product.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn multi_cartesian_product(iters: H) -> MultiProduct<::IntoIter> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | / iters [INFO] [stdout] 40 | | .map(|i| MultiProductIter::new(i.into_iter())) [INFO] [stdout] 41 | | .collect(), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_matrix/matrix_product.rs:40:44 [INFO] [stdout] | [INFO] [stdout] 40 | .map(|i| MultiProductIter::new(i.into_iter())) [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_matrix/matrix_product.rs:118:31 [INFO] [stdout] | [INFO] [stdout] 118 | .map(|multi_iter| multi_iter.cur.clone().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_matrix/matrix_product.rs:140:18 [INFO] [stdout] | [INFO] [stdout] 138 | fn new(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | MultiProductIter { [INFO] [stdout] 140 | cur: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_matrix/matrix_product.rs:141:19 [INFO] [stdout] | [INFO] [stdout] 138 | fn new(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | iter: iter.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_matrix/matrix_product.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 178 | fn count(self) -> usize { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | self.0.into_iter().fold( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `test-case-core` (lib) due to 16 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/complex_expr.rs:122:12 [INFO] [stdout] | [INFO] [stdout] 120 | let item = Self::parse_single_item(input)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | [INFO] [stdout] 122 | Ok(if input.peek(kw::and) { [INFO] [stdout] | ____________^ [INFO] [stdout] 123 | | ComplexTestCase::And(parse_kw_repeat::(item, input)?) [INFO] [stdout] 124 | | } else if input.peek(kw::or) { [INFO] [stdout] 125 | | ComplexTestCase::Or(parse_kw_repeat::(item, input)?) [INFO] [stdout] 126 | | } else { [INFO] [stdout] 127 | | item [INFO] [stdout] 128 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/complex_expr.rs:643:13 [INFO] [stdout] | [INFO] [stdout] 640 | let actual: ComplexTestCase = parse_quote! { contains_in_order [1, 2, 3] }; [INFO] [stdout] | ------ -------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 643 | / ComplexTestCase::ContainsInOrder(ContainsInOrder { [INFO] [stdout] 644 | | expected_slice: Box::new(parse_quote! { [1, 2, 3] }) [INFO] [stdout] 645 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/complex_expr.rs:662:13 [INFO] [stdout] | [INFO] [stdout] 651 | let actual1: ComplexTestCase = parse_quote! { len 10 }; [INFO] [stdout] | ------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 652 | let actual2: ComplexTestCase = parse_quote! { has_length 11 }; [INFO] [stdout] | ------- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 662 | / ComplexTestCase::Len(Len { [INFO] [stdout] 663 | | expected_len: Box::new(parse_quote! { 11 }) [INFO] [stdout] 664 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/complex_expr.rs:680:13 [INFO] [stdout] | [INFO] [stdout] 670 | let actual1: ComplexTestCase = parse_quote! { count 10 }; [INFO] [stdout] | ------- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 671 | let actual2: ComplexTestCase = parse_quote! { has_count 11 }; [INFO] [stdout] | ------- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 680 | / ComplexTestCase::Count(Count { [INFO] [stdout] 681 | | expected_len: Box::new(parse_quote! { 11 }) [INFO] [stdout] 682 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/complex_expr.rs:689:28 [INFO] [stdout] | [INFO] [stdout] 688 | let actual: ComplexTestCase = parse_quote! { empty }; [INFO] [stdout] | ------ ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 689 | assert_eq!(actual, ComplexTestCase::Empty,) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:179:8 [INFO] [stdout] | [INFO] [stdout] 172 | extra_keywords: HashSet, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | mapping: Mapping, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | Ok(TestCaseExpression { [INFO] [stdout] | ________^ [INFO] [stdout] 180 | | _token: token, [INFO] [stdout] 181 | | extra_keywords, [INFO] [stdout] 182 | | result: mapping(input.parse()?), [INFO] [stdout] 183 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:197:8 [INFO] [stdout] | [INFO] [stdout] 189 | extra_keywords: HashSet, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | mapping: Mapping, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | let result = (!input.is_empty()).then(|| input.parse()).transpose()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | Ok(TestCaseExpression { [INFO] [stdout] | ________^ [INFO] [stdout] 198 | | _token: token, [INFO] [stdout] 199 | | extra_keywords, [INFO] [stdout] 200 | | result: mapping(result), [INFO] [stdout] 201 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_case.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 19 | let args = Punctuated::parse_separated_nonempty_with(input, Expr::parse)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let expression = (!input.is_empty()).then(|| input.parse()).transpose(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let comment = (!input.is_empty()).then(|| input.parse()).transpose(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let (expression, comment) = match (expression, comment) { [INFO] [stdout] | ---------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | (Err(expression), Err(_comment)) => return Err(expression), [INFO] [stdout] 27 | (expression, comment) => (expression.ok().flatten(), comment.ok().flatten()), [INFO] [stdout] | ---------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Ok(Self::new_from_parsed(args, expression, comment)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_case.rs:39:31 [INFO] [stdout] | [INFO] [stdout] 35 | args: I, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | expression: Option, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | comment: Option, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | ) -> Self { [INFO] [stdout] 39 | Self::new_from_parsed(args.into_iter().collect(), expression, comment) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_case.rs:167:29 [INFO] [stdout] | [INFO] [stdout] 160 | args: I, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | .unwrap_or_else(|| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 168 | | let mut acc = String::new(); [INFO] [stdout] 169 | | for arg in args { [INFO] [stdout] 170 | | acc.push_str(&fmt_syn(&arg)); [INFO] [stdout] ... | [INFO] [stdout] 178 | | acc [INFO] [stdout] 179 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_matrix/mod.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 28 | let expression = self.expression.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let comment = self.comment.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | matrix_product::multi_cartesian_product(self.variables.iter().cloned()).map(move |v| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_matrix/mod.rs:31:85 [INFO] [stdout] | [INFO] [stdout] 28 | let expression = self.expression.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let comment = self.comment.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | matrix_product::multi_cartesian_product(self.variables.iter().cloned()).map(move |v| { [INFO] [stdout] | _____________________________________________________________________________________^ [INFO] [stdout] 32 | | if let Some(comment) = comment.clone() { [INFO] [stdout] 33 | | TestCase::new_with_prefixed_name( [INFO] [stdout] 34 | | v, [INFO] [stdout] ... | [INFO] [stdout] 40 | | } [INFO] [stdout] 41 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_matrix/mod.rs:82:40 [INFO] [stdout] | [INFO] [stdout] 80 | ... let mut lit = Lit::new(Literal::isize_unsuffixed(n)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | ... lit.set_span(arg.span()); [INFO] [stdout] 82 | ... Expr::from(ExprLit { lit, attrs: vec![] }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_matrix/matrix_product.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn multi_cartesian_product(iters: H) -> MultiProduct<::IntoIter> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | / iters [INFO] [stdout] 40 | | .map(|i| MultiProductIter::new(i.into_iter())) [INFO] [stdout] 41 | | .collect(), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_matrix/matrix_product.rs:40:44 [INFO] [stdout] | [INFO] [stdout] 40 | .map(|i| MultiProductIter::new(i.into_iter())) [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_matrix/matrix_product.rs:118:31 [INFO] [stdout] | [INFO] [stdout] 118 | .map(|multi_iter| multi_iter.cur.clone().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_matrix/matrix_product.rs:140:18 [INFO] [stdout] | [INFO] [stdout] 138 | fn new(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | MultiProductIter { [INFO] [stdout] 140 | cur: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_matrix/matrix_product.rs:141:19 [INFO] [stdout] | [INFO] [stdout] 138 | fn new(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | iter: iter.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_matrix/matrix_product.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 178 | fn count(self) -> usize { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | self.0.into_iter().fold( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `test-case-core` (lib test) due to 20 previous errors [INFO] running `Command { std: "docker" "inspect" "1a2b1d08cee8f71a12bde400e7f743342b0ebb92ffc88295dcd88e74000011b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a2b1d08cee8f71a12bde400e7f743342b0ebb92ffc88295dcd88e74000011b6", kill_on_drop: false }` [INFO] [stdout] 1a2b1d08cee8f71a12bde400e7f743342b0ebb92ffc88295dcd88e74000011b6