[INFO] fetching crate test-binary-features 0.0.1... [INFO] checking test-binary-features-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate test-binary-features 0.0.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate test-binary-features 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate test-binary-features 0.0.1 [INFO] finished tweaking crates.io crate test-binary-features 0.0.1 [INFO] tweaked toml for crates.io crate test-binary-features 0.0.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 21 packages to latest compatible versions [INFO] [stderr] Adding cargo_metadata v0.15.4 (latest: v0.18.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 27860a4546c6f76563cf72bd3d244189ed8b7f7f10191fdc142dc599fbb57fe3 [INFO] running `Command { std: "docker" "start" "-a" "27860a4546c6f76563cf72bd3d244189ed8b7f7f10191fdc142dc599fbb57fe3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "27860a4546c6f76563cf72bd3d244189ed8b7f7f10191fdc142dc599fbb57fe3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27860a4546c6f76563cf72bd3d244189ed8b7f7f10191fdc142dc599fbb57fe3", kill_on_drop: false }` [INFO] [stdout] 27860a4546c6f76563cf72bd3d244189ed8b7f7f10191fdc142dc599fbb57fe3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7d7d3f98804302a6868b8d4cff4e4721e5daa6bde4a138745743a2448b59e3e5 [INFO] running `Command { std: "docker" "start" "-a" "7d7d3f98804302a6868b8d4cff4e4721e5daa6bde4a138745743a2448b59e3e5", kill_on_drop: false }` [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling camino v1.1.9 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking phantom_newtype v0.2.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking cargo_metadata v0.15.4 [INFO] [stderr] Checking test-binary v3.0.2 [INFO] [stderr] Checking test-binary-features v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Deref` [INFO] [stdout] --> src/group.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use core::ops::{Deref, DerefMut}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DerefMut` [INFO] [stdout] --> src/group.rs:5:24 [INFO] [stdout] | [INFO] [stdout] 5 | use core::ops::{Deref, DerefMut}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `DerefMut` and `Deref` [INFO] [stdout] --> src/group.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use core::ops::{Deref, DerefMut}; [INFO] [stdout] | ^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BinaryCrateName`, `GroupEnd`, and `group` [INFO] [stdout] --> src/unit_tests/group_tests.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | group, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 3 | indicators::{BinaryCrateName, GroupEnd}, [INFO] [stdout] | ^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `parent_dir` [INFO] [stdout] --> src/sequence_of_groups.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | parent_dir: &S, [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_parent_dir` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sub_dir` [INFO] [stdout] --> src/sequence_of_groups.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | sub_dir: &S, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sub_dir` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `feature_sets` [INFO] [stdout] --> src/sequence_of_groups.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | feature_sets: FEATURE_SETS, [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_feature_sets` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `group_until` [INFO] [stdout] --> src/sequence_of_groups.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | group_until: GroupEnd, [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_group_until` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `print_output` is never used [INFO] [stdout] --> src/group.rs:197:15 [INFO] [stdout] | [INFO] [stdout] 197 | pub(crate) fn print_output(output: &ProcessOutput) -> IoResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `ContinueRegardlessOfOthers` and `StopOnOthersFailure` are never constructed [INFO] [stdout] --> src/indicators.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 58 | pub enum SequenceEnd { [INFO] [stdout] | ----------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 61 | ContinueRegardlessOfOthers, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 62 | /// If any other sequence fails, stop this one, too. (Then follow this sequence's [GroupEnd].) [INFO] [stdout] 63 | StopOnOthersFailure, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `ProcessOutput` is never used [INFO] [stdout] --> src/output.rs:9:10 [INFO] [stdout] | [INFO] [stdout] 9 | pub type ProcessOutput = Output; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `sequence_single_tasks` is never used [INFO] [stdout] --> src/sequence_of_groups.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn sequence_single_tasks< [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/group.rs:171:6 [INFO] [stdout] | [INFO] [stdout] 145 | tasks: ParallelTasks<'a, S, M>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | let mut children = GroupOfChildren::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let mut spawning_mode = SpawningMode::default(); [INFO] [stdout] 156 | let mut errors = Vec::with_capacity(0); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | ((children, spawning_mode), errors) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `test-binary-features` (lib) due to 2 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `parent_dir` [INFO] [stdout] --> src/sequence_of_groups.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | parent_dir: &S, [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_parent_dir` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sub_dir` [INFO] [stdout] --> src/sequence_of_groups.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | sub_dir: &S, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sub_dir` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `feature_sets` [INFO] [stdout] --> src/sequence_of_groups.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | feature_sets: FEATURE_SETS, [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_feature_sets` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `group_until` [INFO] [stdout] --> src/sequence_of_groups.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | group_until: GroupEnd, [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_group_until` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `print_output` is never used [INFO] [stdout] --> src/group.rs:197:15 [INFO] [stdout] | [INFO] [stdout] 197 | pub(crate) fn print_output(output: &ProcessOutput) -> IoResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `ContinueRegardlessOfOthers` and `StopOnOthersFailure` are never constructed [INFO] [stdout] --> src/indicators.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 58 | pub enum SequenceEnd { [INFO] [stdout] | ----------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 61 | ContinueRegardlessOfOthers, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 62 | /// If any other sequence fails, stop this one, too. (Then follow this sequence's [GroupEnd].) [INFO] [stdout] 63 | StopOnOthersFailure, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `ProcessOutput` is never used [INFO] [stdout] --> src/output.rs:9:10 [INFO] [stdout] | [INFO] [stdout] 9 | pub type ProcessOutput = Output; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `sequence_single_tasks` is never used [INFO] [stdout] --> src/sequence_of_groups.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn sequence_single_tasks< [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/group.rs:171:6 [INFO] [stdout] | [INFO] [stdout] 145 | tasks: ParallelTasks<'a, S, M>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | let mut children = GroupOfChildren::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let mut spawning_mode = SpawningMode::default(); [INFO] [stdout] 156 | let mut errors = Vec::with_capacity(0); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | ((children, spawning_mode), errors) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unit_tests/output_tests.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 10 | fn output(path: impl AsRef, arg: Option>) -> Output { [INFO] [stdout] | ----------------------- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | let mut command = Command::new(path); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let mut child = command.spawn().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let _ = child.wait().unwrap(); [INFO] [stdout] 20 | child.wait_with_output().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `test-binary-features` (lib test) due to 3 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7d7d3f98804302a6868b8d4cff4e4721e5daa6bde4a138745743a2448b59e3e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d7d3f98804302a6868b8d4cff4e4721e5daa6bde4a138745743a2448b59e3e5", kill_on_drop: false }` [INFO] [stdout] 7d7d3f98804302a6868b8d4cff4e4721e5daa6bde4a138745743a2448b59e3e5