[INFO] fetching crate terrars 0.1.13... [INFO] checking terrars-0.1.13 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate terrars 0.1.13 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate terrars 0.1.13 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate terrars 0.1.13 [INFO] finished tweaking crates.io crate terrars 0.1.13 [INFO] tweaked toml for crates.io crate terrars 0.1.13 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate terrars 0.1.13 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 30e19e73a91e8bdd41dca3f3426c8516ea1e732ee62521a4d6a868659ef1aced [INFO] running `Command { std: "docker" "start" "-a" "30e19e73a91e8bdd41dca3f3426c8516ea1e732ee62521a4d6a868659ef1aced", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "30e19e73a91e8bdd41dca3f3426c8516ea1e732ee62521a4d6a868659ef1aced", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30e19e73a91e8bdd41dca3f3426c8516ea1e732ee62521a4d6a868659ef1aced", kill_on_drop: false }` [INFO] [stdout] 30e19e73a91e8bdd41dca3f3426c8516ea1e732ee62521a4d6a868659ef1aced [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d70dca7e83f14eba95f54040800b61da64a2d718ad3b188bd1b42dae5455bc4e [INFO] running `Command { std: "docker" "start" "-a" "d70dca7e83f14eba95f54040800b61da64a2d718ad3b188bd1b42dae5455bc4e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Compiling linux-raw-sys v0.3.8 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Compiling unicode-width v0.1.13 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling winnow v0.6.14 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Compiling smawk v0.3.2 [INFO] [stderr] Compiling iana-time-zone v0.1.60 [INFO] [stderr] Compiling unicode-linebreak v0.1.5 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling unicode-id v0.3.4 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling markdown v1.0.0-alpha.18 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling litrs v0.2.3 [INFO] [stderr] Compiling convert_case v0.6.0 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.2 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling console v0.15.8 [INFO] [stderr] Checking vte v0.10.1 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking typeid v1.0.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking ansitok v0.2.0 [INFO] [stderr] Checking terminal_size v0.2.6 [INFO] [stderr] Checking ansi-str v0.8.0 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking loga v0.5.2 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling structre_proc_macros v0.0.3 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking structre v0.0.4 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking comfy-table v7.1.1 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking erased-serde v0.4.5 [INFO] [stderr] Checking toml_edit v0.22.16 [INFO] [stderr] Checking toml v0.8.15 [INFO] [stderr] Checking cargo-manifest v0.15.0 [INFO] [stderr] Checking cargo_toml v0.20.4 [INFO] [stderr] Checking genemichaels-lib v0.5.0 [INFO] [stderr] Compiling aargvark_proc_macros v0.1.2 [INFO] [stderr] Checking aargvark v0.3.0 [INFO] [stderr] Checking terrars v0.1.13 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:323:13 [INFO] [stdout] | [INFO] [stdout] 310 | let mut command = Command::new("terraform"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | / serde_json::from_slice( [INFO] [stdout] 324 | | &serde_json::to_vec( [INFO] [stdout] 325 | | &serde_json::from_slice::>(&res.stdout)? [INFO] [stdout] 326 | | .into_iter() [INFO] [stdout] ... | [INFO] [stdout] 329 | | )?, [INFO] [stdout] 330 | | )?, [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 51 | let data = self.data.borrow(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | serde_json::to_value(&*data).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prim_field.rs:30:28 [INFO] [stdout] | [INFO] [stdout] 27 | fn serialize2(&self, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | REPLACE_EXPRS.with(|f| { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 31 | | if let Some(vs) = f.borrow().as_ref() { [INFO] [stdout] 32 | | let mut out = self.replace("%{", "%%{").replace("${", "$${"); [INFO] [stdout] 33 | | for (k, v) in vs { [INFO] [stdout] ... | [INFO] [stdout] 39 | | } [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variable.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 58 | let data = self.data.borrow(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | serde_json::to_value(&*data).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `terrars` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:323:13 [INFO] [stdout] | [INFO] [stdout] 310 | let mut command = Command::new("terraform"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | / serde_json::from_slice( [INFO] [stdout] 324 | | &serde_json::to_vec( [INFO] [stdout] 325 | | &serde_json::from_slice::>(&res.stdout)? [INFO] [stdout] 326 | | .into_iter() [INFO] [stdout] ... | [INFO] [stdout] 329 | | )?, [INFO] [stdout] 330 | | )?, [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 51 | let data = self.data.borrow(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | serde_json::to_value(&*data).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prim_field.rs:30:28 [INFO] [stdout] | [INFO] [stdout] 27 | fn serialize2(&self, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | REPLACE_EXPRS.with(|f| { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 31 | | if let Some(vs) = f.borrow().as_ref() { [INFO] [stdout] 32 | | let mut out = self.replace("%{", "%%{").replace("${", "$${"); [INFO] [stdout] 33 | | for (k, v) in vs { [INFO] [stdout] ... | [INFO] [stdout] 39 | | } [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variable.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 58 | let data = self.data.borrow(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | serde_json::to_value(&*data).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `terrars` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "d70dca7e83f14eba95f54040800b61da64a2d718ad3b188bd1b42dae5455bc4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d70dca7e83f14eba95f54040800b61da64a2d718ad3b188bd1b42dae5455bc4e", kill_on_drop: false }` [INFO] [stdout] d70dca7e83f14eba95f54040800b61da64a2d718ad3b188bd1b42dae5455bc4e