[INFO] fetching crate tentacli 14.0.1... [INFO] checking tentacli-14.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tentacli 14.0.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate tentacli 14.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tentacli 14.0.1 [INFO] finished tweaking crates.io crate tentacli 14.0.1 [INFO] tweaked toml for crates.io crate tentacli 14.0.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate tentacli 14.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fe67cc6b07f86a6d4e93b5bdf71e3df9b970c35da96051fea5bcdd00dfcdf482 [INFO] running `Command { std: "docker" "start" "-a" "fe67cc6b07f86a6d4e93b5bdf71e3df9b970c35da96051fea5bcdd00dfcdf482", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fe67cc6b07f86a6d4e93b5bdf71e3df9b970c35da96051fea5bcdd00dfcdf482", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe67cc6b07f86a6d4e93b5bdf71e3df9b970c35da96051fea5bcdd00dfcdf482", kill_on_drop: false }` [INFO] [stdout] fe67cc6b07f86a6d4e93b5bdf71e3df9b970c35da96051fea5bcdd00dfcdf482 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b4102736d593976a57a9116de27f4f682a991de19187197cf9f4cfd00aed7526 [INFO] running `Command { std: "docker" "start" "-a" "b4102736d593976a57a9116de27f4f682a991de19187197cf9f4cfd00aed7526", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling hashbrown v0.12.3 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Compiling serde_json v1.0.121 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling thiserror v1.0.59 [INFO] [stderr] Compiling fsio v0.1.3 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking event-listener v5.3.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking event-listener-strategy v0.5.1 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Checking crypto-mac v0.11.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking hmac v0.11.0 [INFO] [stderr] Checking sha-1 v0.9.8 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking async-broadcast v0.7.1 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Compiling envmnt v0.8.4 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking tentacli-utils v2.1.0 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Compiling nias v0.5.0 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Compiling ci_info v0.10.2 [INFO] [stderr] Checking tui v0.19.0 [INFO] [stderr] Checking hmac-sha v0.6.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking tentacli-crypto v0.1.0 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Compiling serde_derive v1.0.198 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling structmeta-derive v0.3.0 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Compiling rusty-hook v0.11.2 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling structmeta v0.3.0 [INFO] [stderr] Compiling tentacli-packet v7.0.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tentacli-traits v8.0.2 [INFO] [stderr] Checking tentacli-formatters v0.1.0 [INFO] [stderr] Checking tentacli v14.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/features/ui/mod.rs:102:26 [INFO] [stdout] | [INFO] [stdout] 75 | let sender = self._sender.as_ref().ok_or(FeatureError::SenderNotFound)?.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let terminal = Arc::clone(&terminal); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | let event_flags = Arc::clone(&event_flags); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let characters_modal = Arc::clone(&characters_modal); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | let debug_panel = Arc::clone(&debug_panel); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | let realm_modal = Arc::clone(&realm_modal); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | [INFO] [stdout] 102 | tokio::spawn(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 103 | | let mut reader = EventStream::new(); [INFO] [stdout] 104 | | [INFO] [stdout] 105 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 173 | | } [INFO] [stdout] 174 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/features/ui/mod.rs:183:26 [INFO] [stdout] | [INFO] [stdout] 76 | let mut receiver = self._receiver.as_mut().ok_or(FeatureError::ReceiverNotFound)?.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | let event_flags = Arc::clone(&event_flags); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | let characters_modal = Arc::clone(&characters_modal); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | let debug_panel = Arc::clone(&debug_panel); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | let realm_modal = Arc::clone(&realm_modal); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | [INFO] [stdout] 183 | tokio::spawn(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 184 | | loop { [INFO] [stdout] 185 | | if let Ok(output) = receiver.recv().await { [INFO] [stdout] 186 | | match output { [INFO] [stdout] ... | [INFO] [stdout] 227 | | } [INFO] [stdout] 228 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/features/ui/mod.rs:239:26 [INFO] [stdout] | [INFO] [stdout] 232 | let terminal = Arc::clone(&terminal); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | let event_flags = Arc::clone(&event_flags); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | let characters_modal = Arc::clone(&characters_modal); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | let debug_panel = Arc::clone(&debug_panel); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | let realm_modal = Arc::clone(&realm_modal); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | let title = Arc::clone(&title); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | [INFO] [stdout] 239 | tokio::spawn(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 240 | | { [INFO] [stdout] 241 | | terminal.lock().unwrap().clear().unwrap(); [INFO] [stdout] 242 | | terminal.lock().unwrap().hide_cursor().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 270 | | } [INFO] [stdout] 271 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/features/wotlk_login/mod.rs:39:26 [INFO] [stdout] | [INFO] [stdout] 35 | let sender = self._sender.as_ref().ok_or(FeatureError::SenderNotFound)?.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let mut receiver = self._receiver.as_mut().ok_or(FeatureError::ReceiverNotFound)?.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | tokio::spawn(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 40 | | loop { [INFO] [stdout] 41 | | if let Ok(HandlerOutput::ExitRequest) = receiver.recv().await { [INFO] [stdout] 42 | | sender.broadcast( [INFO] [stdout] ... | [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primary/client.rs:50:22 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(options: CreateOptions) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Self { [INFO] [stdout] 50 | _reader: Arc::new(Mutex::new(None)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primary/client.rs:51:22 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(options: CreateOptions) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | _writer: Arc::new(Mutex::new(None)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primary/client.rs:52:28 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(options: CreateOptions) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | _warden_crypt: Arc::new(SyncMutex::new(None)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primary/client.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(options: CreateOptions) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | session: Arc::new(Mutex::new(Session::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primary/client.rs:55:27 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(options: CreateOptions) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | data_storage: options.data_storage [INFO] [stdout] | ___________________________^ [INFO] [stdout] 56 | | .unwrap_or_else(|| Arc::new(SyncMutex::new(DataStorage::default()))), [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primary/client.rs:224:22 [INFO] [stdout] | [INFO] [stdout] 215 | mut signal_receiver: Receiver, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | query_sender: BroadcastSender, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | notify: Arc, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | features: Vec>, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | ) -> JoinHandle<()> { [INFO] [stdout] 220 | let reader = Arc::clone(&self._reader); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | let session = Arc::clone(&self.session); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | let data_storage = Arc::clone(&self.data_storage); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | [INFO] [stdout] 224 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 225 | | let mut realm_processors = vec![]; [INFO] [stdout] 226 | | let mut processors = vec![]; [INFO] [stdout] 227 | | let mut one_time_handler_maps = vec![]; [INFO] [stdout] ... | [INFO] [stdout] 308 | | } [INFO] [stdout] 309 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primary/client.rs:355:22 [INFO] [stdout] | [INFO] [stdout] 344 | signal_sender: Sender, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | output_sender: Sender, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 346 | query_sender: BroadcastSender, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 347 | mut query_receiver: BroadcastReceiver, [INFO] [stdout] | ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | notify: Arc, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 349 | ) -> JoinHandle<()> { [INFO] [stdout] 350 | let session = Arc::clone(&self.session); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 351 | let reader = Arc::clone(&self._reader); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 352 | let writer = Arc::clone(&self._writer); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | let warden_crypt = Arc::clone(&self._warden_crypt); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 354 | [INFO] [stdout] 355 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 356 | | loop { [INFO] [stdout] 357 | | let result = query_receiver.recv().await; [INFO] [stdout] 358 | | match result { [INFO] [stdout] ... | [INFO] [stdout] 421 | | } [INFO] [stdout] 422 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primary/client.rs:432:22 [INFO] [stdout] | [INFO] [stdout] 427 | mut output_receiver: Receiver, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 428 | query_sender: BroadcastSender, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 429 | ) -> JoinHandle<()> { [INFO] [stdout] 430 | let writer = Arc::clone(&self._writer); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 431 | [INFO] [stdout] 432 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 433 | | loop { [INFO] [stdout] 434 | | if let Some(packet) = output_receiver.recv().await { [INFO] [stdout] 435 | | if !packet.data.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 461 | | } [INFO] [stdout] 462 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tentacli` (lib test) due to 13 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/features/ui/mod.rs:102:26 [INFO] [stdout] | [INFO] [stdout] 75 | let sender = self._sender.as_ref().ok_or(FeatureError::SenderNotFound)?.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let terminal = Arc::clone(&terminal); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | let event_flags = Arc::clone(&event_flags); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let characters_modal = Arc::clone(&characters_modal); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | let debug_panel = Arc::clone(&debug_panel); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | let realm_modal = Arc::clone(&realm_modal); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | [INFO] [stdout] 102 | tokio::spawn(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 103 | | let mut reader = EventStream::new(); [INFO] [stdout] 104 | | [INFO] [stdout] 105 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 173 | | } [INFO] [stdout] 174 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/features/ui/mod.rs:183:26 [INFO] [stdout] | [INFO] [stdout] 76 | let mut receiver = self._receiver.as_mut().ok_or(FeatureError::ReceiverNotFound)?.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | let event_flags = Arc::clone(&event_flags); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | let characters_modal = Arc::clone(&characters_modal); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | let debug_panel = Arc::clone(&debug_panel); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | let realm_modal = Arc::clone(&realm_modal); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | [INFO] [stdout] 183 | tokio::spawn(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 184 | | loop { [INFO] [stdout] 185 | | if let Ok(output) = receiver.recv().await { [INFO] [stdout] 186 | | match output { [INFO] [stdout] ... | [INFO] [stdout] 227 | | } [INFO] [stdout] 228 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/features/ui/mod.rs:239:26 [INFO] [stdout] | [INFO] [stdout] 232 | let terminal = Arc::clone(&terminal); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | let event_flags = Arc::clone(&event_flags); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | let characters_modal = Arc::clone(&characters_modal); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | let debug_panel = Arc::clone(&debug_panel); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | let realm_modal = Arc::clone(&realm_modal); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | let title = Arc::clone(&title); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | [INFO] [stdout] 239 | tokio::spawn(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 240 | | { [INFO] [stdout] 241 | | terminal.lock().unwrap().clear().unwrap(); [INFO] [stdout] 242 | | terminal.lock().unwrap().hide_cursor().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 270 | | } [INFO] [stdout] 271 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/features/wotlk_login/mod.rs:39:26 [INFO] [stdout] | [INFO] [stdout] 35 | let sender = self._sender.as_ref().ok_or(FeatureError::SenderNotFound)?.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let mut receiver = self._receiver.as_mut().ok_or(FeatureError::ReceiverNotFound)?.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | tokio::spawn(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 40 | | loop { [INFO] [stdout] 41 | | if let Ok(HandlerOutput::ExitRequest) = receiver.recv().await { [INFO] [stdout] 42 | | sender.broadcast( [INFO] [stdout] ... | [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primary/client.rs:50:22 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(options: CreateOptions) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Self { [INFO] [stdout] 50 | _reader: Arc::new(Mutex::new(None)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primary/client.rs:51:22 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(options: CreateOptions) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | _writer: Arc::new(Mutex::new(None)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primary/client.rs:52:28 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(options: CreateOptions) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | _warden_crypt: Arc::new(SyncMutex::new(None)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primary/client.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(options: CreateOptions) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | session: Arc::new(Mutex::new(Session::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primary/client.rs:55:27 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(options: CreateOptions) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | data_storage: options.data_storage [INFO] [stdout] | ___________________________^ [INFO] [stdout] 56 | | .unwrap_or_else(|| Arc::new(SyncMutex::new(DataStorage::default()))), [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primary/client.rs:224:22 [INFO] [stdout] | [INFO] [stdout] 215 | mut signal_receiver: Receiver, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | query_sender: BroadcastSender, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | notify: Arc, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | features: Vec>, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | ) -> JoinHandle<()> { [INFO] [stdout] 220 | let reader = Arc::clone(&self._reader); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | let session = Arc::clone(&self.session); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | let data_storage = Arc::clone(&self.data_storage); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | [INFO] [stdout] 224 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 225 | | let mut realm_processors = vec![]; [INFO] [stdout] 226 | | let mut processors = vec![]; [INFO] [stdout] 227 | | let mut one_time_handler_maps = vec![]; [INFO] [stdout] ... | [INFO] [stdout] 308 | | } [INFO] [stdout] 309 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primary/client.rs:355:22 [INFO] [stdout] | [INFO] [stdout] 344 | signal_sender: Sender, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | output_sender: Sender, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 346 | query_sender: BroadcastSender, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 347 | mut query_receiver: BroadcastReceiver, [INFO] [stdout] | ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | notify: Arc, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 349 | ) -> JoinHandle<()> { [INFO] [stdout] 350 | let session = Arc::clone(&self.session); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 351 | let reader = Arc::clone(&self._reader); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 352 | let writer = Arc::clone(&self._writer); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | let warden_crypt = Arc::clone(&self._warden_crypt); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 354 | [INFO] [stdout] 355 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 356 | | loop { [INFO] [stdout] 357 | | let result = query_receiver.recv().await; [INFO] [stdout] 358 | | match result { [INFO] [stdout] ... | [INFO] [stdout] 421 | | } [INFO] [stdout] 422 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primary/client.rs:432:22 [INFO] [stdout] | [INFO] [stdout] 427 | mut output_receiver: Receiver, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 428 | query_sender: BroadcastSender, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 429 | ) -> JoinHandle<()> { [INFO] [stdout] 430 | let writer = Arc::clone(&self._writer); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 431 | [INFO] [stdout] 432 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 433 | | loop { [INFO] [stdout] 434 | | if let Some(packet) = output_receiver.recv().await { [INFO] [stdout] 435 | | if !packet.data.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 461 | | } [INFO] [stdout] 462 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tentacli` (lib) due to 13 previous errors [INFO] running `Command { std: "docker" "inspect" "b4102736d593976a57a9116de27f4f682a991de19187197cf9f4cfd00aed7526", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b4102736d593976a57a9116de27f4f682a991de19187197cf9f4cfd00aed7526", kill_on_drop: false }` [INFO] [stdout] b4102736d593976a57a9116de27f4f682a991de19187197cf9f4cfd00aed7526