[INFO] fetching crate tendermint-p2p 0.39.1... [INFO] checking tendermint-p2p-0.39.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tendermint-p2p 0.39.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate tendermint-p2p 0.39.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tendermint-p2p 0.39.1 [INFO] finished tweaking crates.io crate tendermint-p2p 0.39.1 [INFO] tweaked toml for crates.io crate tendermint-p2p 0.39.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 92 packages to latest compatible versions [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 85f14a982145cbe6037eedaa49906686a62043b28c4b9eae727ad7658fd30bff [INFO] running `Command { std: "docker" "start" "-a" "85f14a982145cbe6037eedaa49906686a62043b28c4b9eae727ad7658fd30bff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "85f14a982145cbe6037eedaa49906686a62043b28c4b9eae727ad7658fd30bff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "85f14a982145cbe6037eedaa49906686a62043b28c4b9eae727ad7658fd30bff", kill_on_drop: false }` [INFO] [stdout] 85f14a982145cbe6037eedaa49906686a62043b28c4b9eae727ad7658fd30bff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1f6c4dec1423f975c4e3c6d8f1703848edc3436f66797ba8253f0102d70d305e [INFO] running `Command { std: "docker" "start" "-a" "1f6c4dec1423f975c4e3c6d8f1703848edc3436f66797ba8253f0102d70d305e", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking subtle-ng v2.5.0 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking tendermint-std-ext v0.39.1 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking flex-error v0.4.4 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling prost-derive v0.13.2 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking subtle-encoding v0.5.1 [INFO] [stderr] Checking curve25519-dalek-ng v4.1.1 [INFO] [stderr] Checking merlin v3.0.0 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking ed25519-consensus v2.1.0 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking prost v0.13.2 [INFO] [stderr] Checking tendermint-proto v0.39.1 [INFO] [stderr] Checking tendermint v0.39.1 [INFO] [stderr] Checking tendermint-p2p v0.39.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secret_connection.rs:160:12 [INFO] [stdout] | [INFO] [stdout] 122 | let mut transcript = Transcript::new(b"TENDERMINT_SECRET_CONNECTION_TRANSCRIPT_HASH"); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | let kdf = Kdf::derive_secrets_and_challenge(shared_secret.as_bytes(), loc_is_least); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | Ok(Handshake { [INFO] [stdout] | ____________^ [INFO] [stdout] 161 | | protocol_version: self.protocol_version, [INFO] [stdout] 162 | | state: AwaitingAuthSig { [INFO] [stdout] 163 | | sc_mac, [INFO] [stdout] ... | [INFO] [stdout] 168 | | }, [INFO] [stdout] 169 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secret_connection.rs:353:12 [INFO] [stdout] | [INFO] [stdout] 351 | pub fn split(self) -> Result<(Sender, Receiver), Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 352 | let remote_pubkey = self.remote_pubkey.expect("remote_pubkey to be initialized"); [INFO] [stdout] 353 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 354 | | Sender { [INFO] [stdout] 355 | | io_handler: self [INFO] [stdout] 356 | | .io_handler [INFO] [stdout] ... | [INFO] [stdout] 368 | | }, [INFO] [stdout] 369 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tendermint-p2p` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secret_connection.rs:160:12 [INFO] [stdout] | [INFO] [stdout] 122 | let mut transcript = Transcript::new(b"TENDERMINT_SECRET_CONNECTION_TRANSCRIPT_HASH"); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | let kdf = Kdf::derive_secrets_and_challenge(shared_secret.as_bytes(), loc_is_least); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | Ok(Handshake { [INFO] [stdout] | ____________^ [INFO] [stdout] 161 | | protocol_version: self.protocol_version, [INFO] [stdout] 162 | | state: AwaitingAuthSig { [INFO] [stdout] 163 | | sc_mac, [INFO] [stdout] ... | [INFO] [stdout] 168 | | }, [INFO] [stdout] 169 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secret_connection.rs:353:12 [INFO] [stdout] | [INFO] [stdout] 351 | pub fn split(self) -> Result<(Sender, Receiver), Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 352 | let remote_pubkey = self.remote_pubkey.expect("remote_pubkey to be initialized"); [INFO] [stdout] 353 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 354 | | Sender { [INFO] [stdout] 355 | | io_handler: self [INFO] [stdout] 356 | | .io_handler [INFO] [stdout] ... | [INFO] [stdout] 368 | | }, [INFO] [stdout] 369 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tendermint-p2p` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "1f6c4dec1423f975c4e3c6d8f1703848edc3436f66797ba8253f0102d70d305e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f6c4dec1423f975c4e3c6d8f1703848edc3436f66797ba8253f0102d70d305e", kill_on_drop: false }` [INFO] [stdout] 1f6c4dec1423f975c4e3c6d8f1703848edc3436f66797ba8253f0102d70d305e