[INFO] fetching crate template 0.1.0... [INFO] checking template-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate template 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate template 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate template 0.1.0 [INFO] finished tweaking crates.io crate template 0.1.0 [INFO] tweaked toml for crates.io crate template 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 41 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.5.3 (latest: v1.1.3) [INFO] [stderr] Adding bitflags v0.4.0 (latest: v2.6.0) [INFO] [stderr] Adding bitflags v0.7.0 (latest: v2.6.0) [INFO] [stderr] Adding bytes v0.3.0 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding filetime v0.1.15 (latest: v0.2.25) [INFO] [stderr] Adding fsevent v0.2.17 (latest: v2.1.2) [INFO] [stderr] Adding fsevent-sys v0.1.6 (latest: v4.1.0) [INFO] [stderr] Adding handlebars v0.20.5 (latest: v6.0.0) [INFO] [stderr] Adding inotify v0.2.3 (latest: v0.11.0) [INFO] [stderr] Adding lazy_static v0.1.16 (latest: v1.5.0) [INFO] [stderr] Adding log v0.3.9 (latest: v0.4.22) [INFO] [stderr] Adding memchr v0.1.11 (latest: v2.7.4) [INFO] [stderr] Adding mio v0.5.1 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.1.5 (latest: v0.6.0) [INFO] [stderr] Adding nix v0.5.1 (latest: v0.29.0) [INFO] [stderr] Adding notify v2.6.3 (latest: v6.1.1) [INFO] [stderr] Adding pest v0.3.3 (latest: v2.7.11) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding regex v0.1.80 (latest: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.3.9 (latest: v0.8.4) [INFO] [stderr] Adding slab v0.1.3 (latest: v0.4.9) [INFO] [stderr] Adding thread-id v2.0.0 (latest: v4.2.2) [INFO] [stderr] Adding thread_local v0.2.7 (latest: v1.1.8) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding utf8-ranges v0.1.3 (latest: v1.0.5) [INFO] [stderr] Adding walkdir v0.1.8 (latest: v2.5.0) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b9847096aa2d94b56b057600ef9fd14ae74cd4f3758e04f4247954231058998b [INFO] running `Command { std: "docker" "start" "-a" "b9847096aa2d94b56b057600ef9fd14ae74cd4f3758e04f4247954231058998b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b9847096aa2d94b56b057600ef9fd14ae74cd4f3758e04f4247954231058998b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9847096aa2d94b56b057600ef9fd14ae74cd4f3758e04f4247954231058998b", kill_on_drop: false }` [INFO] [stdout] b9847096aa2d94b56b057600ef9fd14ae74cd4f3758e04f4247954231058998b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9410b1c92f95427ff911740b70f4ca78439eebc4aaea1c29fc9d673d4e5413cd [INFO] running `Command { std: "docker" "start" "-a" "9410b1c92f95427ff911740b70f4ca78439eebc4aaea1c29fc9d673d4e5413cd", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking bitflags v0.4.0 [INFO] [stderr] Checking utf8-ranges v0.1.3 [INFO] [stderr] Checking regex-syntax v0.3.9 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking bytes v0.3.0 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Compiling ws2_32-sys v0.2.1 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking slab v0.1.3 [INFO] [stderr] Checking inotify v0.2.3 [INFO] [stderr] Checking filetime v0.1.15 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking walkdir v0.1.8 [INFO] [stderr] Checking pest v0.3.3 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking lazy_static v0.1.16 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking notify v2.6.3 [INFO] [stderr] Checking handlebars v0.20.5 [INFO] [stderr] Checking template v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:60:32 [INFO] [stdout] | [INFO] [stdout] 60 | if dir.exists() && try!(fs::metadata(dir)).is_dir() { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:61:30 [INFO] [stdout] | [INFO] [stdout] 61 | for entry in try!(fs::read_dir(dir)) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:62:33 [INFO] [stdout] | [INFO] [stdout] 62 | let entry = try!(entry); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:64:25 [INFO] [stdout] | [INFO] [stdout] 64 | try!(_collect(&entry.path(), vec)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | if try!(fs::metadata(entry.path())).is_dir() { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | try!(watcher.watch(p)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:90:51 [INFO] [stdout] | [INFO] [stdout] 90 | let mut watcher: RecommendedWatcher = try!(Watcher::new(tx)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_left_matches`: superseded by `trim_start_matches` [INFO] [stdout] --> src/lib.rs:44:29 [INFO] [stdout] | [INFO] [stdout] 44 | let name = file.trim_left_matches(&self.template_dir).trim_right_matches(&self.extension); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 44 | let name = file.trim_start_matches(&self.template_dir).trim_right_matches(&self.extension); [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:60:32 [INFO] [stdout] | [INFO] [stdout] 60 | if dir.exists() && try!(fs::metadata(dir)).is_dir() { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/lib.rs:44:67 [INFO] [stdout] | [INFO] [stdout] 44 | let name = file.trim_left_matches(&self.template_dir).trim_right_matches(&self.extension); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 44 | let name = file.trim_left_matches(&self.template_dir).trim_end_matches(&self.extension); [INFO] [stdout] | ~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:61:30 [INFO] [stdout] | [INFO] [stdout] 61 | for entry in try!(fs::read_dir(dir)) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:62:33 [INFO] [stdout] | [INFO] [stdout] 62 | let entry = try!(entry); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:64:25 [INFO] [stdout] | [INFO] [stdout] 64 | try!(_collect(&entry.path(), vec)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | if try!(fs::metadata(entry.path())).is_dir() { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | try!(watcher.watch(p)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:90:51 [INFO] [stdout] | [INFO] [stdout] 90 | let mut watcher: RecommendedWatcher = try!(Watcher::new(tx)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:101:19 [INFO] [stdout] | [INFO] [stdout] 99 | let engine = self.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | thread::spawn(move || { [INFO] [stdout] 101 | match _watch(&engine) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_left_matches`: superseded by `trim_start_matches` [INFO] [stdout] --> src/lib.rs:44:29 [INFO] [stdout] | [INFO] [stdout] 44 | let name = file.trim_left_matches(&self.template_dir).trim_right_matches(&self.extension); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 44 | let name = file.trim_start_matches(&self.template_dir).trim_right_matches(&self.extension); [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/lib.rs:44:67 [INFO] [stdout] | [INFO] [stdout] 44 | let name = file.trim_left_matches(&self.template_dir).trim_right_matches(&self.extension); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 44 | let name = file.trim_left_matches(&self.template_dir).trim_end_matches(&self.extension); [INFO] [stdout] | ~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:101:19 [INFO] [stdout] | [INFO] [stdout] 99 | let engine = self.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | thread::spawn(move || { [INFO] [stdout] 101 | match _watch(&engine) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `template` (lib) due to 2 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `template` (lib test) due to 2 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9410b1c92f95427ff911740b70f4ca78439eebc4aaea1c29fc9d673d4e5413cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9410b1c92f95427ff911740b70f4ca78439eebc4aaea1c29fc9d673d4e5413cd", kill_on_drop: false }` [INFO] [stdout] 9410b1c92f95427ff911740b70f4ca78439eebc4aaea1c29fc9d673d4e5413cd