[INFO] fetching crate tekenen 0.0.5... [INFO] checking tekenen-0.0.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tekenen 0.0.5 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate tekenen 0.0.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tekenen 0.0.5 [INFO] finished tweaking crates.io crate tekenen 0.0.5 [INFO] tweaked toml for crates.io crate tekenen 0.0.5 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 73 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding image v0.24.9 (latest: v0.25.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding rust-embed v6.8.1 (latest: v8.5.0) [INFO] [stderr] Adding rust-embed-impl v6.8.1 (latest: v8.5.0) [INFO] [stderr] Adding rust-embed-utils v7.8.1 (latest: v8.5.0) [INFO] [stderr] Adding sdl2 v0.35.2 (latest: v0.37.0) [INFO] [stderr] Adding sdl2-sys v0.35.2 (latest: v0.37.0) [INFO] [stderr] Adding version-compare v0.1.1 (latest: v0.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ea4246d09d61cbaf045119038092c59ed0bfbf77d297e3c651553be64d93b72f [INFO] running `Command { std: "docker" "start" "-a" "ea4246d09d61cbaf045119038092c59ed0bfbf77d297e3c651553be64d93b72f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ea4246d09d61cbaf045119038092c59ed0bfbf77d297e3c651553be64d93b72f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ea4246d09d61cbaf045119038092c59ed0bfbf77d297e3c651553be64d93b72f", kill_on_drop: false }` [INFO] [stdout] ea4246d09d61cbaf045119038092c59ed0bfbf77d297e3c651553be64d93b72f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fc3d294fc73d4d6c28bfeb0ca061510cacc5877adda1dc5fab3aeee5234ca0fb [INFO] running `Command { std: "docker" "start" "-a" "fc3d294fc73d4d6c28bfeb0ca061510cacc5877adda1dc5fab3aeee5234ca0fb", kill_on_drop: false }` [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling sdl2 v0.35.2 [INFO] [stderr] Compiling sdl2-sys v0.35.2 [INFO] [stderr] Checking tekenen v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/platform/sdl.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::Tekenen` [INFO] [stdout] --> src/platform/sdl.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | use crate::Tekenen; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Tekenen` [INFO] [stdout] --> src/platform.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::{Tekenen, tekenen}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `c64` [INFO] [stdout] --> src/tekenen.rs:4:7 [INFO] [stdout] | [INFO] [stdout] 4 | #[cfg(feature = "c64")] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `image`, `preloader`, `rust-embed`, `sdl`, and `sdl2` [INFO] [stdout] = help: consider adding `c64` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `c64` [INFO] [stdout] --> src/tekenen.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 10 | #[cfg(not(feature = "c64"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `image`, `preloader`, `rust-embed`, `sdl`, and `sdl2` [INFO] [stdout] = help: consider adding `c64` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/platform/sdl.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::Tekenen` [INFO] [stdout] --> src/platform/sdl.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | use crate::Tekenen; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Tekenen` [INFO] [stdout] --> src/platform.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::{Tekenen, tekenen}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `c64` [INFO] [stdout] --> src/tekenen.rs:4:7 [INFO] [stdout] | [INFO] [stdout] 4 | #[cfg(feature = "c64")] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `image`, `preloader`, `rust-embed`, `sdl`, and `sdl2` [INFO] [stdout] = help: consider adding `c64` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `c64` [INFO] [stdout] --> src/tekenen.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 10 | #[cfg(not(feature = "c64"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `image`, `preloader`, `rust-embed`, `sdl`, and `sdl2` [INFO] [stdout] = help: consider adding `c64` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/time_manager.rs:42:27 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn add(action: TimeAction) { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | TIME_MANAGER.with(|manager| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 43 | | [INFO] [stdout] 44 | | let mut queue = manager.queue.borrow_mut(); [INFO] [stdout] 45 | | assert_eq!(queue.len(), 0, "Not implemented!"); [INFO] [stdout] ... | [INFO] [stdout] 48 | | queue.push_back(action) [INFO] [stdout] 49 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:67:19 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn new(draw: impl FnMut(&ViewBox, &mut Tekenen) + 'c) -> Container<'c> { [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | draw: Box::new(draw), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tekenen` (lib test) due to 3 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/time_manager.rs:42:27 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn add(action: TimeAction) { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | TIME_MANAGER.with(|manager| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 43 | | [INFO] [stdout] 44 | | let mut queue = manager.queue.borrow_mut(); [INFO] [stdout] 45 | | assert_eq!(queue.len(), 0, "Not implemented!"); [INFO] [stdout] ... | [INFO] [stdout] 48 | | queue.push_back(action) [INFO] [stdout] 49 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:67:19 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn new(draw: impl FnMut(&ViewBox, &mut Tekenen) + 'c) -> Container<'c> { [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | draw: Box::new(draw), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tekenen` (lib) due to 3 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "fc3d294fc73d4d6c28bfeb0ca061510cacc5877adda1dc5fab3aeee5234ca0fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc3d294fc73d4d6c28bfeb0ca061510cacc5877adda1dc5fab3aeee5234ca0fb", kill_on_drop: false }` [INFO] [stdout] fc3d294fc73d4d6c28bfeb0ca061510cacc5877adda1dc5fab3aeee5234ca0fb