[INFO] fetching crate tdiag-connect 0.2.0... [INFO] checking tdiag-connect-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tdiag-connect 0.2.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate tdiag-connect 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tdiag-connect 0.2.0 [INFO] finished tweaking crates.io crate tdiag-connect 0.2.0 [INFO] tweaked toml for crates.io crate tdiag-connect 0.2.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 26 packages to latest compatible versions [INFO] [stderr] Adding abomonation_derive v0.3.0 (latest: v0.5.0) [INFO] [stderr] Adding abomonation_derive v0.4.0 (latest: v0.5.0) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quote v0.3.15 (latest: v1.0.37) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding syn v0.11.11 (latest: v2.0.77) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.6.1 (latest: v0.13.1) [INFO] [stderr] Adding synstructure v0.10.2 (latest: v0.13.1) [INFO] [stderr] Adding timely v0.10.0 (latest: v0.12.0) [INFO] [stderr] Adding timely_bytes v0.10.0 (latest: v0.12.0) [INFO] [stderr] Adding timely_communication v0.10.0 (latest: v0.12.0) [INFO] [stderr] Adding timely_logging v0.10.0 (latest: v0.12.0) [INFO] [stderr] Adding unicode-xid v0.0.4 (latest: v0.2.5) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 03371328964e09549bd8d52010989c6fe060cf527d2f1e56cbc53ee764595a24 [INFO] running `Command { std: "docker" "start" "-a" "03371328964e09549bd8d52010989c6fe060cf527d2f1e56cbc53ee764595a24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "03371328964e09549bd8d52010989c6fe060cf527d2f1e56cbc53ee764595a24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "03371328964e09549bd8d52010989c6fe060cf527d2f1e56cbc53ee764595a24", kill_on_drop: false }` [INFO] [stdout] 03371328964e09549bd8d52010989c6fe060cf527d2f1e56cbc53ee764595a24 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8bcbb9c095ba7b68f2ea1bc00085676fc9fb1f098eb1da2dada9505ce418ea6d [INFO] running `Command { std: "docker" "start" "-a" "8bcbb9c095ba7b68f2ea1bc00085676fc9fb1f098eb1da2dada9505ce418ea6d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking timely_logging v0.10.0 [INFO] [stderr] Checking timely_bytes v0.10.0 [INFO] [stderr] Checking abomonation v0.7.3 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling synstructure v0.6.1 [INFO] [stderr] Compiling abomonation_derive v0.3.0 [INFO] [stderr] Compiling synstructure v0.10.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling abomonation_derive v0.4.0 [INFO] [stderr] Checking timely_communication v0.10.0 [INFO] [stderr] Checking timely v0.10.0 [INFO] [stderr] Checking tdiag-connect v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receive/connect.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 21 | let listener = TcpListener::bind(socket_addr)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok((0..source_peers).map(|_| { [INFO] [stdout] | ________^ [INFO] [stdout] 23 | | let socket = listener.incoming().next().expect("Socket unexpectedly unavailable"); [INFO] [stdout] 24 | | if let Ok(ref s) = &socket { [INFO] [stdout] 25 | | s.set_nonblocking(true)?; [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | socket.map(Some) [INFO] [stdout] 28 | | }).collect::, _>>()?) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receive/connect.rs:68:31 [INFO] [stdout] | [INFO] [stdout] 68 | .map(|(_, s)| s.take().expect("socket missing, check the docs for make_replayers")) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receive/connect.rs:69:54 [INFO] [stdout] | [INFO] [stdout] 69 | .map(|r| EventReader::::new(TcpStreamOrFile::Tcp(r))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receive/connect.rs:79:43 [INFO] [stdout] | [INFO] [stdout] 79 | .map(|f| EventReader::new(TcpStreamOrFile::File(f))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receive/replaywithshutdown.rs:98:77 [INFO] [stdout] | [INFO] [stdout] 98 | let elements = antichain.frontier().iter().map(|t| (t.clone(), -1)).collect::>(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receive/connect.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 21 | let listener = TcpListener::bind(socket_addr)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok((0..source_peers).map(|_| { [INFO] [stdout] | ________^ [INFO] [stdout] 23 | | let socket = listener.incoming().next().expect("Socket unexpectedly unavailable"); [INFO] [stdout] 24 | | if let Ok(ref s) = &socket { [INFO] [stdout] 25 | | s.set_nonblocking(true)?; [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | socket.map(Some) [INFO] [stdout] 28 | | }).collect::, _>>()?) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receive/connect.rs:68:31 [INFO] [stdout] | [INFO] [stdout] 68 | .map(|(_, s)| s.take().expect("socket missing, check the docs for make_replayers")) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receive/connect.rs:69:54 [INFO] [stdout] | [INFO] [stdout] 69 | .map(|r| EventReader::::new(TcpStreamOrFile::Tcp(r))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receive/connect.rs:79:43 [INFO] [stdout] | [INFO] [stdout] 79 | .map(|f| EventReader::new(TcpStreamOrFile::File(f))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tdiag-connect` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receive/replaywithshutdown.rs:98:77 [INFO] [stdout] | [INFO] [stdout] 98 | let elements = antichain.frontier().iter().map(|t| (t.clone(), -1)).collect::>(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tdiag-connect` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "8bcbb9c095ba7b68f2ea1bc00085676fc9fb1f098eb1da2dada9505ce418ea6d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8bcbb9c095ba7b68f2ea1bc00085676fc9fb1f098eb1da2dada9505ce418ea6d", kill_on_drop: false }` [INFO] [stdout] 8bcbb9c095ba7b68f2ea1bc00085676fc9fb1f098eb1da2dada9505ce418ea6d