[INFO] fetching crate tdiag 0.2.0... [INFO] checking tdiag-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tdiag 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate tdiag 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tdiag 0.2.0 [INFO] finished tweaking crates.io crate tdiag 0.2.0 [INFO] tweaked toml for crates.io crate tdiag 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 42 packages to latest compatible versions [INFO] [stderr] Adding abomonation_derive v0.3.0 (latest: v0.5.0) [INFO] [stderr] Adding abomonation_derive v0.4.0 (latest: v0.5.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding differential-dataflow v0.10.0 (latest: v0.12.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quote v0.3.15 (latest: v1.0.37) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v0.11.11 (latest: v2.0.77) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.6.1 (latest: v0.13.1) [INFO] [stderr] Adding synstructure v0.10.2 (latest: v0.13.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding timely v0.10.0 (latest: v0.12.0) [INFO] [stderr] Adding timely_bytes v0.10.0 (latest: v0.12.0) [INFO] [stderr] Adding timely_communication v0.10.0 (latest: v0.12.0) [INFO] [stderr] Adding timely_logging v0.10.0 (latest: v0.12.0) [INFO] [stderr] Adding unicode-xid v0.0.4 (latest: v0.2.5) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 89ab7960bc1d9fb78681896e3cf5b0a945da5f6239c1df201fcfd3208eb56de4 [INFO] running `Command { std: "docker" "start" "-a" "89ab7960bc1d9fb78681896e3cf5b0a945da5f6239c1df201fcfd3208eb56de4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "89ab7960bc1d9fb78681896e3cf5b0a945da5f6239c1df201fcfd3208eb56de4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "89ab7960bc1d9fb78681896e3cf5b0a945da5f6239c1df201fcfd3208eb56de4", kill_on_drop: false }` [INFO] [stdout] 89ab7960bc1d9fb78681896e3cf5b0a945da5f6239c1df201fcfd3208eb56de4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f5ae19963a93a4980c0bcc25e591c03d24e9cb2fee553f00ad76e34cf81a1a35 [INFO] running `Command { std: "docker" "start" "-a" "f5ae19963a93a4980c0bcc25e591c03d24e9cb2fee553f00ad76e34cf81a1a35", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking timely_bytes v0.10.0 [INFO] [stderr] Checking abomonation v0.7.3 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Checking timely_logging v0.10.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking timely_sort v0.1.6 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling synstructure v0.6.1 [INFO] [stderr] Compiling abomonation_derive v0.3.0 [INFO] [stderr] Compiling synstructure v0.10.2 [INFO] [stderr] Compiling abomonation_derive v0.4.0 [INFO] [stderr] Checking timely_communication v0.10.0 [INFO] [stderr] Checking timely v0.10.0 [INFO] [stderr] Checking differential-dataflow v0.10.0 [INFO] [stderr] Checking tdiag-connect v0.2.0 [INFO] [stderr] Checking tdiag v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/graph.rs:55:25 [INFO] [stdout] | [INFO] [stdout] 33 | let sockets = Arc::new(Mutex::new(sockets)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let operators_send = Arc::new(Mutex::new(operators_send)); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let channels_send = Arc::new(Mutex::new(channels_send)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let is_running_w = is_running.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let operators_send: std::sync::mpsc::Sender<_> = operators_send.lock().expect("cannot lock operators_send").clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let channels_send: std::sync::mpsc::Sender<_> = channels_send.lock().expect("cannot lock channels_send").clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | [INFO] [stdout] 48 | let sockets = sockets.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let replayer = tdiag_connect::receive::make_readers::( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | worker.dataflow(|scope| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 56 | | let stream = replayer.replay_with_shutdown_into(scope, is_running_w.clone()) [INFO] [stdout] 57 | | .filter(|(_, worker, _)| *worker == 0); [INFO] [stdout] ... | [INFO] [stdout] 190 | | } [INFO] [stdout] 191 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tdiag` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/graph.rs:55:25 [INFO] [stdout] | [INFO] [stdout] 33 | let sockets = Arc::new(Mutex::new(sockets)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let operators_send = Arc::new(Mutex::new(operators_send)); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let channels_send = Arc::new(Mutex::new(channels_send)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let is_running_w = is_running.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let operators_send: std::sync::mpsc::Sender<_> = operators_send.lock().expect("cannot lock operators_send").clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let channels_send: std::sync::mpsc::Sender<_> = channels_send.lock().expect("cannot lock channels_send").clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | [INFO] [stdout] 48 | let sockets = sockets.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let replayer = tdiag_connect::receive::make_readers::( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | worker.dataflow(|scope| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 56 | | let stream = replayer.replay_with_shutdown_into(scope, is_running_w.clone()) [INFO] [stdout] 57 | | .filter(|(_, worker, _)| *worker == 0); [INFO] [stdout] ... | [INFO] [stdout] 190 | | } [INFO] [stdout] 191 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tdiag` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "f5ae19963a93a4980c0bcc25e591c03d24e9cb2fee553f00ad76e34cf81a1a35", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5ae19963a93a4980c0bcc25e591c03d24e9cb2fee553f00ad76e34cf81a1a35", kill_on_drop: false }` [INFO] [stdout] f5ae19963a93a4980c0bcc25e591c03d24e9cb2fee553f00ad76e34cf81a1a35