[INFO] fetching crate tdf_utils 0.2.4... [INFO] checking tdf_utils-0.2.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tdf_utils 0.2.4 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate tdf_utils 0.2.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tdf_utils 0.2.4 [INFO] finished tweaking crates.io crate tdf_utils 0.2.4 [INFO] tweaked toml for crates.io crate tdf_utils 0.2.4 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 12 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 59f2a51f31d65dde93afe687d64d5f11f593de9c3bb656323b775a7066468534 [INFO] running `Command { std: "docker" "start" "-a" "59f2a51f31d65dde93afe687d64d5f11f593de9c3bb656323b775a7066468534", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "59f2a51f31d65dde93afe687d64d5f11f593de9c3bb656323b775a7066468534", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59f2a51f31d65dde93afe687d64d5f11f593de9c3bb656323b775a7066468534", kill_on_drop: false }` [INFO] [stdout] 59f2a51f31d65dde93afe687d64d5f11f593de9c3bb656323b775a7066468534 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1b2fe1c91e74352197ce8c2bfc29aad652fe60fc0737d56d15cb18ffe65bd975 [INFO] running `Command { std: "docker" "start" "-a" "1b2fe1c91e74352197ce8c2bfc29aad652fe60fc0737d56d15cb18ffe65bd975", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking tdf_utils v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `BinaryIndexedTree` is never constructed [INFO] [stdout] --> src/bit.rs:2:8 [INFO] [stdout] | [INFO] [stdout] 2 | struct BinaryIndexedTree { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BinaryIndexedTree` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `from`, `update`, `sum_to`, and `sum_of_range` are never used [INFO] [stdout] --> src/bit.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 7 | / impl BinaryIndexedTree [INFO] [stdout] 8 | | where [INFO] [stdout] 9 | | T: Default + Clone + std::ops::AddAssign + std::ops::Sub, [INFO] [stdout] | |_________________________________________________________________________- associated items in this implementation [INFO] [stdout] 10 | { [INFO] [stdout] 11 | pub fn new(n: usize) -> BinaryIndexedTree { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 18 | fn from(v: Vec) -> BinaryIndexedTree { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | pub fn update(&mut self, idx: usize, delta: T) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | pub fn sum_to(&mut self, idx: usize) -> T { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | pub fn sum_of_range(&mut self, idx: usize, end: usize) -> T { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:64:23 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn new(val: Item) -> TreeNode { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | children: Vec::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 92 | self.head.take().map(|head| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | / Rc::try_unwrap(head) [INFO] [stdout] 101 | | .ok() [INFO] [stdout] 102 | | .unwrap() // .expect("fatal error") [INFO] [stdout] 103 | | .into_inner() [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 128 | self.tail.take().map(|tail| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | / Rc::try_unwrap(tail) [INFO] [stdout] 137 | | .ok() [INFO] [stdout] 138 | | .unwrap() // .expect("fatal error") [INFO] [stdout] 139 | | .into_inner() [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tdf_utils` (lib) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/bit.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 7 | / impl BinaryIndexedTree [INFO] [stdout] 8 | | where [INFO] [stdout] 9 | | T: Default + Clone + std::ops::AddAssign + std::ops::Sub, [INFO] [stdout] | |_________________________________________________________________________- associated function in this implementation [INFO] [stdout] 10 | { [INFO] [stdout] 11 | pub fn new(n: usize) -> BinaryIndexedTree { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:64:23 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn new(val: Item) -> TreeNode { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | children: Vec::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 92 | self.head.take().map(|head| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | / Rc::try_unwrap(head) [INFO] [stdout] 101 | | .ok() [INFO] [stdout] 102 | | .unwrap() // .expect("fatal error") [INFO] [stdout] 103 | | .into_inner() [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 128 | self.tail.take().map(|tail| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | / Rc::try_unwrap(tail) [INFO] [stdout] 137 | | .ok() [INFO] [stdout] 138 | | .unwrap() // .expect("fatal error") [INFO] [stdout] 139 | | .into_inner() [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tdf_utils` (lib test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1b2fe1c91e74352197ce8c2bfc29aad652fe60fc0737d56d15cb18ffe65bd975", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b2fe1c91e74352197ce8c2bfc29aad652fe60fc0737d56d15cb18ffe65bd975", kill_on_drop: false }` [INFO] [stdout] 1b2fe1c91e74352197ce8c2bfc29aad652fe60fc0737d56d15cb18ffe65bd975