[INFO] fetching crate tcp-test 0.1.0... [INFO] checking tcp-test-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tcp-test 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate tcp-test 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tcp-test 0.1.0 [INFO] finished tweaking crates.io crate tcp-test 0.1.0 [INFO] tweaked toml for crates.io crate tcp-test 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0ea62de7bea91d4dc321f5eadcbdb68dff649c3e57e2c0159ae9198e0494a86b [INFO] running `Command { std: "docker" "start" "-a" "0ea62de7bea91d4dc321f5eadcbdb68dff649c3e57e2c0159ae9198e0494a86b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0ea62de7bea91d4dc321f5eadcbdb68dff649c3e57e2c0159ae9198e0494a86b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ea62de7bea91d4dc321f5eadcbdb68dff649c3e57e2c0159ae9198e0494a86b", kill_on_drop: false }` [INFO] [stdout] 0ea62de7bea91d4dc321f5eadcbdb68dff649c3e57e2c0159ae9198e0494a86b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dd6512bf3eabeb3e23ec743997bb28ebcfeb2e9e583889cb92a0478ac5648000 [INFO] running `Command { std: "docker" "start" "-a" "dd6512bf3eabeb3e23ec743997bb28ebcfeb2e9e583889cb92a0478ac5648000", kill_on_drop: false }` [INFO] [stderr] Checking tcp-test v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 181 | pub fn channel_on(address: impl ToSocketAddrs) -> (TcpStream, TcpStream) { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | let lock = unsafe { CHANNEL.clone().unwrap() }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | [INFO] [stdout] 186 | let guard = lock [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | / guard [INFO] [stdout] 196 | | .1 [INFO] [stdout] 197 | | .recv() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 203 | fn resolve(address: impl ToSocketAddrs) -> SocketAddr { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | / address [INFO] [stdout] 205 | | .to_socket_addrs() [INFO] [stdout] 206 | | .expect(concat!( [INFO] [stdout] 207 | | "::to_socket_addrs() at resolve(), line ", [INFO] [stdout] 208 | | line!() [INFO] [stdout] 209 | | )) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tcp-test` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 181 | pub fn channel_on(address: impl ToSocketAddrs) -> (TcpStream, TcpStream) { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | let lock = unsafe { CHANNEL.clone().unwrap() }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | [INFO] [stdout] 186 | let guard = lock [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | / guard [INFO] [stdout] 196 | | .1 [INFO] [stdout] 197 | | .recv() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 203 | fn resolve(address: impl ToSocketAddrs) -> SocketAddr { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | / address [INFO] [stdout] 205 | | .to_socket_addrs() [INFO] [stdout] 206 | | .expect(concat!( [INFO] [stdout] 207 | | "::to_socket_addrs() at resolve(), line ", [INFO] [stdout] 208 | | line!() [INFO] [stdout] 209 | | )) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tcp-test` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "dd6512bf3eabeb3e23ec743997bb28ebcfeb2e9e583889cb92a0478ac5648000", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd6512bf3eabeb3e23ec743997bb28ebcfeb2e9e583889cb92a0478ac5648000", kill_on_drop: false }` [INFO] [stdout] dd6512bf3eabeb3e23ec743997bb28ebcfeb2e9e583889cb92a0478ac5648000