[INFO] fetching crate tcp-stream 0.29.2... [INFO] checking tcp-stream-0.29.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tcp-stream 0.29.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate tcp-stream 0.29.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tcp-stream 0.29.2 [INFO] finished tweaking crates.io crate tcp-stream 0.29.2 [INFO] tweaked toml for crates.io crate tcp-stream 0.29.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 152 packages to latest compatible versions [INFO] [stderr] Adding bindgen v0.69.4 (latest: v0.70.1) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding which v4.4.2 (latest: v6.0.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 43c6f4313687faaf6c50a9fdafebded9d0a21ddf66ffd9ce416fef3226809c45 [INFO] running `Command { std: "docker" "start" "-a" "43c6f4313687faaf6c50a9fdafebded9d0a21ddf66ffd9ce416fef3226809c45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "43c6f4313687faaf6c50a9fdafebded9d0a21ddf66ffd9ce416fef3226809c45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43c6f4313687faaf6c50a9fdafebded9d0a21ddf66ffd9ce416fef3226809c45", kill_on_drop: false }` [INFO] [stdout] 43c6f4313687faaf6c50a9fdafebded9d0a21ddf66ffd9ce416fef3226809c45 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 789089af02f20c2cd27d65568d871f9d62af8793fa025b7770a702e60e857a4e [INFO] running `Command { std: "docker" "start" "-a" "789089af02f20c2cd27d65568d871f9d62af8793fa025b7770a702e60e857a4e", kill_on_drop: false }` [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking flagset v0.4.6 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling aws-lc-rs v1.8.1 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling cmake v0.1.51 [INFO] [stderr] Compiling oid-registry v0.7.1 [INFO] [stderr] Checking mirai-annotations v1.12.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Compiling aws-lc-sys v0.20.1 [INFO] [stderr] Checking rustls-native-certs v0.8.0 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking rc2 v0.8.1 [INFO] [stderr] Checking des v0.8.1 [INFO] [stderr] Checking scrypt v0.11.0 [INFO] [stderr] Checking rusticata-macros v4.1.0 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling der_derive v0.7.3 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling asn1-rs-derive v0.5.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling asn1-rs-impl v0.2.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking asn1-rs v0.6.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking x509-cert v0.2.5 [INFO] [stderr] Checking pkcs5 v0.7.1 [INFO] [stderr] Checking der-parser v9.0.0 [INFO] [stderr] Checking cms v0.2.3 [INFO] [stderr] Checking x509-parser v0.16.0 [INFO] [stderr] Checking pkcs12 v0.1.0 [INFO] [stderr] Checking p12-keystore v0.1.3 [INFO] [stderr] Checking rustls-webpki v0.102.7 [INFO] [stderr] Checking rustls-connector v0.21.4 [INFO] [stderr] Checking tcp-stream v0.29.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 189 | pub fn connect(addr: A) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | connect_std(addr, None).and_then(Self::try_from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:195:9 [INFO] [stdout] | [INFO] [stdout] 194 | pub fn connect_timeout(addr: A, timeout: Duration) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | connect_std(addr, Some(timeout)).and_then(Self::try_from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:274:12 [INFO] [stdout] | [INFO] [stdout] 270 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | Ok(connector.connect(domain, self.into_plain()?)?.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:316:9 [INFO] [stdout] | [INFO] [stdout] 297 | addr: A, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | let mut addrs = addr.to_socket_addrs()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | let mut err = None; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | Err(err.unwrap_or_else(|| { [INFO] [stdout] | _________^ [INFO] [stdout] 317 | | io::Error::new(io::ErrorKind::AddrNotAvailable, "couldn't resolve host") [INFO] [stdout] 318 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:444:27 [INFO] [stdout] | [INFO] [stdout] 443 | fn from(s: RustlsStream) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 444 | TcpStream::Rustls(Box::new(s)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:604:12 [INFO] [stdout] | [INFO] [stdout] 603 | pub fn handshake(self) -> HandshakeResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 604 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 605 | | MidHandshakeTlsStream::Plain(mut mid) => { [INFO] [stdout] 606 | | if !mid.try_connect()? { [INFO] [stdout] 607 | | return Err(HandshakeError::WouldBlock(mid.into())); [INFO] [stdout] ... | [INFO] [stdout] 631 | | } [INFO] [stdout] 632 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tcp-stream` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 189 | pub fn connect(addr: A) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | connect_std(addr, None).and_then(Self::try_from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:195:9 [INFO] [stdout] | [INFO] [stdout] 194 | pub fn connect_timeout(addr: A, timeout: Duration) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | connect_std(addr, Some(timeout)).and_then(Self::try_from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:274:12 [INFO] [stdout] | [INFO] [stdout] 270 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | Ok(connector.connect(domain, self.into_plain()?)?.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:316:9 [INFO] [stdout] | [INFO] [stdout] 297 | addr: A, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | let mut addrs = addr.to_socket_addrs()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | let mut err = None; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | Err(err.unwrap_or_else(|| { [INFO] [stdout] | _________^ [INFO] [stdout] 317 | | io::Error::new(io::ErrorKind::AddrNotAvailable, "couldn't resolve host") [INFO] [stdout] 318 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:444:27 [INFO] [stdout] | [INFO] [stdout] 443 | fn from(s: RustlsStream) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 444 | TcpStream::Rustls(Box::new(s)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:604:12 [INFO] [stdout] | [INFO] [stdout] 603 | pub fn handshake(self) -> HandshakeResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 604 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 605 | | MidHandshakeTlsStream::Plain(mut mid) => { [INFO] [stdout] 606 | | if !mid.try_connect()? { [INFO] [stdout] 607 | | return Err(HandshakeError::WouldBlock(mid.into())); [INFO] [stdout] ... | [INFO] [stdout] 631 | | } [INFO] [stdout] 632 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tcp-stream` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "789089af02f20c2cd27d65568d871f9d62af8793fa025b7770a702e60e857a4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "789089af02f20c2cd27d65568d871f9d62af8793fa025b7770a702e60e857a4e", kill_on_drop: false }` [INFO] [stdout] 789089af02f20c2cd27d65568d871f9d62af8793fa025b7770a702e60e857a4e