[INFO] fetching crate tcp-clone 0.99.4... [INFO] checking tcp-clone-0.99.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tcp-clone 0.99.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate tcp-clone 0.99.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tcp-clone 0.99.4 [INFO] finished tweaking crates.io crate tcp-clone 0.99.4 [INFO] tweaked toml for crates.io crate tcp-clone 0.99.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate tcp-clone 0.99.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5d8c0488f25726788e3b742ebb75a46c357ab6b123a6cf731abf4090d5b26126 [INFO] running `Command { std: "docker" "start" "-a" "5d8c0488f25726788e3b742ebb75a46c357ab6b123a6cf731abf4090d5b26126", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5d8c0488f25726788e3b742ebb75a46c357ab6b123a6cf731abf4090d5b26126", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5d8c0488f25726788e3b742ebb75a46c357ab6b123a6cf731abf4090d5b26126", kill_on_drop: false }` [INFO] [stdout] 5d8c0488f25726788e3b742ebb75a46c357ab6b123a6cf731abf4090d5b26126 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b0a66d316902fbaae31f387bfce5917271a85cf0e9962b8cb64aacc1069879b9 [INFO] running `Command { std: "docker" "start" "-a" "b0a66d316902fbaae31f387bfce5917271a85cf0e9962b8cb64aacc1069879b9", kill_on_drop: false }` [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking futures-core-preview v0.3.0-alpha.19 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Checking pin-utils v0.1.0-alpha.4 [INFO] [stderr] Checking futures-sink-preview v0.3.0-alpha.19 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling syn v1.0.8 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling serde v1.0.102 [INFO] [stderr] Checking lock_api v0.3.1 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking futures-core v0.3.1 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking pin-project-lite v0.1.1 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking futures-channel-preview v0.3.0-alpha.19 [INFO] [stderr] Checking futures-util-preview v0.3.0-alpha.19 [INFO] [stderr] Checking async-macros v2.0.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Checking once_cell v1.2.0 [INFO] [stderr] Checking async-task v1.0.0 [INFO] [stderr] Checking futures-timer v2.0.2 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking kv-log-macro v1.0.4 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking futures-io v0.3.1 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.11.1 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking crossbeam-channel v0.4.0 [INFO] [stderr] Checking mio v0.6.20 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking broadcaster v0.2.6 [INFO] [stderr] Checking async-std v1.1.0 [INFO] [stderr] Checking toml v0.5.5 [INFO] [stderr] Compiling serde_derive v1.0.102 [INFO] [stderr] Checking tcp-clone v0.99.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:104:10 [INFO] [stdout] | [INFO] [stdout] 74 | let tcp_clone_cfg = Arc::new(tcp_clone_cfg); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | [INFO] [stdout] 76 | let cfg = tcp_clone_cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | let client_tx_observers = task::spawn(async move { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let cfg = tcp_clone_cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let client_rx_observers = task::spawn(async move { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let cfg = tcp_clone_cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let listen_addr = task::spawn(async move { resolve_addr(&cfg.server.listen_addr).await }); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | [INFO] [stdout] 95 | let cfg = tcp_clone_cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let target_addr = task::spawn(async move { resolve_addr(&cfg.target.addr).await }); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:81:79 [INFO] [stdout] | [INFO] [stdout] 76 | let cfg = tcp_clone_cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | resolve_observer_addrs(&cfg.client_tx_observer.as_ref().unwrap()).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:89:79 [INFO] [stdout] | [INFO] [stdout] 84 | let cfg = tcp_clone_cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | resolve_observer_addrs(&cfg.client_rx_observer.as_ref().unwrap()).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:93:90 [INFO] [stdout] | [INFO] [stdout] 92 | let cfg = tcp_clone_cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let listen_addr = task::spawn(async move { resolve_addr(&cfg.server.listen_addr).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:96:83 [INFO] [stdout] | [INFO] [stdout] 95 | let cfg = tcp_clone_cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let target_addr = task::spawn(async move { resolve_addr(&cfg.target.addr).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tcp-clone` (bin "tcp-clone" test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:104:10 [INFO] [stdout] | [INFO] [stdout] 74 | let tcp_clone_cfg = Arc::new(tcp_clone_cfg); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | [INFO] [stdout] 76 | let cfg = tcp_clone_cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | let client_tx_observers = task::spawn(async move { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let cfg = tcp_clone_cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let client_rx_observers = task::spawn(async move { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let cfg = tcp_clone_cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let listen_addr = task::spawn(async move { resolve_addr(&cfg.server.listen_addr).await }); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | [INFO] [stdout] 95 | let cfg = tcp_clone_cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let target_addr = task::spawn(async move { resolve_addr(&cfg.target.addr).await }); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:81:79 [INFO] [stdout] | [INFO] [stdout] 76 | let cfg = tcp_clone_cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | resolve_observer_addrs(&cfg.client_tx_observer.as_ref().unwrap()).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:89:79 [INFO] [stdout] | [INFO] [stdout] 84 | let cfg = tcp_clone_cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | resolve_observer_addrs(&cfg.client_rx_observer.as_ref().unwrap()).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:93:90 [INFO] [stdout] | [INFO] [stdout] 92 | let cfg = tcp_clone_cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let listen_addr = task::spawn(async move { resolve_addr(&cfg.server.listen_addr).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:96:83 [INFO] [stdout] | [INFO] [stdout] 95 | let cfg = tcp_clone_cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let target_addr = task::spawn(async move { resolve_addr(&cfg.target.addr).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tcp-clone` (bin "tcp-clone") due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "b0a66d316902fbaae31f387bfce5917271a85cf0e9962b8cb64aacc1069879b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0a66d316902fbaae31f387bfce5917271a85cf0e9962b8cb64aacc1069879b9", kill_on_drop: false }` [INFO] [stdout] b0a66d316902fbaae31f387bfce5917271a85cf0e9962b8cb64aacc1069879b9