[INFO] fetching crate tcp-channel 0.3.2... [INFO] checking tcp-channel-0.3.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tcp-channel 0.3.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate tcp-channel 0.3.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tcp-channel 0.3.2 [INFO] finished tweaking crates.io crate tcp-channel 0.3.2 [INFO] tweaked toml for crates.io crate tcp-channel 0.3.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 30 packages to latest compatible versions [INFO] [stderr] Adding autocfg v0.1.8 (latest: v1.3.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rand v0.6.5 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (latest: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 56d2818be15c91c5f02f8886777e34d6881a258db82a035b148759357ad73afd [INFO] running `Command { std: "docker" "start" "-a" "56d2818be15c91c5f02f8886777e34d6881a258db82a035b148759357ad73afd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "56d2818be15c91c5f02f8886777e34d6881a258db82a035b148759357ad73afd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "56d2818be15c91c5f02f8886777e34d6881a258db82a035b148759357ad73afd", kill_on_drop: false }` [INFO] [stdout] 56d2818be15c91c5f02f8886777e34d6881a258db82a035b148759357ad73afd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 68df30f4c346ada6f6938b9bbd85be0098d8fa3c27986b9e7bee888953602c52 [INFO] running `Command { std: "docker" "start" "-a" "68df30f4c346ada6f6938b9bbd85be0098d8fa3c27986b9e7bee888953602c52", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking tcp-channel v0.3.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated struct `bincode::Config`: please use the `DefaultOptions`/`Options` system instead [INFO] [stdout] --> src/endian.rs:3:14 [INFO] [stdout] | [INFO] [stdout] 3 | use bincode::Config; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `bincode::Config`: please use the `DefaultOptions`/`Options` system instead [INFO] [stdout] --> src/endian.rs:6:20 [INFO] [stdout] | [INFO] [stdout] 6 | fn config() -> Config; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `bincode::Config`: please use the `DefaultOptions`/`Options` system instead [INFO] [stdout] --> src/endian.rs:9:20 [INFO] [stdout] | [INFO] [stdout] 9 | fn config() -> Config { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `bincode::config`: please use `options()` instead [INFO] [stdout] --> src/endian.rs:10:35 [INFO] [stdout] | [INFO] [stdout] 10 | let mut config = bincode::config(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `bincode::Config`: please use the `DefaultOptions`/`Options` system instead [INFO] [stdout] --> src/endian.rs:16:20 [INFO] [stdout] | [INFO] [stdout] 16 | fn config() -> Config { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `bincode::config`: please use `options()` instead [INFO] [stdout] --> src/endian.rs:17:35 [INFO] [stdout] | [INFO] [stdout] 17 | let mut config = bincode::config(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `bincode::Config`: please use the `DefaultOptions`/`Options` system instead [INFO] [stdout] --> src/receiver.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | use bincode::Config; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `bincode::Config`: please use the `DefaultOptions`/`Options` system instead [INFO] [stdout] --> src/receiver.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | config: Config, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `bincode::Config`: please use the `DefaultOptions`/`Options` system instead [INFO] [stdout] --> src/sender.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | use bincode::Config; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `bincode::Config`: please use the `DefaultOptions`/`Options` system instead [INFO] [stdout] --> src/sender.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | config: Config, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receiver.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn listen_once(self, address: A) -> std::io::Result>> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let listener = TcpListener::bind(address)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | [INFO] [stdout] 104 | let (stream, _) = listener.accept()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | [INFO] [stdout] 106 | Ok(Receiver { [INFO] [stdout] | ____________^ [INFO] [stdout] 107 | | config: E::config(), [INFO] [stdout] 108 | | _marker: PhantomData, [INFO] [stdout] 109 | | reader: BufReader::new(stream), [INFO] [stdout] ... | [INFO] [stdout] 113 | | bytes_to_read: 0, [INFO] [stdout] 114 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receiver.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn listen_once(self, address: A) -> std::io::Result> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | let listener = TcpListener::bind(address)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | [INFO] [stdout] 122 | let (stream, _) = listener.accept()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | [INFO] [stdout] 124 | Ok(Receiver { [INFO] [stdout] | ____________^ [INFO] [stdout] 125 | | config: E::config(), [INFO] [stdout] 126 | | _marker: PhantomData, [INFO] [stdout] 127 | | reader: stream, [INFO] [stdout] ... | [INFO] [stdout] 131 | | bytes_to_read: 0, [INFO] [stdout] 132 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sender.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn connect(self, address: A) -> std::io::Result>> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let stream = TcpStream::connect(address)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | [INFO] [stdout] 78 | Ok(Sender { [INFO] [stdout] | ____________^ [INFO] [stdout] 79 | | writer: BufWriter::new(stream), [INFO] [stdout] 80 | | _marker: PhantomData, [INFO] [stdout] 81 | | config: E::config(), [INFO] [stdout] 82 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sender.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn connect(self, address: A) -> std::io::Result> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let stream = TcpStream::connect(address)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Ok(Sender { [INFO] [stdout] | ____________^ [INFO] [stdout] 92 | | writer: stream, [INFO] [stdout] 93 | | _marker: PhantomData, [INFO] [stdout] 94 | | config: E::config(), [INFO] [stdout] 95 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tcp-channel` (lib) due to 5 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "68df30f4c346ada6f6938b9bbd85be0098d8fa3c27986b9e7bee888953602c52", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "68df30f4c346ada6f6938b9bbd85be0098d8fa3c27986b9e7bee888953602c52", kill_on_drop: false }` [INFO] [stdout] 68df30f4c346ada6f6938b9bbd85be0098d8fa3c27986b9e7bee888953602c52