[INFO] fetching crate tchannel_rs 0.0.2... [INFO] checking tchannel_rs-0.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tchannel_rs 0.0.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate tchannel_rs 0.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tchannel_rs 0.0.2 [INFO] finished tweaking crates.io crate tchannel_rs 0.0.2 [INFO] tweaked toml for crates.io crate tchannel_rs 0.0.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate tchannel_rs 0.0.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c1a538ab9b28326574d730f38efea44b58452ab34065cc2e930490f6ffb0bd63 [INFO] running `Command { std: "docker" "start" "-a" "c1a538ab9b28326574d730f38efea44b58452ab34065cc2e930490f6ffb0bd63", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c1a538ab9b28326574d730f38efea44b58452ab34065cc2e930490f6ffb0bd63", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1a538ab9b28326574d730f38efea44b58452ab34065cc2e930490f6ffb0bd63", kill_on_drop: false }` [INFO] [stdout] c1a538ab9b28326574d730f38efea44b58452ab34065cc2e930490f6ffb0bd63 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9cce8674427a284023c6756825266f0e9e6c85b418a3853252a9b13ffad6262e [INFO] running `Command { std: "docker" "start" "-a" "9cce8674427a284023c6756825266f0e9e6c85b418a3853252a9b13ffad6262e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.37 [INFO] [stderr] Compiling syn v1.0.91 [INFO] [stderr] Compiling libc v0.2.123 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling parking_lot_core v0.9.2 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Compiling async-trait v0.1.53 [INFO] [stderr] Checking tracing-core v0.1.25 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling anyhow v1.0.56 [INFO] [stderr] Checking strum v0.24.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking atoi v1.0.0 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling darling_core v0.12.4 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling tracing-attributes v0.1.20 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling async-stream-impl v0.3.3 [INFO] [stderr] Compiling getset v0.1.2 [INFO] [stderr] Compiling serial_test_derive v0.6.0 [INFO] [stderr] Compiling derive-new v0.5.9 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Compiling strum_macros v0.24.0 [INFO] [stderr] Compiling test-case v2.0.2 [INFO] [stderr] Checking serial_test v0.6.0 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking async-stream v0.3.3 [INFO] [stderr] Checking tracing v0.1.33 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Compiling darling_macro v0.12.4 [INFO] [stderr] Compiling darling v0.12.4 [INFO] [stderr] Compiling derive_builder_core v0.11.1 [INFO] [stderr] Compiling derive_builder_macro v0.11.1 [INFO] [stderr] Checking tokio-util v0.6.9 [INFO] [stderr] Checking tokio-util v0.7.1 [INFO] [stderr] Checking derive_builder v0.11.1 [INFO] [stderr] Checking tokio-stream v0.1.8 [INFO] [stderr] Checking tokio-test v0.4.2 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking bb8 v0.8.0 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking tchannel_rs v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `tracing` is never used [INFO] [stdout] --> src/frames/payloads.rs:209:8 [INFO] [stdout] | [INFO] [stdout] 207 | pub trait CallFields { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] 208 | fn headers(&self) -> &HashMap; [INFO] [stdout] 209 | fn tracing(&self) -> &Tracing; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 32 | let config = Arc::new(config); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let connection_pools = ConnectionPools::new(config.clone()); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let subchannels = Arc::new(RwLock::new(HashMap::new())); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(TChannel { [INFO] [stdout] | ____________^ [INFO] [stdout] 36 | | config, [INFO] [stdout] 37 | | connection_pools: Arc::new(connection_pools), [INFO] [stdout] 38 | | subchannels, [INFO] [stdout] 39 | | server_handle: Mutex::new(None), [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/mod.rs:122:26 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn new(sender: Sender, buffer_size: usize) -> Connection { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | pending_ids: Arc::new(FramesDispatcher::new(buffer_size)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/mod.rs:179:22 [INFO] [stdout] | [INFO] [stdout] 171 | framed_write: FramedWrite, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | frame_receiver: tokio::sync::mpsc::Receiver, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let frame_sender = FrameSender { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 180 | | frame_sender [INFO] [stdout] 181 | | .run(ReceiverStream::new(frame_receiver)) [INFO] [stdout] 182 | | .then(|_| async { debug!("FrameSender stopped") }) [INFO] [stdout] 183 | | .await [INFO] [stdout] 184 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/mod.rs:183:18 [INFO] [stdout] | [INFO] [stdout] 172 | frame_receiver: tokio::sync::mpsc::Receiver, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let frame_sender = FrameSender { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/mod.rs:220:22 [INFO] [stdout] | [INFO] [stdout] 216 | framed_read: FramedRead, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | frame_senders: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | ) -> JoinHandle<()> { [INFO] [stdout] 219 | let frame_receiver = FrameReceiver { frame_senders }; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 221 | | frame_receiver [INFO] [stdout] 222 | | .run(framed_read) [INFO] [stdout] 223 | | .then(|_| async { debug!("FrameReceiver stopped") }) [INFO] [stdout] 224 | | .await [INFO] [stdout] 225 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/mod.rs:224:18 [INFO] [stdout] | [INFO] [stdout] 216 | framed_read: FramedRead, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | let frame_receiver = FrameReceiver { frame_senders }; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/defragmentation.rs:251:40 [INFO] [stdout] | [INFO] [stdout] 251 | .map(|arg_mut| Bytes::from(arg_mut.split_to(arg_mut.len()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fragmentation.rs:29:25 [INFO] [stdout] | [INFO] [stdout] 24 | service_name: impl AsRef, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | response_code: ResponseCode, [INFO] [stdout] 26 | args: MessageArgs, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | fragmenter: Fragmenter::new(service_name.as_ref().to_string(), args), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fragmentation.rs:104:30 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn new(service_name: String, args: MessageArgs) -> Fragmenter { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | args_fragmenter: ArgsFragmenter::new(args.args), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fragmentation.rs:136:12 [INFO] [stdout] | [INFO] [stdout] 109 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | fields: FIELDS, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let fields_bytes = fields.encode_bytes()?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let payload_limit = calculate_payload_limit(fields_bytes.len()); [INFO] [stdout] 116 | let frame_args = self.next_frame_args(payload_limit); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let mut frames = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | let call_request = CallWithFieldsEncoded::new(flag, fields_bytes, frame_args); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Ok(Box::pin(futures::stream::iter(frames))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fragmentation.rs:183:19 [INFO] [stdout] | [INFO] [stdout] 181 | pub fn new(args: Vec) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | Self { [INFO] [stdout] 183 | args: VecDeque::from(args), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frames/mod.rs:131:12 [INFO] [stdout] | [INFO] [stdout] 126 | let payload = src.split_to((size - FRAME_HEADER_LENGTH) as usize).freeze(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let frame = TFrame { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | Ok(Some(TFrameId { id, frame })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frames/payloads.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 23 | fn encode_bytes(self) -> CodecResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let mut bytes = BytesMut::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | self.encode(&mut bytes)?; [INFO] [stdout] 26 | Ok(Bytes::from(bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frames/payloads.rs:163:12 [INFO] [stdout] | [INFO] [stdout] 163 | Ok(CallArgs::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 164 | | checksum_type, [INFO] [stdout] 165 | | checksum, [INFO] [stdout] 166 | | decode_args(src)?, //arg3 [INFO] [stdout] 167 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frames/payloads.rs:558:5 [INFO] [stdout] | [INFO] [stdout] 557 | fn decode_bitflag Option>(byte: u8, decoder: F) -> CodecResult { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 558 | decoder(byte).ok_or_else(|| CodecError::Error(format!("Unknown flag: {}", byte))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:39:32 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn new(subchannels: SharedSubChannels, buffer_size: usize, server_tasks: usize) -> Server { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | frame_dispatchers: Arc::new(FramesDispatcher::new(buffer_size)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:94:37 [INFO] [stdout] | [INFO] [stdout] 92 | .map_err(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | debug!("Err while dispatching frame: {}", err.to_string()); [INFO] [stdout] 94 | TChannelError::from(ConnectionError::from((id, err, Tracing::default()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 213 | let frame = TFrame::new(Type::Error, err.encode_bytes()?); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | Ok(TFrameId::new(id, frame)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subchannel.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 173 | fn first_addr(addr: ADDR) -> ConnectionResult { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | let mut addrs = addr.to_socket_addrs()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | Err(ConnectionError::Error( [INFO] [stdout] | _________^ [INFO] [stdout] 179 | | "Unable to get host addr".to_string(), [INFO] [stdout] 180 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subchannel.rs:188:44 [INFO] [stdout] | [INFO] [stdout] 188 | .try_for_each(|_res| future::ready(Ok(()))) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:105:29 [INFO] [stdout] | [INFO] [stdout] 104 | fn from(err: std::io::Error) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | CodecError::IoError(IoError(err)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:111:34 [INFO] [stdout] | [INFO] [stdout] 110 | fn from(err: std::io::Error) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | ConnectionError::IoError(IoError(err)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:155:29 [INFO] [stdout] | [INFO] [stdout] 154 | fn from(err: SendError) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | TChannelError::from(ConnectionError::from(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 50 | request_args: MessageArgs, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | ) -> Pin + Send + '_>> { [INFO] [stdout] 52 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 53 | | let request = REQ::try_from(request_args)?; [INFO] [stdout] 54 | | convert(self.0.handle(request).await) [INFO] [stdout] 55 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:54:21 [INFO] [stdout] | [INFO] [stdout] 50 | request_args: MessageArgs, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let request = REQ::try_from(request_args)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | convert(self.0.handle(request).await) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn handle(&mut self, request_args: MessageArgs) -> MessageArgsResponse { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let request = REQ::try_from(request_args)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | convert(self.0.handle(request)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:93:18 [INFO] [stdout] | [INFO] [stdout] 91 | request_args: MessageArgs, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | ) -> Pin + Send + '_>> { [INFO] [stdout] 93 | Box::pin(future::ready(self.handle(request_args))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/messages/raw.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 45 | fn try_from(args: MessageArgs) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let mut deq_args = VecDeque::from(args.args); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Ok(RawMessage::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 54 | | bytes_to_string(deq_args.pop_front())?, [INFO] [stdout] 55 | | bytes_to_string(deq_args.pop_front())?, [INFO] [stdout] 56 | | deq_args.pop_front().unwrap_or_else(Bytes::new), [INFO] [stdout] 57 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/messages/raw.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 64 | fn try_into(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let arg_scheme = RawMessage::args_scheme(); [INFO] [stdout] 66 | let args = Vec::from([self.endpoint.into(), self.header.into(), self.body]); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | Ok(MessageArgs::new(arg_scheme, args)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/messages/raw.rs:92:18 [INFO] [stdout] | [INFO] [stdout] 89 | request: RawMessage, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | host: ADDR, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | ) -> Pin> + Send + '_>> { [INFO] [stdout] 92 | Box::pin(self.send(request, host)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 30 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tchannel_rs` (lib) due to 31 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `tracing` is never used [INFO] [stdout] --> src/frames/payloads.rs:209:8 [INFO] [stdout] | [INFO] [stdout] 207 | pub trait CallFields { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] 208 | fn headers(&self) -> &HashMap; [INFO] [stdout] 209 | fn tracing(&self) -> &Tracing; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 32 | let config = Arc::new(config); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let connection_pools = ConnectionPools::new(config.clone()); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let subchannels = Arc::new(RwLock::new(HashMap::new())); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(TChannel { [INFO] [stdout] | ____________^ [INFO] [stdout] 36 | | config, [INFO] [stdout] 37 | | connection_pools: Arc::new(connection_pools), [INFO] [stdout] 38 | | subchannels, [INFO] [stdout] 39 | | server_handle: Mutex::new(None), [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/mod.rs:122:26 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn new(sender: Sender, buffer_size: usize) -> Connection { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | pending_ids: Arc::new(FramesDispatcher::new(buffer_size)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/mod.rs:179:22 [INFO] [stdout] | [INFO] [stdout] 171 | framed_write: FramedWrite, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | frame_receiver: tokio::sync::mpsc::Receiver, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let frame_sender = FrameSender { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 180 | | frame_sender [INFO] [stdout] 181 | | .run(ReceiverStream::new(frame_receiver)) [INFO] [stdout] 182 | | .then(|_| async { debug!("FrameSender stopped") }) [INFO] [stdout] 183 | | .await [INFO] [stdout] 184 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/mod.rs:183:18 [INFO] [stdout] | [INFO] [stdout] 172 | frame_receiver: tokio::sync::mpsc::Receiver, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let frame_sender = FrameSender { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/mod.rs:220:22 [INFO] [stdout] | [INFO] [stdout] 216 | framed_read: FramedRead, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | frame_senders: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | ) -> JoinHandle<()> { [INFO] [stdout] 219 | let frame_receiver = FrameReceiver { frame_senders }; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 221 | | frame_receiver [INFO] [stdout] 222 | | .run(framed_read) [INFO] [stdout] 223 | | .then(|_| async { debug!("FrameReceiver stopped") }) [INFO] [stdout] 224 | | .await [INFO] [stdout] 225 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/mod.rs:224:18 [INFO] [stdout] | [INFO] [stdout] 216 | framed_read: FramedRead, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | let frame_receiver = FrameReceiver { frame_senders }; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/defragmentation.rs:251:40 [INFO] [stdout] | [INFO] [stdout] 251 | .map(|arg_mut| Bytes::from(arg_mut.split_to(arg_mut.len()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/defragmentation.rs:279:27 [INFO] [stdout] | [INFO] [stdout] 279 | .map(|s| Some(Bytes::from(*s))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fragmentation.rs:29:25 [INFO] [stdout] | [INFO] [stdout] 24 | service_name: impl AsRef, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | response_code: ResponseCode, [INFO] [stdout] 26 | args: MessageArgs, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | fragmenter: Fragmenter::new(service_name.as_ref().to_string(), args), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fragmentation.rs:104:30 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn new(service_name: String, args: MessageArgs) -> Fragmenter { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | args_fragmenter: ArgsFragmenter::new(args.args), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fragmentation.rs:136:12 [INFO] [stdout] | [INFO] [stdout] 109 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | fields: FIELDS, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let fields_bytes = fields.encode_bytes()?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let payload_limit = calculate_payload_limit(fields_bytes.len()); [INFO] [stdout] 116 | let frame_args = self.next_frame_args(payload_limit); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let mut frames = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | let call_request = CallWithFieldsEncoded::new(flag, fields_bytes, frame_args); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Ok(Box::pin(futures::stream::iter(frames))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fragmentation.rs:183:19 [INFO] [stdout] | [INFO] [stdout] 181 | pub fn new(args: Vec) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | Self { [INFO] [stdout] 183 | args: VecDeque::from(args), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frames/mod.rs:131:12 [INFO] [stdout] | [INFO] [stdout] 126 | let payload = src.split_to((size - FRAME_HEADER_LENGTH) as usize).freeze(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let frame = TFrame { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | Ok(Some(TFrameId { id, frame })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frames/payloads.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 23 | fn encode_bytes(self) -> CodecResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let mut bytes = BytesMut::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | self.encode(&mut bytes)?; [INFO] [stdout] 26 | Ok(Bytes::from(bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frames/payloads.rs:163:12 [INFO] [stdout] | [INFO] [stdout] 163 | Ok(CallArgs::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 164 | | checksum_type, [INFO] [stdout] 165 | | checksum, [INFO] [stdout] 166 | | decode_args(src)?, //arg3 [INFO] [stdout] 167 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frames/payloads.rs:558:5 [INFO] [stdout] | [INFO] [stdout] 557 | fn decode_bitflag Option>(byte: u8, decoder: F) -> CodecResult { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 558 | decoder(byte).ok_or_else(|| CodecError::Error(format!("Unknown flag: {}", byte))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:39:32 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn new(subchannels: SharedSubChannels, buffer_size: usize, server_tasks: usize) -> Server { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | frame_dispatchers: Arc::new(FramesDispatcher::new(buffer_size)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:94:37 [INFO] [stdout] | [INFO] [stdout] 92 | .map_err(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | debug!("Err while dispatching frame: {}", err.to_string()); [INFO] [stdout] 94 | TChannelError::from(ConnectionError::from((id, err, Tracing::default()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 213 | let frame = TFrame::new(Type::Error, err.encode_bytes()?); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | Ok(TFrameId::new(id, frame)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subchannel.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 173 | fn first_addr(addr: ADDR) -> ConnectionResult { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | let mut addrs = addr.to_socket_addrs()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | Err(ConnectionError::Error( [INFO] [stdout] | _________^ [INFO] [stdout] 179 | | "Unable to get host addr".to_string(), [INFO] [stdout] 180 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subchannel.rs:188:44 [INFO] [stdout] | [INFO] [stdout] 188 | .try_for_each(|_res| future::ready(Ok(()))) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:105:29 [INFO] [stdout] | [INFO] [stdout] 104 | fn from(err: std::io::Error) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | CodecError::IoError(IoError(err)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:111:34 [INFO] [stdout] | [INFO] [stdout] 110 | fn from(err: std::io::Error) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | ConnectionError::IoError(IoError(err)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:155:29 [INFO] [stdout] | [INFO] [stdout] 154 | fn from(err: SendError) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | TChannelError::from(ConnectionError::from(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 50 | request_args: MessageArgs, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | ) -> Pin + Send + '_>> { [INFO] [stdout] 52 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 53 | | let request = REQ::try_from(request_args)?; [INFO] [stdout] 54 | | convert(self.0.handle(request).await) [INFO] [stdout] 55 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:54:21 [INFO] [stdout] | [INFO] [stdout] 50 | request_args: MessageArgs, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let request = REQ::try_from(request_args)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | convert(self.0.handle(request).await) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn handle(&mut self, request_args: MessageArgs) -> MessageArgsResponse { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let request = REQ::try_from(request_args)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | convert(self.0.handle(request)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:93:18 [INFO] [stdout] | [INFO] [stdout] 91 | request_args: MessageArgs, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | ) -> Pin + Send + '_>> { [INFO] [stdout] 93 | Box::pin(future::ready(self.handle(request_args))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/messages/raw.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 45 | fn try_from(args: MessageArgs) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let mut deq_args = VecDeque::from(args.args); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Ok(RawMessage::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 54 | | bytes_to_string(deq_args.pop_front())?, [INFO] [stdout] 55 | | bytes_to_string(deq_args.pop_front())?, [INFO] [stdout] 56 | | deq_args.pop_front().unwrap_or_else(Bytes::new), [INFO] [stdout] 57 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/messages/raw.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 64 | fn try_into(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let arg_scheme = RawMessage::args_scheme(); [INFO] [stdout] 66 | let args = Vec::from([self.endpoint.into(), self.header.into(), self.body]); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | Ok(MessageArgs::new(arg_scheme, args)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/messages/raw.rs:92:18 [INFO] [stdout] | [INFO] [stdout] 89 | request: RawMessage, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | host: ADDR, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | ) -> Pin> + Send + '_>> { [INFO] [stdout] 92 | Box::pin(self.send(request, host)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 31 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tchannel_rs` (lib test) due to 32 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "9cce8674427a284023c6756825266f0e9e6c85b418a3853252a9b13ffad6262e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9cce8674427a284023c6756825266f0e9e6c85b418a3853252a9b13ffad6262e", kill_on_drop: false }` [INFO] [stdout] 9cce8674427a284023c6756825266f0e9e6c85b418a3853252a9b13ffad6262e