[INFO] fetching crate tcgeneric 0.11.0... [INFO] checking tcgeneric-0.11.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tcgeneric 0.11.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate tcgeneric 0.11.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tcgeneric 0.11.0 [INFO] finished tweaking crates.io crate tcgeneric 0.11.0 [INFO] tweaked toml for crates.io crate tcgeneric 0.11.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 66 packages to latest compatible versions [INFO] [stderr] Adding attribute-derive v0.6.1 (latest: v0.10.1) [INFO] [stderr] Adding attribute-derive-macro v0.6.1 (latest: v0.10.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding proc-macro-utils v0.8.0 (latest: v0.10.0) [INFO] [stderr] Adding quote-use v0.7.2 (latest: v0.8.4) [INFO] [stderr] Adding quote-use-macros v0.7.2 (latest: v0.8.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 98488866b4136d8219e7bb5dea5d8c37319866de19d629d484e03f76688a8235 [INFO] running `Command { std: "docker" "start" "-a" "98488866b4136d8219e7bb5dea5d8c37319866de19d629d484e03f76688a8235", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "98488866b4136d8219e7bb5dea5d8c37319866de19d629d484e03f76688a8235", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "98488866b4136d8219e7bb5dea5d8c37319866de19d629d484e03f76688a8235", kill_on_drop: false }` [INFO] [stdout] 98488866b4136d8219e7bb5dea5d8c37319866de19d629d484e03f76688a8235 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ce30cd121fbe01a69e4fc2d1be8ecf504e6779e319d124f3022aad2ded6cc895 [INFO] running `Command { std: "docker" "start" "-a" "ce30cd121fbe01a69e4fc2d1be8ecf504e6779e319d124f3022aad2ded6cc895", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Compiling collection_literals v1.0.1 [INFO] [stderr] Compiling interpolator v0.5.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling derive-where v1.2.7 [INFO] [stderr] Checking safecast v0.2.3 [INFO] [stderr] Checking get-size v0.1.4 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Compiling proc-macro-utils v0.8.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling quote-use-macros v0.7.2 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Compiling quote-use v0.7.2 [INFO] [stderr] Compiling attribute-derive-macro v0.6.1 [INFO] [stderr] Compiling attribute-derive v0.6.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking destream v0.8.0 [INFO] [stderr] Checking async-hash v0.5.4 [INFO] [stderr] Compiling get-size-derive v0.1.3 [INFO] [stderr] Checking hr-id v0.6.0 [INFO] [stderr] Checking pathlink v0.3.0 [INFO] [stderr] Checking tc-error v0.12.0 [INFO] [stderr] Checking tcgeneric v0.11.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 87 | let path: TCPathBuf = v.parse().map_err(destream::de::Error::custom)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | T::from_path(&path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:89:25 [INFO] [stdout] | [INFO] [stdout] 87 | let path: TCPathBuf = v.parse().map_err(destream::de::Error::custom)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | T::from_path(&path) [INFO] [stdout] 89 | .ok_or_else(|| destream::de::Error::invalid_value(path, Self::expecting())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:95:40 [INFO] [stdout] | [INFO] [stdout] 94 | mut map: A, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | ) -> Result { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 96 | | if let Some(key) = map.next_key::(()).await? { [INFO] [stdout] 97 | | let _value = map.next_value::<()>(()).await?; [INFO] [stdout] 98 | | let path: TCPathBuf = key.parse().map_err(destream::de::Error::custom)?; [INFO] [stdout] ... | [INFO] [stdout] 104 | | } [INFO] [stdout] 105 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map.rs:232:14 [INFO] [stdout] | [INFO] [stdout] 221 | fn opt_cast_from(tuple: Tuple) -> Option { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | let mut inner = BTreeMap::::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | Some(Self { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map.rs:263:9 [INFO] [stdout] | [INFO] [stdout] 262 | fn deserialize>(deserializer: D) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | BTreeMap::deserialize(deserializer).map(|inner| Self { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tuple.rs:308:9 [INFO] [stdout] | [INFO] [stdout] 307 | fn deserialize>(deserializer: D) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 308 | Vec::::deserialize(deserializer).map(|inner| Self { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tcgeneric` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 87 | let path: TCPathBuf = v.parse().map_err(destream::de::Error::custom)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | T::from_path(&path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:89:25 [INFO] [stdout] | [INFO] [stdout] 87 | let path: TCPathBuf = v.parse().map_err(destream::de::Error::custom)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | T::from_path(&path) [INFO] [stdout] 89 | .ok_or_else(|| destream::de::Error::invalid_value(path, Self::expecting())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:95:40 [INFO] [stdout] | [INFO] [stdout] 94 | mut map: A, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | ) -> Result { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 96 | | if let Some(key) = map.next_key::(()).await? { [INFO] [stdout] 97 | | let _value = map.next_value::<()>(()).await?; [INFO] [stdout] 98 | | let path: TCPathBuf = key.parse().map_err(destream::de::Error::custom)?; [INFO] [stdout] ... | [INFO] [stdout] 104 | | } [INFO] [stdout] 105 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map.rs:232:14 [INFO] [stdout] | [INFO] [stdout] 221 | fn opt_cast_from(tuple: Tuple) -> Option { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | let mut inner = BTreeMap::::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | Some(Self { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map.rs:263:9 [INFO] [stdout] | [INFO] [stdout] 262 | fn deserialize>(deserializer: D) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | BTreeMap::deserialize(deserializer).map(|inner| Self { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tuple.rs:308:9 [INFO] [stdout] | [INFO] [stdout] 307 | fn deserialize>(deserializer: D) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 308 | Vec::::deserialize(deserializer).map(|inner| Self { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tcgeneric` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "ce30cd121fbe01a69e4fc2d1be8ecf504e6779e319d124f3022aad2ded6cc895", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ce30cd121fbe01a69e4fc2d1be8ecf504e6779e319d124f3022aad2ded6cc895", kill_on_drop: false }` [INFO] [stdout] ce30cd121fbe01a69e4fc2d1be8ecf504e6779e319d124f3022aad2ded6cc895