[INFO] fetching crate tcalc 1.8.1... [INFO] checking tcalc-1.8.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tcalc 1.8.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate tcalc 1.8.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tcalc 1.8.1 [INFO] finished tweaking crates.io crate tcalc 1.8.1 [INFO] tweaked toml for crates.io crate tcalc 1.8.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate tcalc 1.8.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 086e4cdfea4f53ebf54bce670834dab483f44068859152750c4e7afeb94adc1b [INFO] running `Command { std: "docker" "start" "-a" "086e4cdfea4f53ebf54bce670834dab483f44068859152750c4e7afeb94adc1b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "086e4cdfea4f53ebf54bce670834dab483f44068859152750c4e7afeb94adc1b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "086e4cdfea4f53ebf54bce670834dab483f44068859152750c4e7afeb94adc1b", kill_on_drop: false }` [INFO] [stdout] 086e4cdfea4f53ebf54bce670834dab483f44068859152750c4e7afeb94adc1b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a685e60f60da60720bd28be938ade4a36d0514884d0d20f753c49e10f35a2c0e [INFO] running `Command { std: "docker" "start" "-a" "a685e60f60da60720bd28be938ade4a36d0514884d0d20f753c49e10f35a2c0e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.135 [INFO] [stderr] Compiling semver v0.1.20 [INFO] [stderr] Checking cfg-if v0.1.2 [INFO] [stderr] Checking bitflags v0.4.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking encode_unicode v0.1.3 [INFO] [stderr] Checking unicode-width v0.1.4 [INFO] [stderr] Compiling rustc_version v0.1.7 [INFO] [stderr] Compiling nix v0.7.0 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking tcalc-rustyline v1.0.2 [INFO] [stderr] Checking tcalc v1.8.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `length` is never read [INFO] [stdout] --> src/scanning.rs:45:6 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct Token { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 45 | pub length: u32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffered_iterator.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn new(itr: TIter) -> BufferedIterator { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | buf: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:232:8 [INFO] [stdout] | [INFO] [stdout] 169 | let expr = self.parse_bitor(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let mut right_opt: Option = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | let mut right = unwrap!(right_opt, { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | Some(Expression::Assignment(Assignment { [INFO] [stdout] | ______________^ [INFO] [stdout] 233 | | var, [INFO] [stdout] 234 | | right: Box::new(right), [INFO] [stdout] 235 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] ::: src/macros.rs:4:32 [INFO] [stdout] | [INFO] [stdout] 4 | ::std::option::Option::Some(val) => val, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:260:8 [INFO] [stdout] | [INFO] [stdout] 245 | let mut exprs: Vec = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | Some(Expression::Call(Call { [INFO] [stdout] | ______________^ [INFO] [stdout] 261 | | name, [INFO] [stdout] 262 | | params: exprs, [INFO] [stdout] 263 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tcalc` (bin "tcalc") due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `length` is never read [INFO] [stdout] --> src/scanning.rs:45:6 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct Token { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 45 | pub length: u32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffered_iterator.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn new(itr: TIter) -> BufferedIterator { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | buf: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:232:8 [INFO] [stdout] | [INFO] [stdout] 169 | let expr = self.parse_bitor(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let mut right_opt: Option = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | let mut right = unwrap!(right_opt, { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | Some(Expression::Assignment(Assignment { [INFO] [stdout] | ______________^ [INFO] [stdout] 233 | | var, [INFO] [stdout] 234 | | right: Box::new(right), [INFO] [stdout] 235 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] ::: src/macros.rs:4:32 [INFO] [stdout] | [INFO] [stdout] 4 | ::std::option::Option::Some(val) => val, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:260:8 [INFO] [stdout] | [INFO] [stdout] 245 | let mut exprs: Vec = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | Some(Expression::Call(Call { [INFO] [stdout] | ______________^ [INFO] [stdout] 261 | | name, [INFO] [stdout] 262 | | params: exprs, [INFO] [stdout] 263 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:480:26 [INFO] [stdout] | [INFO] [stdout] 479 | fn assign_expr(name: &str, right: Expression) -> Expression { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 480 | Expression::Assignment(Assignment { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 481 | | var: var(name), [INFO] [stdout] 482 | | right: Box::new(right), [INFO] [stdout] 483 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:487:19 [INFO] [stdout] | [INFO] [stdout] 486 | fn assign_ast(name: &str, right: Expression) -> Ast { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 487 | Ast::Expression(assign_expr(name, right)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:491:22 [INFO] [stdout] | [INFO] [stdout] 490 | fn bin_op_expr(left: Expression, op: BinaryOp, right: Expression) -> Expression { [INFO] [stdout] | ---------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 491 | Expression::Binary(Binary { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 492 | | left: Box::new(left), [INFO] [stdout] 493 | | op, [INFO] [stdout] 494 | | right: Box::new(right), [INFO] [stdout] 495 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:499:19 [INFO] [stdout] | [INFO] [stdout] 498 | fn bin_op_ast(left: Expression, op: BinaryOp, right: Expression) -> Ast { [INFO] [stdout] | ---------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 499 | Ast::Expression(bin_op_expr(left, op, right)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:503:20 [INFO] [stdout] | [INFO] [stdout] 502 | fn call_expr(name: &str, exprs: Vec) -> Expression { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 503 | Expression::Call(Call { [INFO] [stdout] | __________________________^ [INFO] [stdout] 504 | | name: name.to_string(), [INFO] [stdout] 505 | | params: exprs, [INFO] [stdout] 506 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:510:19 [INFO] [stdout] | [INFO] [stdout] 509 | fn call_ast(name: &str, exprs: Vec) -> Ast { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 510 | Ast::Expression(call_expr(name, exprs)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:514:21 [INFO] [stdout] | [INFO] [stdout] 513 | fn comp_assign_expr(name: &str, op: BinaryOp, right: Expression) -> Expression { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 514 | assign_expr(name, bin_op_expr(var_expr(name), op, right)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:518:20 [INFO] [stdout] | [INFO] [stdout] 517 | fn comp_assign_ast(name: &str, op: BinaryOp, right: Expression) -> Ast { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 518 | assign_ast(name, bin_op_expr(var_expr(name), op, right)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:530:21 [INFO] [stdout] | [INFO] [stdout] 529 | fn uni_op_expr(op: UnaryOp, right: Expression) -> Expression { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 530 | Expression::Unary(Unary { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 531 | | op, [INFO] [stdout] 532 | | right: Box::new(right), [INFO] [stdout] 533 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:537:19 [INFO] [stdout] | [INFO] [stdout] 536 | fn uni_op_ast(op: UnaryOp, right: Expression) -> Ast { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 537 | Ast::Expression(uni_op_expr(op, right)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tcalc` (bin "tcalc" test) due to 14 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "a685e60f60da60720bd28be938ade4a36d0514884d0d20f753c49e10f35a2c0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a685e60f60da60720bd28be938ade4a36d0514884d0d20f753c49e10f35a2c0e", kill_on_drop: false }` [INFO] [stdout] a685e60f60da60720bd28be938ade4a36d0514884d0d20f753c49e10f35a2c0e