[INFO] fetching crate tc-value 0.13.1... [INFO] checking tc-value-0.13.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tc-value 0.13.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate tc-value 0.13.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tc-value 0.13.1 [INFO] finished tweaking crates.io crate tc-value 0.13.1 [INFO] tweaked toml for crates.io crate tc-value 0.13.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 99 packages to latest compatible versions [INFO] [stderr] Adding attribute-derive v0.6.1 (latest: v0.10.1) [INFO] [stderr] Adding attribute-derive-macro v0.6.1 (latest: v0.10.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding proc-macro-utils v0.8.0 (latest: v0.10.0) [INFO] [stderr] Adding quick-xml v0.18.1 (latest: v0.36.1) [INFO] [stderr] Adding quote-use v0.7.2 (latest: v0.8.4) [INFO] [stderr] Adding quote-use-macros v0.7.2 (latest: v0.8.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eb3de409b0627c0249fde6a1470efefe35f38cf6992ff84931c9135f6756c154 [INFO] running `Command { std: "docker" "start" "-a" "eb3de409b0627c0249fde6a1470efefe35f38cf6992ff84931c9135f6756c154", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eb3de409b0627c0249fde6a1470efefe35f38cf6992ff84931c9135f6756c154", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eb3de409b0627c0249fde6a1470efefe35f38cf6992ff84931c9135f6756c154", kill_on_drop: false }` [INFO] [stdout] eb3de409b0627c0249fde6a1470efefe35f38cf6992ff84931c9135f6756c154 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1b4535215263c25e4030e565b0a24216d5513f7e59b3f851b51f97be49595143 [INFO] running `Command { std: "docker" "start" "-a" "1b4535215263c25e4030e565b0a24216d5513f7e59b3f851b51f97be49595143", kill_on_drop: false }` [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling derive-where v1.2.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling proc-macro-utils v0.8.0 [INFO] [stderr] Compiling collection_literals v1.0.1 [INFO] [stderr] Compiling interpolator v0.5.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking safecast v0.2.3 [INFO] [stderr] Checking get-size v0.1.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling quote-use-macros v0.7.2 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking collate v0.4.2 [INFO] [stderr] Compiling quote-use v0.7.2 [INFO] [stderr] Compiling attribute-derive-macro v0.6.1 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling attribute-derive v0.6.1 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Compiling get-size-derive v0.1.3 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking async-hash v0.5.4 [INFO] [stderr] Checking destream v0.8.0 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking handlebars v6.0.0 [INFO] [stderr] Checking email-address-parser v2.0.0 [INFO] [stderr] Checking hr-id v0.6.0 [INFO] [stderr] Checking number-general v0.12.0 [INFO] [stderr] Checking pathlink v0.3.0 [INFO] [stderr] Checking tc-error v0.12.0 [INFO] [stderr] Checking tcgeneric v0.11.0 [INFO] [stderr] Checking tc-value v0.13.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class.rs:406:25 [INFO] [stdout] | [INFO] [stdout] 404 | fn visit_path(self, path: TCPathBuf) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 405 | ValueType::from_path(&path) [INFO] [stdout] 406 | .ok_or_else(|| DestreamError::invalid_value(path, Self::expecting())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class.rs:423:96 [INFO] [stdout] | [INFO] [stdout] 423 | async fn visit_map(self, mut access: A) -> Result { [INFO] [stdout] | ____________________________________________________---------___________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 424 | | if let Some(path) = access.next_key::(()).await? { [INFO] [stdout] 425 | | if let Ok(map) = access.next_value::>(()).await { [INFO] [stdout] 426 | | if map.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 451 | | } [INFO] [stdout] 452 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/string.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn render(&self, data: T) -> TCResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | / Handlebars::new() [INFO] [stdout] 58 | | .render_template(self.0.as_ref(), &json!(data)) [INFO] [stdout] 59 | | .map(Self::from) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/string.rs:95:14 [INFO] [stdout] | [INFO] [stdout] 94 | fn from(id: Id) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | Self(id.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/string.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 157 | fn deserialize>(deserializer: D) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | String::deserialize(deserializer).map(Self::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:395:21 [INFO] [stdout] | [INFO] [stdout] 394 | fn from(bytes: Bytes) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 395 | Self::Bytes(Vec::from(bytes).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:422:21 [INFO] [stdout] | [INFO] [stdout] 421 | fn from(path: TCPathBuf) -> Value { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 422 | Value::Link(path.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:428:21 [INFO] [stdout] | [INFO] [stdout] 427 | fn from(tuple: Vec) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 428 | Self::Tuple(tuple.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:458:22 [INFO] [stdout] | [INFO] [stdout] 457 | fn cast_from(value: (T1, T2)) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 458 | Value::Tuple(vec![value.0.cast_into(), value.1.cast_into()].into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:999:9 [INFO] [stdout] | [INFO] [stdout] 998 | fn opt_cast_from(value: Value) -> Option { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 999 | SmallVec::<[(Id, T); 32]>::opt_cast_from(value).map(|entries| entries.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:999:71 [INFO] [stdout] | [INFO] [stdout] 999 | SmallVec::<[(Id, T); 32]>::opt_cast_from(value).map(|entries| entries.into_iter().collect()) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:1045:9 [INFO] [stdout] | [INFO] [stdout] 1044 | fn opt_cast_from(value: Value) -> Option { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1045 | Vec::::opt_cast_from(value).map(Tuple::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:1110:12 [INFO] [stdout] | [INFO] [stdout] 1106 | fn visit_number(self, n: N) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1110 | Ok(Value::Number(Number::cast_from(n))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:1324:12 [INFO] [stdout] | [INFO] [stdout] 1313 | fn visit_seq>(self, mut seq: A) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1314 | let mut value = if let Some(len) = seq.size_hint() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1324 | Ok(Value::Tuple(value.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:1373:40 [INFO] [stdout] | [INFO] [stdout] 1372 | mut array: A, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1373 | ) -> Result { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 1374 | | let mut bytes = Vec::new(); [INFO] [stdout] 1375 | | let mut buf = [0u8; 4_096]; [INFO] [stdout] ... | [INFO] [stdout] 1386 | | Ok(Value::Bytes(bytes.into())) [INFO] [stdout] 1387 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:1445:99 [INFO] [stdout] | [INFO] [stdout] 1445 | async fn visit_map(self, mut map: A) -> Result { [INFO] [stdout] | __________________________________________________________------___________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1446 | | use ValueType as VT; [INFO] [stdout] 1447 | | [INFO] [stdout] 1448 | | if let Some(key) = map.next_key::(()).await? { [INFO] [stdout] ... | [INFO] [stdout] 1474 | | } [INFO] [stdout] 1475 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:1477:99 [INFO] [stdout] | [INFO] [stdout] 1477 | async fn visit_seq(self, mut seq: A) -> Result { [INFO] [stdout] | __________________________________________________________------___________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1478 | | let mut value = if let Some(len) = seq.size_hint() { [INFO] [stdout] 1479 | | Vec::with_capacity(len) [INFO] [stdout] 1480 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 1488 | | Ok(Value::Tuple(value.into())) [INFO] [stdout] 1489 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tc-value` (lib test) due to 18 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class.rs:406:25 [INFO] [stdout] | [INFO] [stdout] 404 | fn visit_path(self, path: TCPathBuf) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 405 | ValueType::from_path(&path) [INFO] [stdout] 406 | .ok_or_else(|| DestreamError::invalid_value(path, Self::expecting())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class.rs:423:96 [INFO] [stdout] | [INFO] [stdout] 423 | async fn visit_map(self, mut access: A) -> Result { [INFO] [stdout] | ____________________________________________________---------___________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 424 | | if let Some(path) = access.next_key::(()).await? { [INFO] [stdout] 425 | | if let Ok(map) = access.next_value::>(()).await { [INFO] [stdout] 426 | | if map.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 451 | | } [INFO] [stdout] 452 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/string.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn render(&self, data: T) -> TCResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | / Handlebars::new() [INFO] [stdout] 58 | | .render_template(self.0.as_ref(), &json!(data)) [INFO] [stdout] 59 | | .map(Self::from) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/string.rs:95:14 [INFO] [stdout] | [INFO] [stdout] 94 | fn from(id: Id) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | Self(id.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/string.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 157 | fn deserialize>(deserializer: D) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | String::deserialize(deserializer).map(Self::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:395:21 [INFO] [stdout] | [INFO] [stdout] 394 | fn from(bytes: Bytes) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 395 | Self::Bytes(Vec::from(bytes).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:422:21 [INFO] [stdout] | [INFO] [stdout] 421 | fn from(path: TCPathBuf) -> Value { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 422 | Value::Link(path.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:428:21 [INFO] [stdout] | [INFO] [stdout] 427 | fn from(tuple: Vec) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 428 | Self::Tuple(tuple.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:458:22 [INFO] [stdout] | [INFO] [stdout] 457 | fn cast_from(value: (T1, T2)) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 458 | Value::Tuple(vec![value.0.cast_into(), value.1.cast_into()].into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:999:9 [INFO] [stdout] | [INFO] [stdout] 998 | fn opt_cast_from(value: Value) -> Option { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 999 | SmallVec::<[(Id, T); 32]>::opt_cast_from(value).map(|entries| entries.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:999:71 [INFO] [stdout] | [INFO] [stdout] 999 | SmallVec::<[(Id, T); 32]>::opt_cast_from(value).map(|entries| entries.into_iter().collect()) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:1045:9 [INFO] [stdout] | [INFO] [stdout] 1044 | fn opt_cast_from(value: Value) -> Option { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1045 | Vec::::opt_cast_from(value).map(Tuple::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:1110:12 [INFO] [stdout] | [INFO] [stdout] 1106 | fn visit_number(self, n: N) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1110 | Ok(Value::Number(Number::cast_from(n))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:1324:12 [INFO] [stdout] | [INFO] [stdout] 1313 | fn visit_seq>(self, mut seq: A) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1314 | let mut value = if let Some(len) = seq.size_hint() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1324 | Ok(Value::Tuple(value.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:1373:40 [INFO] [stdout] | [INFO] [stdout] 1372 | mut array: A, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1373 | ) -> Result { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 1374 | | let mut bytes = Vec::new(); [INFO] [stdout] 1375 | | let mut buf = [0u8; 4_096]; [INFO] [stdout] ... | [INFO] [stdout] 1386 | | Ok(Value::Bytes(bytes.into())) [INFO] [stdout] 1387 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:1445:99 [INFO] [stdout] | [INFO] [stdout] 1445 | async fn visit_map(self, mut map: A) -> Result { [INFO] [stdout] | __________________________________________________________------___________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1446 | | use ValueType as VT; [INFO] [stdout] 1447 | | [INFO] [stdout] 1448 | | if let Some(key) = map.next_key::(()).await? { [INFO] [stdout] ... | [INFO] [stdout] 1474 | | } [INFO] [stdout] 1475 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:1477:99 [INFO] [stdout] | [INFO] [stdout] 1477 | async fn visit_seq(self, mut seq: A) -> Result { [INFO] [stdout] | __________________________________________________________------___________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1478 | | let mut value = if let Some(len) = seq.size_hint() { [INFO] [stdout] 1479 | | Vec::with_capacity(len) [INFO] [stdout] 1480 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 1488 | | Ok(Value::Tuple(value.into())) [INFO] [stdout] 1489 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tc-value` (lib) due to 18 previous errors [INFO] running `Command { std: "docker" "inspect" "1b4535215263c25e4030e565b0a24216d5513f7e59b3f851b51f97be49595143", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b4535215263c25e4030e565b0a24216d5513f7e59b3f851b51f97be49595143", kill_on_drop: false }` [INFO] [stdout] 1b4535215263c25e4030e565b0a24216d5513f7e59b3f851b51f97be49595143