[INFO] fetching crate tass 0.10.1... [INFO] checking tass-0.10.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tass 0.10.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate tass 0.10.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tass 0.10.1 [INFO] finished tweaking crates.io crate tass 0.10.1 [INFO] tweaked toml for crates.io crate tass 0.10.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate tass 0.10.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f373a6e06d30561b73deaaf3056dda3eb547e88e6863d96837a5496b84a3ccc8 [INFO] running `Command { std: "docker" "start" "-a" "f373a6e06d30561b73deaaf3056dda3eb547e88e6863d96837a5496b84a3ccc8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f373a6e06d30561b73deaaf3056dda3eb547e88e6863d96837a5496b84a3ccc8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f373a6e06d30561b73deaaf3056dda3eb547e88e6863d96837a5496b84a3ccc8", kill_on_drop: false }` [INFO] [stdout] f373a6e06d30561b73deaaf3056dda3eb547e88e6863d96837a5496b84a3ccc8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cdac85c8c191f35ccd11eb0ad4ed900ad80712bafe93708cdbb67c819b2e943e [INFO] running `Command { std: "docker" "start" "-a" "cdac85c8c191f35ccd11eb0ad4ed900ad80712bafe93708cdbb67c819b2e943e", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking bytes v1.7.0 [INFO] [stderr] Checking arrow-schema v52.2.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Compiling regex v1.10.5 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Compiling serde_json v1.0.121 [INFO] [stderr] Compiling zstd-safe v7.2.0 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking object v0.36.2 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Compiling flatbuffers v24.3.25 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking integer-encoding v3.0.4 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking lz4_flex v0.11.3 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Compiling chrono-tz-build v0.3.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Compiling seq-macro v0.3.5 [INFO] [stderr] Compiling cc v1.1.7 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking fileslice v0.5.0 [INFO] [stderr] Checking hsl v0.1.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling chrono-tz v0.9.0 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking thrift v0.17.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling zstd-sys v2.0.12+zstd.1.5.6 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking arrow-buffer v52.2.0 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking arrow-data v52.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling bpaf_derive v0.5.10 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking bpaf v0.9.12 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking arrow-array v52.2.0 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking arrow-select v52.2.0 [INFO] [stderr] Checking arrow-row v52.2.0 [INFO] [stderr] Checking arrow-arith v52.2.0 [INFO] [stderr] Checking arrow-cast v52.2.0 [INFO] [stderr] Checking arrow-string v52.2.0 [INFO] [stderr] Checking arrow-ord v52.2.0 [INFO] [stderr] Checking arrow-ipc v52.2.0 [INFO] [stderr] Checking arrow-json v52.2.0 [INFO] [stderr] Checking arrow-csv v52.2.0 [INFO] [stderr] Checking parquet v52.2.0 [INFO] [stderr] Checking arrow v52.2.0 [INFO] [stderr] Checking tass v0.10.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:136:8 [INFO] [stdout] | [INFO] [stdout] 122 | let (file, ext) = match &opts.path { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | bail!("Need to specify a filename or feed data to stdin"); [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | } [INFO] [stdout] 129 | let tmpfile = tempfile::tempfile()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | let mut wtr = LineWriter::new(tmpfile.try_clone()?); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Ok(match opts.format.as_deref().or(ext) { [INFO] [stdout] | ________^ [INFO] [stdout] 137 | | #[cfg(feature = "parquet")] [INFO] [stdout] 138 | | Some("parquet") => Box::new(crate::backend::parquet::ParquetFile::new(file)?), [INFO] [stdout] 139 | | Some("csv") => Box::new(crate::backend::csv::CsvFile::new(file, b',')?), [INFO] [stdout] ... | [INFO] [stdout] 144 | | _ => bail!("Unrecognised file extension"), [INFO] [stdout] 145 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:165:21 [INFO] [stdout] | [INFO] [stdout] 161 | fn new(source: Box) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | big_df: RecordBatch::new_empty(Schema::empty().into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:413:51 [INFO] [stdout] | [INFO] [stdout] 413 | .with_writer(|| WriteThroughMutex(LOG_BUFFER.get().unwrap())), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/csv.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(file: File, delimiter: u8) -> anyhow::Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Ok(CsvFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 24 | | fs: FileSlice::new(file.try_clone()?).slice(0..0), [INFO] [stdout] 25 | | format: Format::default() [INFO] [stdout] 26 | | .with_header(false) [INFO] [stdout] ... | [INFO] [stdout] 29 | | schema: Schema::empty().into(), [INFO] [stdout] 30 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/parquet.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(file: File) -> anyhow::Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | Ok(ParquetFile { file, n_rows }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:136:8 [INFO] [stdout] | [INFO] [stdout] 122 | let (file, ext) = match &opts.path { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | bail!("Need to specify a filename or feed data to stdin"); [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | } [INFO] [stdout] 129 | let tmpfile = tempfile::tempfile()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | let mut wtr = LineWriter::new(tmpfile.try_clone()?); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Ok(match opts.format.as_deref().or(ext) { [INFO] [stdout] | ________^ [INFO] [stdout] 137 | | #[cfg(feature = "parquet")] [INFO] [stdout] 138 | | Some("parquet") => Box::new(crate::backend::parquet::ParquetFile::new(file)?), [INFO] [stdout] 139 | | Some("csv") => Box::new(crate::backend::csv::CsvFile::new(file, b',')?), [INFO] [stdout] ... | [INFO] [stdout] 144 | | _ => bail!("Unrecognised file extension"), [INFO] [stdout] 145 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:165:21 [INFO] [stdout] | [INFO] [stdout] 161 | fn new(source: Box) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | big_df: RecordBatch::new_empty(Schema::empty().into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:413:51 [INFO] [stdout] | [INFO] [stdout] 413 | .with_writer(|| WriteThroughMutex(LOG_BUFFER.get().unwrap())), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/csv.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(file: File, delimiter: u8) -> anyhow::Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Ok(CsvFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 24 | | fs: FileSlice::new(file.try_clone()?).slice(0..0), [INFO] [stdout] 25 | | format: Format::default() [INFO] [stdout] 26 | | .with_header(false) [INFO] [stdout] ... | [INFO] [stdout] 29 | | schema: Schema::empty().into(), [INFO] [stdout] 30 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/parquet.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(file: File) -> anyhow::Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | Ok(ParquetFile { file, n_rows }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tass` (bin "tass") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tass` (bin "tass" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "cdac85c8c191f35ccd11eb0ad4ed900ad80712bafe93708cdbb67c819b2e943e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cdac85c8c191f35ccd11eb0ad4ed900ad80712bafe93708cdbb67c819b2e943e", kill_on_drop: false }` [INFO] [stdout] cdac85c8c191f35ccd11eb0ad4ed900ad80712bafe93708cdbb67c819b2e943e