[INFO] fetching crate tasque 0.1.5... [INFO] checking tasque-0.1.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tasque 0.1.5 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate tasque 0.1.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tasque 0.1.5 [INFO] finished tweaking crates.io crate tasque 0.1.5 [INFO] tweaked toml for crates.io crate tasque 0.1.5 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate tasque 0.1.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fe2401e97f36e2731f26aa47ecd3a376a6b35f072cbcb3fc195d058b3b446297 [INFO] running `Command { std: "docker" "start" "-a" "fe2401e97f36e2731f26aa47ecd3a376a6b35f072cbcb3fc195d058b3b446297", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fe2401e97f36e2731f26aa47ecd3a376a6b35f072cbcb3fc195d058b3b446297", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe2401e97f36e2731f26aa47ecd3a376a6b35f072cbcb3fc195d058b3b446297", kill_on_drop: false }` [INFO] [stdout] fe2401e97f36e2731f26aa47ecd3a376a6b35f072cbcb3fc195d058b3b446297 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 740bb3ee09f7774d46a1877b0b769c42623c3f1d489146288a1c42356e1f1f16 [INFO] running `Command { std: "docker" "start" "-a" "740bb3ee09f7774d46a1877b0b769c42623c3f1d489146288a1c42356e1f1f16", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Checking nom v2.2.1 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Checking atomic_immut v0.1.4 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling procinfo v0.4.2 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling trackable_derive v0.1.2 [INFO] [stderr] Checking trackable v0.2.23 [INFO] [stderr] Checking prometrics v0.1.12 [INFO] [stderr] Checking tasque v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:60:29 [INFO] [stdout] | [INFO] [stdout] 57 | pub(crate) fn new(mut builder: MetricBuilder) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | enqueued_tasks: builder [INFO] [stdout] | _____________________________^ [INFO] [stdout] 61 | | .counter("enqueued_tasks_total") [INFO] [stdout] 62 | | .help("Number of enqueued tasks") [INFO] [stdout] 63 | | .finish() [INFO] [stdout] 64 | | .expect("Never fails"), [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:65:29 [INFO] [stdout] | [INFO] [stdout] 57 | pub(crate) fn new(mut builder: MetricBuilder) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | dequeued_tasks: builder [INFO] [stdout] | _____________________________^ [INFO] [stdout] 66 | | .counter("dequeued_tasks_total") [INFO] [stdout] 67 | | .help("Number of dequeued tasks (those may not have been executed yet)") [INFO] [stdout] 68 | | .finish() [INFO] [stdout] 69 | | .expect("Never fails"), [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:70:22 [INFO] [stdout] | [INFO] [stdout] 57 | pub(crate) fn new(mut builder: MetricBuilder) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | workers: builder [INFO] [stdout] | ______________________^ [INFO] [stdout] 71 | | .gauge("workers") [INFO] [stdout] 72 | | .help("Number of workers") [INFO] [stdout] 73 | | .finish() [INFO] [stdout] 74 | | .expect("Never fails"), [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:75:30 [INFO] [stdout] | [INFO] [stdout] 57 | pub(crate) fn new(mut builder: MetricBuilder) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | worker_restarts: builder [INFO] [stdout] | ______________________________^ [INFO] [stdout] 76 | | .counter("worker_restarts_total") [INFO] [stdout] 77 | | .help("Number of worker restarts") [INFO] [stdout] 78 | | .finish() [INFO] [stdout] 79 | | .expect("Never fails"), [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:80:36 [INFO] [stdout] | [INFO] [stdout] 57 | pub(crate) fn new(mut builder: MetricBuilder) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | task_duration_seconds: builder [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 81 | | .histogram("task_duration_seconds") [INFO] [stdout] 82 | | .help("Execution time of tasks") [INFO] [stdout] 83 | | .bucket(0.001) [INFO] [stdout] ... | [INFO] [stdout] 89 | | .finish() [INFO] [stdout] 90 | | .expect("Never fails"), [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:19:19 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(task: F, ctrl_tx: mpsc::Sender) -> Self [INFO] [stdout] | ------- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | let mut f = Some(task); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Task { [INFO] [stdout] 19 | task: Box::new(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 20 | | let f = f.take().expect("Never fails"); [INFO] [stdout] 21 | | f() [INFO] [stdout] 22 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(task: F, ctrl_tx: mpsc::Sender) -> Self [INFO] [stdout] | ------- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | let mut f = Some(task); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | worker: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:60:29 [INFO] [stdout] | [INFO] [stdout] 57 | pub(crate) fn new(mut builder: MetricBuilder) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | enqueued_tasks: builder [INFO] [stdout] | _____________________________^ [INFO] [stdout] 61 | | .counter("enqueued_tasks_total") [INFO] [stdout] 62 | | .help("Number of enqueued tasks") [INFO] [stdout] 63 | | .finish() [INFO] [stdout] 64 | | .expect("Never fails"), [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:65:29 [INFO] [stdout] | [INFO] [stdout] 57 | pub(crate) fn new(mut builder: MetricBuilder) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | dequeued_tasks: builder [INFO] [stdout] | _____________________________^ [INFO] [stdout] 66 | | .counter("dequeued_tasks_total") [INFO] [stdout] 67 | | .help("Number of dequeued tasks (those may not have been executed yet)") [INFO] [stdout] 68 | | .finish() [INFO] [stdout] 69 | | .expect("Never fails"), [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:70:22 [INFO] [stdout] | [INFO] [stdout] 57 | pub(crate) fn new(mut builder: MetricBuilder) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | workers: builder [INFO] [stdout] | ______________________^ [INFO] [stdout] 71 | | .gauge("workers") [INFO] [stdout] 72 | | .help("Number of workers") [INFO] [stdout] 73 | | .finish() [INFO] [stdout] 74 | | .expect("Never fails"), [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:75:30 [INFO] [stdout] | [INFO] [stdout] 57 | pub(crate) fn new(mut builder: MetricBuilder) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | worker_restarts: builder [INFO] [stdout] | ______________________________^ [INFO] [stdout] 76 | | .counter("worker_restarts_total") [INFO] [stdout] 77 | | .help("Number of worker restarts") [INFO] [stdout] 78 | | .finish() [INFO] [stdout] 79 | | .expect("Never fails"), [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:80:36 [INFO] [stdout] | [INFO] [stdout] 57 | pub(crate) fn new(mut builder: MetricBuilder) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | task_duration_seconds: builder [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 81 | | .histogram("task_duration_seconds") [INFO] [stdout] 82 | | .help("Execution time of tasks") [INFO] [stdout] 83 | | .bucket(0.001) [INFO] [stdout] ... | [INFO] [stdout] 89 | | .finish() [INFO] [stdout] 90 | | .expect("Never fails"), [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:19:19 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(task: F, ctrl_tx: mpsc::Sender) -> Self [INFO] [stdout] | ------- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | let mut f = Some(task); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Task { [INFO] [stdout] 19 | task: Box::new(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 20 | | let f = f.take().expect("Never fails"); [INFO] [stdout] 21 | | f() [INFO] [stdout] 22 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(task: F, ctrl_tx: mpsc::Sender) -> Self [INFO] [stdout] | ------- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | let mut f = Some(task); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | worker: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:54:43 [INFO] [stdout] | [INFO] [stdout] 54 | for (i, tx) in (0..3).map(|i| (i, tx.clone())) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:77:43 [INFO] [stdout] | [INFO] [stdout] 77 | for (i, tx) in (0..3).map(|i| (i, tx.clone())) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tasque` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tasque` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "740bb3ee09f7774d46a1877b0b769c42623c3f1d489146288a1c42356e1f1f16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "740bb3ee09f7774d46a1877b0b769c42623c3f1d489146288a1c42356e1f1f16", kill_on_drop: false }` [INFO] [stdout] 740bb3ee09f7774d46a1877b0b769c42623c3f1d489146288a1c42356e1f1f16