[INFO] fetching crate taskpile 0.2.0... [INFO] checking taskpile-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate taskpile 0.2.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate taskpile 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate taskpile 0.2.0 [INFO] finished tweaking crates.io crate taskpile 0.2.0 [INFO] tweaked toml for crates.io crate taskpile 0.2.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0139f81cfa18757664c09010f741c518e17bb149f7d9c60f8ea194df511b9274 [INFO] running `Command { std: "docker" "start" "-a" "0139f81cfa18757664c09010f741c518e17bb149f7d9c60f8ea194df511b9274", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0139f81cfa18757664c09010f741c518e17bb149f7d9c60f8ea194df511b9274", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0139f81cfa18757664c09010f741c518e17bb149f7d9c60f8ea194df511b9274", kill_on_drop: false }` [INFO] [stdout] 0139f81cfa18757664c09010f741c518e17bb149f7d9c60f8ea194df511b9274 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 080be854c786abf7d13211f64e3aa7067376b77269d766b909625bbb87b9ffd4 [INFO] running `Command { std: "docker" "start" "-a" "080be854c786abf7d13211f64e3aa7067376b77269d766b909625bbb87b9ffd4", kill_on_drop: false }` [INFO] [stderr] Checking taskpile v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:93:23 [INFO] [stdout] | [INFO] [stdout] 91 | let pile = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | pile.send_event(TaskPileEvent::ThreadStart); [INFO] [stdout] 93 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 94 | | let _sentinel = PanicSentinel(pile.clone()); [INFO] [stdout] 95 | | loop { [INFO] [stdout] 96 | | // use an inner scope so the mutex is dropped once we receive the next task [INFO] [stdout] ... | [INFO] [stdout] 116 | | pile.notify_thread_end(); [INFO] [stdout] 117 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:148:24 [INFO] [stdout] | [INFO] [stdout] 129 | let (task_send, task_recv) = mpsc::channel::(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let (event_send, event_recv) = mpsc::channel::(); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | [INFO] [stdout] 134 | let pile = TaskPileInner { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | task_send: Some(task_send), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `taskpile` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:93:23 [INFO] [stdout] | [INFO] [stdout] 91 | let pile = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | pile.send_event(TaskPileEvent::ThreadStart); [INFO] [stdout] 93 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 94 | | let _sentinel = PanicSentinel(pile.clone()); [INFO] [stdout] 95 | | loop { [INFO] [stdout] 96 | | // use an inner scope so the mutex is dropped once we receive the next task [INFO] [stdout] ... | [INFO] [stdout] 116 | | pile.notify_thread_end(); [INFO] [stdout] 117 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:148:24 [INFO] [stdout] | [INFO] [stdout] 129 | let (task_send, task_recv) = mpsc::channel::(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let (event_send, event_recv) = mpsc::channel::(); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | [INFO] [stdout] 134 | let pile = TaskPileInner { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | task_send: Some(task_send), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `taskpile` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "080be854c786abf7d13211f64e3aa7067376b77269d766b909625bbb87b9ffd4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "080be854c786abf7d13211f64e3aa7067376b77269d766b909625bbb87b9ffd4", kill_on_drop: false }` [INFO] [stdout] 080be854c786abf7d13211f64e3aa7067376b77269d766b909625bbb87b9ffd4