[INFO] fetching crate taskmanager 0.6.2... [INFO] checking taskmanager-0.6.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate taskmanager 0.6.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate taskmanager 0.6.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate taskmanager 0.6.2 [INFO] finished tweaking crates.io crate taskmanager 0.6.2 [INFO] tweaked toml for crates.io crate taskmanager 0.6.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 90 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding io-lifetimes v1.0.11 (latest: v2.0.3) [INFO] [stderr] Adding linux-raw-sys v0.3.8 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding rustix v0.37.27 (latest: v0.38.35) [INFO] [stderr] Adding terminal_size v0.2.6 (latest: v0.3.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 89517c39007965b58a3a6e4010fffaf5b92ebb864c53833ef1af7f7efb30e892 [INFO] running `Command { std: "docker" "start" "-a" "89517c39007965b58a3a6e4010fffaf5b92ebb864c53833ef1af7f7efb30e892", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "89517c39007965b58a3a6e4010fffaf5b92ebb864c53833ef1af7f7efb30e892", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "89517c39007965b58a3a6e4010fffaf5b92ebb864c53833ef1af7f7efb30e892", kill_on_drop: false }` [INFO] [stdout] 89517c39007965b58a3a6e4010fffaf5b92ebb864c53833ef1af7f7efb30e892 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f3a3747339b687b24a37113e29ab04d34512f898d1ebdb2a5c51b852b91c55b7 [INFO] running `Command { std: "docker" "start" "-a" "f3a3747339b687b24a37113e29ab04d34512f898d1ebdb2a5c51b852b91c55b7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking waitgroup v0.1.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking terminal_size v0.2.6 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking loga v0.5.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking taskmanager v0.6.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:87:21 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn sub(&self, id: impl Into) -> TaskManager { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | TaskManager(Arc::new(TaskManagerInner { [INFO] [stdout] | _____________________^ [INFO] [stdout] 88 | | id_prefix: self.prefix_id(id), [INFO] [stdout] 89 | | alive_task_ids: Arc::new(Mutex::new(HashSet::new())), [INFO] [stdout] 90 | | alive: self.0.alive.child_token(), [INFO] [stdout] 91 | | critical: Mutex::new(Some(Vec::new())), [INFO] [stdout] 92 | | wg: Mutex::new(Some(WaitGroup::new())), [INFO] [stdout] 93 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:149:31 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn task(&self, id: impl Into, future: impl Future + Send + 'static) { [INFO] [stdout] | --------------------- ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | self.task_(false, id, async move { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 150 | | future.await; [INFO] [stdout] 151 | | return Ok(()); [INFO] [stdout] 152 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `taskmanager` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:87:21 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn sub(&self, id: impl Into) -> TaskManager { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | TaskManager(Arc::new(TaskManagerInner { [INFO] [stdout] | _____________________^ [INFO] [stdout] 88 | | id_prefix: self.prefix_id(id), [INFO] [stdout] 89 | | alive_task_ids: Arc::new(Mutex::new(HashSet::new())), [INFO] [stdout] 90 | | alive: self.0.alive.child_token(), [INFO] [stdout] 91 | | critical: Mutex::new(Some(Vec::new())), [INFO] [stdout] 92 | | wg: Mutex::new(Some(WaitGroup::new())), [INFO] [stdout] 93 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:149:31 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn task(&self, id: impl Into, future: impl Future + Send + 'static) { [INFO] [stdout] | --------------------- ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | self.task_(false, id, async move { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 150 | | future.await; [INFO] [stdout] 151 | | return Ok(()); [INFO] [stdout] 152 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `taskmanager` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "f3a3747339b687b24a37113e29ab04d34512f898d1ebdb2a5c51b852b91c55b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f3a3747339b687b24a37113e29ab04d34512f898d1ebdb2a5c51b852b91c55b7", kill_on_drop: false }` [INFO] [stdout] f3a3747339b687b24a37113e29ab04d34512f898d1ebdb2a5c51b852b91c55b7