[INFO] fetching crate tari_template_macros 0.7.0... [INFO] checking tari_template_macros-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tari_template_macros 0.7.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate tari_template_macros 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tari_template_macros 0.7.0 [INFO] finished tweaking crates.io crate tari_template_macros 0.7.0 [INFO] tweaked toml for crates.io crate tari_template_macros 0.7.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 17 packages to latest compatible versions [INFO] [stderr] Adding indoc v1.0.9 (latest: v2.0.5) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6aedda1a28db044f2b2dd21aae7d2be54f34397e9d55e9a7ea4514a842ccdef4 [INFO] running `Command { std: "docker" "start" "-a" "6aedda1a28db044f2b2dd21aae7d2be54f34397e9d55e9a7ea4514a842ccdef4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6aedda1a28db044f2b2dd21aae7d2be54f34397e9d55e9a7ea4514a842ccdef4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6aedda1a28db044f2b2dd21aae7d2be54f34397e9d55e9a7ea4514a842ccdef4", kill_on_drop: false }` [INFO] [stdout] 6aedda1a28db044f2b2dd21aae7d2be54f34397e9d55e9a7ea4514a842ccdef4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a02c51ca43adedee4044d01486afe8a6356fa47f53c165eb7780db7f1233c154 [INFO] running `Command { std: "docker" "start" "-a" "a02c51ca43adedee4044d01486afe8a6356fa47f53c165eb7780db7f1233c154", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Compiling indoc v1.0.9 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking syn v1.0.109 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tari_bor v0.7.0 [INFO] [stderr] Checking tari_template_abi v0.7.0 [INFO] [stderr] Checking tari_template_macros v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `statements`, `is_constructor`, and `is_public` are never read [INFO] [stdout] --> src/template/ast.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 227 | pub struct FunctionAst { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 231 | pub statements: Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 232 | pub is_constructor: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 233 | pub is_public: bool, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn template(_attr: TokenStream, item: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | / template::generate_template(proc_macro2::TokenStream::from(item)) [INFO] [stdout] 31 | | .unwrap_or_else(|err| err.to_compile_error()) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn template_non_wasm(_attr: TokenStream, item: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | / template::generate_template_non_wasm(proc_macro2::TokenStream::from(item)) [INFO] [stdout] 40 | | .unwrap_or_else(|err| err.to_compile_error()) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/template/abi.rs:49:37 [INFO] [stdout] | [INFO] [stdout] 47 | .map(|func| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let is_mut = func.is_mut(); [INFO] [stdout] 49 | Ok::<_, syn::Error>(FunctionDef { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 50 | | name: func.name, [INFO] [stdout] 51 | | arguments: func [INFO] [stdout] 52 | | .input_types [INFO] [stdout] ... | [INFO] [stdout] 61 | | is_mut, [INFO] [stdout] 62 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/template/ast.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 56 | let mut module: ItemMod = input.parse()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let mut template_name = None; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let mut has_impl = false; [INFO] [stdout] 67 | let mut uses = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 111 | | template_name: template_name.unwrap(), [INFO] [stdout] 112 | | module_content: module [INFO] [stdout] 113 | | .content [INFO] [stdout] ... | [INFO] [stdout] 116 | | uses, [INFO] [stdout] 117 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/template/dispatcher.rs:166:17 [INFO] [stdout] | [INFO] [stdout] 82 | fn get_function_block(template_ident: &Ident, ast: FunctionAst) -> Expr { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let template_mod_name = format_ident!("{}_template", template_ident); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let mut args: Vec = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let expected_num_args = ast.input_types.len(); [INFO] [stdout] 86 | let mut stmts = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let function_ident = Ident::new(&ast.name, Span::call_site()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | Expr::Block(ExprBlock { [INFO] [stdout] | _________________^ [INFO] [stdout] 167 | | attrs: vec![], [INFO] [stdout] 168 | | label: None, [INFO] [stdout] 169 | | block: Block { [INFO] [stdout] ... | [INFO] [stdout] 174 | | }, [INFO] [stdout] 175 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tari_template_macros` (lib test) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `statements`, `is_constructor`, and `is_public` are never read [INFO] [stdout] --> src/template/ast.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 227 | pub struct FunctionAst { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 231 | pub statements: Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 232 | pub is_constructor: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 233 | pub is_public: bool, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn template(_attr: TokenStream, item: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | / template::generate_template(proc_macro2::TokenStream::from(item)) [INFO] [stdout] 31 | | .unwrap_or_else(|err| err.to_compile_error()) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn template_non_wasm(_attr: TokenStream, item: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | / template::generate_template_non_wasm(proc_macro2::TokenStream::from(item)) [INFO] [stdout] 40 | | .unwrap_or_else(|err| err.to_compile_error()) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/template/abi.rs:49:37 [INFO] [stdout] | [INFO] [stdout] 47 | .map(|func| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let is_mut = func.is_mut(); [INFO] [stdout] 49 | Ok::<_, syn::Error>(FunctionDef { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 50 | | name: func.name, [INFO] [stdout] 51 | | arguments: func [INFO] [stdout] 52 | | .input_types [INFO] [stdout] ... | [INFO] [stdout] 61 | | is_mut, [INFO] [stdout] 62 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/template/ast.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 56 | let mut module: ItemMod = input.parse()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let mut template_name = None; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let mut has_impl = false; [INFO] [stdout] 67 | let mut uses = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 111 | | template_name: template_name.unwrap(), [INFO] [stdout] 112 | | module_content: module [INFO] [stdout] 113 | | .content [INFO] [stdout] ... | [INFO] [stdout] 116 | | uses, [INFO] [stdout] 117 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/template/dispatcher.rs:166:17 [INFO] [stdout] | [INFO] [stdout] 82 | fn get_function_block(template_ident: &Ident, ast: FunctionAst) -> Expr { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let template_mod_name = format_ident!("{}_template", template_ident); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let mut args: Vec = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let expected_num_args = ast.input_types.len(); [INFO] [stdout] 86 | let mut stmts = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let function_ident = Ident::new(&ast.name, Span::call_site()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | Expr::Block(ExprBlock { [INFO] [stdout] | _________________^ [INFO] [stdout] 167 | | attrs: vec![], [INFO] [stdout] 168 | | label: None, [INFO] [stdout] 169 | | block: Block { [INFO] [stdout] ... | [INFO] [stdout] 174 | | }, [INFO] [stdout] 175 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tari_template_macros` (lib) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "a02c51ca43adedee4044d01486afe8a6356fa47f53c165eb7780db7f1233c154", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a02c51ca43adedee4044d01486afe8a6356fa47f53c165eb7780db7f1233c154", kill_on_drop: false }` [INFO] [stdout] a02c51ca43adedee4044d01486afe8a6356fa47f53c165eb7780db7f1233c154