[INFO] fetching crate tari_storage 1.0.0-rc.5... [INFO] checking tari_storage-1.0.0-rc.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tari_storage 1.0.0-rc.5 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate tari_storage 1.0.0-rc.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tari_storage 1.0.0-rc.5 [INFO] finished tweaking crates.io crate tari_storage 1.0.0-rc.5 [INFO] tweaked toml for crates.io crate tari_storage 1.0.0-rc.5 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 60 packages to latest compatible versions [INFO] [stderr] Adding base58-monero v0.3.2 (latest: v2.0.0) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v0.9.1 (latest: v2.6.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding snafu v0.7.5 (latest: v0.8.4) [INFO] [stderr] Adding snafu-derive v0.7.5 (latest: v0.8.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fe5a4c1e369d7bb36042d922f46b6e458cd4d4b016ccc7995a3b65dae08d6592 [INFO] running `Command { std: "docker" "start" "-a" "fe5a4c1e369d7bb36042d922f46b6e458cd4d4b016ccc7995a3b65dae08d6592", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fe5a4c1e369d7bb36042d922f46b6e458cd4d4b016ccc7995a3b65dae08d6592", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe5a4c1e369d7bb36042d922f46b6e458cd4d4b016ccc7995a3b65dae08d6592", kill_on_drop: false }` [INFO] [stdout] fe5a4c1e369d7bb36042d922f46b6e458cd4d4b016ccc7995a3b65dae08d6592 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0bd1da3ee9451400cfc129e7f3d0c189a06ec56f4f4415a4b7f2a3f2694c87c2 [INFO] running `Command { std: "docker" "start" "-a" "0bd1da3ee9451400cfc129e7f3d0c189a06ec56f4f4415a4b7f2a3f2694c87c2", kill_on_drop: false }` [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling winnow v0.6.18 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling borsh v1.5.1 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking supercow v0.1.0 [INFO] [stderr] Checking bitflags v0.9.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking newtype-ops v0.1.4 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Compiling liblmdb-sys v0.2.2 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Compiling toml_edit v0.22.20 [INFO] [stderr] Compiling snafu-derive v0.7.5 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Checking lmdb-zero v0.4.4 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling syn_derive v0.1.8 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Checking snafu v0.7.5 [INFO] [stderr] Compiling borsh-derive v1.5.1 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking base58-monero v0.3.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking tari_storage v1.0.0-rc.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key_val_store/cached_store.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(inner: DS) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Self { [INFO] [stdout] 36 | cache: RwLock::new(HashMap::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key_val_store/cached_store.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 74 | let read_lock = self.cache.read().map_err(|_| KeyValStoreError::PoisonedAccess)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | Ok(read_lock.get(key).cloned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key_val_store/cached_store.rs:103:28 [INFO] [stdout] | [INFO] [stdout] 103 | .map(|(k, v)| (k.clone(), v.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key_val_store/cached_store.rs:103:39 [INFO] [stdout] | [INFO] [stdout] 103 | .map(|(k, v)| (k.clone(), v.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key_val_store/hmap_database.rs:122:35 [INFO] [stdout] | [INFO] [stdout] 122 | .filter_map(|k| match self.get(k) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key_val_store/lmdb_database.rs:83:43 [INFO] [stdout] | [INFO] [stdout] 83 | .filter_map(|k| match access.get::(k) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lmdb_store/store.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 181 | let env = unsafe { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let mut builder = EnvBuilder::new()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let env = builder.open(&path, flags, 0o600)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | let mut databases: HashMap = HashMap::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | Ok(LMDBStore { [INFO] [stdout] | ____________^ [INFO] [stdout] 217 | | path, [INFO] [stdout] 218 | | env_config: self.env_config, [INFO] [stdout] 219 | | env, [INFO] [stdout] 220 | | databases, [INFO] [stdout] 221 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lmdb_store/store.rs:656:12 [INFO] [stdout] | [INFO] [stdout] 651 | pub fn with_read_transaction(&self, f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 652 | where F: FnOnce(LMDBReadTransaction) -> R { [INFO] [stdout] 653 | let txn = ReadTransaction::new(self.env.clone())?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 654 | let access = txn.access(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 655 | let wrapper = LMDBReadTransaction { db: &self.db, access }; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 656 | Ok(f(wrapper)) [INFO] [stdout] | ^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lmdb_store/store.rs:685:12 [INFO] [stdout] | [INFO] [stdout] 683 | let key = bincode::deserialize(key_bytes).map_err(|e| error::Error::ValRejected(e.to_string()))?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 684 | let val = bincode::deserialize(val_bytes).map_err(|e| error::Error::ValRejected(e.to_string()))?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 685 | Ok((key, val)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tari_storage` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "0bd1da3ee9451400cfc129e7f3d0c189a06ec56f4f4415a4b7f2a3f2694c87c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0bd1da3ee9451400cfc129e7f3d0c189a06ec56f4f4415a4b7f2a3f2694c87c2", kill_on_drop: false }` [INFO] [stdout] 0bd1da3ee9451400cfc129e7f3d0c189a06ec56f4f4415a4b7f2a3f2694c87c2