[INFO] fetching crate tari_bulletproofs_plus 0.4.0... [INFO] checking tari_bulletproofs_plus-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tari_bulletproofs_plus 0.4.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate tari_bulletproofs_plus 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-6-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate tari_bulletproofs_plus 0.4.0 [INFO] finished tweaking crates.io crate tari_bulletproofs_plus 0.4.0 [INFO] tweaked toml for crates.io crate tari_bulletproofs_plus 0.4.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 89 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2a327728d77b47f890b716dc1abbf17e12f8c2a4fe479a9d4266080d91b00c50 [INFO] running `Command { std: "docker" "start" "-a" "2a327728d77b47f890b716dc1abbf17e12f8c2a4fe479a9d4266080d91b00c50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2a327728d77b47f890b716dc1abbf17e12f8c2a4fe479a9d4266080d91b00c50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2a327728d77b47f890b716dc1abbf17e12f8c2a4fe479a9d4266080d91b00c50", kill_on_drop: false }` [INFO] [stdout] 2a327728d77b47f890b716dc1abbf17e12f8c2a4fe479a9d4266080d91b00c50 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d370ccdb39520ede1eadf35888a999e04ec5524b6da257c7a6bf915bd8a231c0 [INFO] running `Command { std: "docker" "start" "-a" "d370ccdb39520ede1eadf35888a999e04ec5524b6da257c7a6bf915bd8a231c0", kill_on_drop: false }` [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking critical-section v1.1.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking merlin v3.0.0 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Compiling thiserror-impl-no-std v2.0.2 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking thiserror-no-std v2.0.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking tari_bulletproofs_plus v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generators/bulletproof_gens.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 84 | let mut g_vec: Vec> = (0..party_capacity).map(|_| Vec::new()).collect(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let mut h_vec: Vec> = (0..party_capacity).map(|_| Vec::new()).collect(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let precomp = Arc::new(P::Precomputation::new(iter_interleaved)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | [INFO] [stdout] 105 | Ok(BulletproofGens { [INFO] [stdout] | ____________^ [INFO] [stdout] 106 | | gens_capacity, [INFO] [stdout] 107 | | party_capacity, [INFO] [stdout] 108 | | g_vec, [INFO] [stdout] 109 | | h_vec, [INFO] [stdout] 110 | | precomp, [INFO] [stdout] 111 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_parameters.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 35 | pc_gens: PedersenGens

, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 55 | | bp_gens: BulletproofGens::new(bit_length, max_aggregation_factor)?, [INFO] [stdout] 56 | | pc_gens, [INFO] [stdout] 57 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_statement.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 37 | generators: RangeParameters

, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | commitments: Vec

, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | generators, [INFO] [stdout] 68 | | commitments, [INFO] [stdout] 69 | | commitments_compressed, [INFO] [stdout] 70 | | minimum_value_promises, [INFO] [stdout] 71 | | seed_nonce, [INFO] [stdout] 72 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_witness.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn init(openings: Vec) -> Result { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 37 | | openings, [INFO] [stdout] 38 | | extension_degree: extension_degree.try_into()?, [INFO] [stdout] 39 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transcripts.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 91 | let bytes = if let Some(witness) = witness { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let mut witness_bytes = Zeroizing::new(Vec::::with_capacity(size)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let rng = Self::build_rng(transcript, bytes.as_ref(), external_rng); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | [INFO] [stdout] 114 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 115 | | transcript, [INFO] [stdout] 116 | | bytes, [INFO] [stdout] 117 | | transcript_rng: rng, [INFO] [stdout] 118 | | external_rng, [INFO] [stdout] 119 | | _phantom: PhantomData, [INFO] [stdout] 120 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tari_bulletproofs_plus` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d370ccdb39520ede1eadf35888a999e04ec5524b6da257c7a6bf915bd8a231c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d370ccdb39520ede1eadf35888a999e04ec5524b6da257c7a6bf915bd8a231c0", kill_on_drop: false }` [INFO] [stdout] d370ccdb39520ede1eadf35888a999e04ec5524b6da257c7a6bf915bd8a231c0