[INFO] fetching crate tari_broadcast_channel 0.3.0... [INFO] checking tari_broadcast_channel-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tari_broadcast_channel 0.3.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate tari_broadcast_channel 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-5-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate tari_broadcast_channel 0.3.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate tari_broadcast_channel 0.3.0 [INFO] tweaked toml for crates.io crate tari_broadcast_channel 0.3.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate tari_broadcast_channel 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 47d759b27c6451ee3d86036b7195c501e24c2fe1b752867f7c49910d505469df [INFO] running `Command { std: "docker" "start" "-a" "47d759b27c6451ee3d86036b7195c501e24c2fe1b752867f7c49910d505469df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "47d759b27c6451ee3d86036b7195c501e24c2fe1b752867f7c49910d505469df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "47d759b27c6451ee3d86036b7195c501e24c2fe1b752867f7c49910d505469df", kill_on_drop: false }` [INFO] [stdout] 47d759b27c6451ee3d86036b7195c501e24c2fe1b752867f7c49910d505469df [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ac44e04d824aa24979cc786609e7714e11542bdd4bdf1343cf6b5811ca43e4f1 [INFO] running `Command { std: "docker" "start" "-a" "ac44e04d824aa24979cc786609e7714e11542bdd4bdf1343cf6b5811ca43e4f1", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.9 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling syn v1.0.16 [INFO] [stderr] Compiling libc v0.2.67 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling proc-macro-nested v0.1.3 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking futures-sink v0.3.4 [INFO] [stderr] Checking futures-core v0.3.4 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking futures-io v0.3.4 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Checking futures-task v0.3.4 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking pin-utils v0.1.0-alpha.4 [INFO] [stderr] Checking futures-channel v0.3.4 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking regex-syntax v0.6.15 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Checking arc-swap v0.4.4 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking oorandom v11.1.0 [INFO] [stderr] Checking regex-automata v0.1.8 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking criterion-plot v0.4.1 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking regex v1.3.4 [INFO] [stderr] Checking tokio v1.19.2 [INFO] [stderr] Checking plotters v0.2.12 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking bstr v0.2.11 [INFO] [stderr] Checking serde_json v1.0.48 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Checking tinytemplate v1.0.3 [INFO] [stderr] Compiling proc-macro-hack v0.5.11 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Compiling futures-macro v0.3.4 [INFO] [stderr] Checking futures-util v0.3.4 [INFO] [stderr] Checking criterion v0.3.1 [INFO] [stderr] Checking futures-executor v0.3.4 [INFO] [stderr] Checking futures v0.3.4 [INFO] [stderr] Checking tari_broadcast_channel v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `RecvError` and `RecvTimeoutError` [INFO] [stdout] --> src/channel.rs:2:27 [INFO] [stdout] | [INFO] [stdout] 2 | pub use std::sync::mpsc::{RecvError, RecvTimeoutError, SendError, TryRecvError}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_channel.rs:26:6 [INFO] [stdout] | [INFO] [stdout] 17 | let (sender, receiver) = raw_bounded(size, receiver_id); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let (waker, sleeper) = alarm(); [INFO] [stdout] | ----- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | (Publisher { sender, waker }, Subscriber { receiver, sleeper }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tari_broadcast_channel` (lib) due to 9 previous errors; 1 warning emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_channel.rs:26:35 [INFO] [stdout] | [INFO] [stdout] 17 | let (sender, receiver) = raw_bounded(size, receiver_id); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let (waker, sleeper) = alarm(); [INFO] [stdout] | ----- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | (Publisher { sender, waker }, Subscriber { receiver, sleeper }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_channel.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 42 | fn start_send(mut self: Pin<&mut Self>, item: T) -> Result<(), Self::Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | self.waker.collect_new_wakers(); [INFO] [stdout] 44 | self.sender.broadcast(item).map(|_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_channel.rs:193:21 [INFO] [stdout] | [INFO] [stdout] 185 | let waker = Arc::new(AtomicWaker::new()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | sender: self.sender.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_channel.rs:203:6 [INFO] [stdout] | [INFO] [stdout] 200 | let (sender, receiver) = mpsc::unbounded(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | let waker = Arc::new(AtomicWaker::new()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let wakers = vec![Arc::clone(&waker)]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | (Waker { wakers, receiver }, Sleeper { waker, sender }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_channel.rs:203:34 [INFO] [stdout] | [INFO] [stdout] 200 | let (sender, receiver) = mpsc::unbounded(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | let waker = Arc::new(AtomicWaker::new()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let wakers = vec![Arc::clone(&waker)]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | (Waker { wakers, receiver }, Sleeper { waker, sender }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 20 | let mut buffer = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | buffer.resize(size, ArcSwapOption::new(None)); [INFO] [stdout] 22 | let buffer = Arc::new(buffer); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let wi = Arc::new(AtomicCounter::new(0)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | [INFO] [stdout] 25 | let sub_count = Arc::new(AtomicCounter::new(1)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let is_sender_available = Arc::new(AtomicBool::new(true)); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | / Sender { [INFO] [stdout] 30 | | buffer: buffer.clone(), [INFO] [stdout] 31 | | size, [INFO] [stdout] 32 | | wi: wi.clone(), [INFO] [stdout] 33 | | sub_count: sub_count.clone(), [INFO] [stdout] 34 | | is_available: is_sender_available.clone(), [INFO] [stdout] 35 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 20 | let mut buffer = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | buffer.resize(size, ArcSwapOption::new(None)); [INFO] [stdout] 22 | let buffer = Arc::new(buffer); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let wi = Arc::new(AtomicCounter::new(0)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | [INFO] [stdout] 25 | let sub_count = Arc::new(AtomicCounter::new(1)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let is_sender_available = Arc::new(AtomicBool::new(true)); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | / Receiver { [INFO] [stdout] 37 | | buffer, [INFO] [stdout] 38 | | size, [INFO] [stdout] 39 | | wi, [INFO] [stdout] ... | [INFO] [stdout] 45 | | id: std::cmp::max(receiver_id, 1) * ID_MULTIPLIER, [INFO] [stdout] 46 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "ac44e04d824aa24979cc786609e7714e11542bdd4bdf1343cf6b5811ca43e4f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac44e04d824aa24979cc786609e7714e11542bdd4bdf1343cf6b5811ca43e4f1", kill_on_drop: false }` [INFO] [stdout] ac44e04d824aa24979cc786609e7714e11542bdd4bdf1343cf6b5811ca43e4f1