[INFO] fetching crate target-spec 3.2.1... [INFO] checking target-spec-3.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate target-spec 3.2.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate target-spec 3.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate target-spec 3.2.1 [INFO] finished tweaking crates.io crate target-spec 3.2.1 [INFO] tweaked toml for crates.io crate target-spec 3.2.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 64 packages to latest compatible versions [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 46b18a077557275c856cf157a2fddb9f92f426e18879049256c2b55e85fb9bff [INFO] running `Command { std: "docker" "start" "-a" "46b18a077557275c856cf157a2fddb9f92f426e18879049256c2b55e85fb9bff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "46b18a077557275c856cf157a2fddb9f92f426e18879049256c2b55e85fb9bff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "46b18a077557275c856cf157a2fddb9f92f426e18879049256c2b55e85fb9bff", kill_on_drop: false }` [INFO] [stdout] 46b18a077557275c856cf157a2fddb9f92f426e18879049256c2b55e85fb9bff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4e228c825fdede6e4bd95ee216d6a369b8c8c5e6f2c6980cb84234fb2d8ffcac [INFO] running `Command { std: "docker" "start" "-a" "4e228c825fdede6e4bd95ee216d6a369b8c8c5e6f2c6980cb84234fb2d8ffcac", kill_on_drop: false }` [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Compiling guppy-workspace-hack v0.1.0 [INFO] [stderr] Compiling target-spec v3.2.1 (/opt/rustwide/workdir) [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling test-case-core v3.3.1 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking rustc_version v0.4.1 [INFO] [stderr] Checking cfg-expr v0.16.0 [INFO] [stderr] Compiling test-case-macros v3.3.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 44 | triple_str: impl Into>, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let triple = Triple::new(triple_str.into()).map_err(Error::UnknownPlatformTriple)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(Self::from_triple(triple, target_features)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 56 | triple_str: impl Into>, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let triple = Triple::new_strict(triple_str.into()).map_err(Error::UnknownPlatformTriple)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Ok(Self::from_triple(triple, target_features)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 73 | let triple = Triple::new(CURRENT_TARGET).map_err(Error::UnknownPlatformTriple)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let target_features = TargetFeatures::features(CURRENT_TARGET_FEATURES.iter().copied()); [INFO] [stdout] 75 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 76 | | triple, [INFO] [stdout] 77 | | target_features, [INFO] [stdout] 78 | | flags: BTreeSet::new(), [INFO] [stdout] 79 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform.rs:225:34 [INFO] [stdout] | [INFO] [stdout] 224 | pub fn features(features: impl IntoIterator>>) -> Self { [INFO] [stdout] | ---------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | TargetFeatures::Features(features.into_iter().map(|s| s.into()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec.rs:183:12 [INFO] [stdout] | [INFO] [stdout] 182 | let expr = Expression::parse(input).map_err(|err| ExpressionParseError::new(input, err))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 184 | | inner: Arc::new(expr), [INFO] [stdout] 185 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/triple.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn new(triple_str: impl Into>) -> Result { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let inner = TripleInner::new(triple_str.into())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Ok(Self { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/triple.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn new_strict(triple_str: impl Into>) -> Result { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let inner = TripleInner::new_strict(triple_str.into())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | Ok(Self { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/triple.rs:191:12 [INFO] [stdout] | [INFO] [stdout] 190 | let inner = TripleInner::from_borrowed_str(triple_str)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | Ok(Self { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `target-spec` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "4e228c825fdede6e4bd95ee216d6a369b8c8c5e6f2c6980cb84234fb2d8ffcac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e228c825fdede6e4bd95ee216d6a369b8c8c5e6f2c6980cb84234fb2d8ffcac", kill_on_drop: false }` [INFO] [stdout] 4e228c825fdede6e4bd95ee216d6a369b8c8c5e6f2c6980cb84234fb2d8ffcac