[INFO] fetching crate tanton 1.0.0... [INFO] checking tanton-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tanton 1.0.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate tanton 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tanton 1.0.0 [INFO] finished tweaking crates.io crate tanton 1.0.0 [INFO] tweaked toml for crates.io crate tanton 1.0.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 70 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cast v0.2.7 (latest: v0.3.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding criterion v0.2.11 (latest: v0.5.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.8.2 (latest: v0.13.0) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_xoshiro v0.1.0 (latest: v0.6.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2e00e960da8497203e40509d3180e96575366a0cfb5575c0b22e9c015a63a3fb [INFO] running `Command { std: "docker" "start" "-a" "2e00e960da8497203e40509d3180e96575366a0cfb5575c0b22e9c015a63a3fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2e00e960da8497203e40509d3180e96575366a0cfb5575c0b22e9c015a63a3fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e00e960da8497203e40509d3180e96575366a0cfb5575c0b22e9c015a63a3fb", kill_on_drop: false }` [INFO] [stdout] 2e00e960da8497203e40509d3180e96575366a0cfb5575c0b22e9c015a63a3fb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 716d682907b8403ffa219884a26d6c3b772f5017193dd6b146f2e5f22307aac3 [INFO] running `Command { std: "docker" "start" "-a" "716d682907b8403ffa219884a26d6c3b772f5017193dd6b146f2e5f22307aac3", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking mucow v0.1.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking criterion v0.2.11 [INFO] [stderr] Checking tanton v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `dev` [INFO] [stdout] --> src/lib.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | #![cfg_attr(feature = "dev", allow(unstable_features))] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default` and `nightly` [INFO] [stdout] = help: consider adding `dev` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `128` [INFO] [stdout] --> src/core/move_list.rs:66:7 [INFO] [stdout] | [INFO] [stdout] 66 | #[cfg(target_pointer_width = "128")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_pointer_width` are: `16`, `32`, and `64` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `8` [INFO] [stdout] --> src/core/move_list.rs:72:40 [INFO] [stdout] | [INFO] [stdout] 72 | #[cfg(any(target_pointer_width = "16", target_pointer_width = "8",))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_pointer_width` are: `16`, `32`, and `64` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around const expression [INFO] [stdout] --> src/helper/psqt.rs:5:24 [INFO] [stdout] | [INFO] [stdout] 5 | const BONUS: [[[Score; (FILE_CNT / 2)]; RANK_CNT]; PIECE_TYPE_CNT] = [ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 5 - const BONUS: [[[Score; (FILE_CNT / 2)]; RANK_CNT]; PIECE_TYPE_CNT] = [ [INFO] [stdout] 5 + const BONUS: [[[Score; FILE_CNT / 2]; RANK_CNT]; PIECE_TYPE_CNT] = [ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bots/mod.rs:68:43 [INFO] [stdout] | [INFO] [stdout] 65 | fn best_move(board: Board, depth: u16) -> BitMove { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | alphabeta::alpha_beta_search(&mut board.shallow_clone(), alpha, beta, depth).bit_move [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bots/mod.rs:78:62 [INFO] [stdout] | [INFO] [stdout] 77 | fn best_move(board: Board, depth: u16) -> BitMove { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | iterative_parallel_mvv_lva::iterative_deepening(&mut board.shallow_clone(), depth) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bots/mod.rs:90:33 [INFO] [stdout] | [INFO] [stdout] 87 | fn best_move(board: Board, depth: u16) -> BitMove { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | jamboree::jamboree(&mut board.shallow_clone(), alpha, beta, depth, 2).bit_move [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bots/mod.rs:100:31 [INFO] [stdout] | [INFO] [stdout] 99 | fn best_move(board: Board, depth: u16) -> BitMove { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | minimax::minimax(&mut board.shallow_clone(), depth).bit_move [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bots/mod.rs:110:49 [INFO] [stdout] | [INFO] [stdout] 109 | fn best_move(board: Board, depth: u16) -> BitMove { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | parallel_minimax::parallel_minimax(&mut board.shallow_clone(), depth).bit_move [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bots/parallel_minimax.rs:24:6 [INFO] [stdout] | [INFO] [stdout] 23 | let board_wr: MuCow = MuCow::Borrowed(board); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | *moves [INFO] [stdout] | ______^ [INFO] [stdout] 25 | | .as_mut_slice() [INFO] [stdout] 26 | | .par_iter_mut() [INFO] [stdout] 27 | | .map_with(board_wr, |b: &mut MuCow, m: &mut ScoringMove| { [INFO] [stdout] ... | [INFO] [stdout] 31 | | m [INFO] [stdout] 32 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[PreSMagic; 64]` does not permit being left uninitialized [INFO] [stdout] --> src/helper/magic.rs:109:36 [INFO] [stdout] | [INFO] [stdout] 109 | let arr: [PreSMagic; 64] = mem::MaybeUninit::uninit().assume_init(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] note: integers must be initialized (in this struct field) [INFO] [stdout] --> src/helper/magic.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | start: usize, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tools/tanton_arc.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(data: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | UniqueArc(Arc::new(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tanton` (lib) due to 8 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "716d682907b8403ffa219884a26d6c3b772f5017193dd6b146f2e5f22307aac3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "716d682907b8403ffa219884a26d6c3b772f5017193dd6b146f2e5f22307aac3", kill_on_drop: false }` [INFO] [stdout] 716d682907b8403ffa219884a26d6c3b772f5017193dd6b146f2e5f22307aac3