[INFO] fetching crate tange-collection 0.1.2... [INFO] checking tange-collection-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tange-collection 0.1.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate tange-collection 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tange-collection 0.1.2 [INFO] finished tweaking crates.io crate tange-collection 0.1.2 [INFO] tweaked toml for crates.io crate tange-collection 0.1.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 29 packages to latest compatible versions [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding indexmap v0.4.1 (latest: v2.5.0) [INFO] [stderr] Adding priority-queue v0.5.4 (latest: v2.1.0) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding snap v0.2.5 (latest: v1.1.1) [INFO] [stderr] Adding uuid v0.6.5 (latest: v1.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6fd409d4cae1ce53b548dfe7aff4fc449ce8eb60ceb2a42b96338d03cfa78dbc [INFO] running `Command { std: "docker" "start" "-a" "6fd409d4cae1ce53b548dfe7aff4fc449ce8eb60ceb2a42b96338d03cfa78dbc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6fd409d4cae1ce53b548dfe7aff4fc449ce8eb60ceb2a42b96338d03cfa78dbc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6fd409d4cae1ce53b548dfe7aff4fc449ce8eb60ceb2a42b96338d03cfa78dbc", kill_on_drop: false }` [INFO] [stdout] 6fd409d4cae1ce53b548dfe7aff4fc449ce8eb60ceb2a42b96338d03cfa78dbc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 577e29b839e176df2a4f9120a13c3f0bf0ff0ed260a5a0f473ac6a7c420be55b [INFO] running `Command { std: "docker" "start" "-a" "577e29b839e176df2a4f9120a13c3f0bf0ff0ed260a5a0f473ac6a7c420be55b", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking indexmap v0.4.1 [INFO] [stderr] Checking jobpool v0.3.8 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking snap v0.2.5 [INFO] [stderr] Checking priority-queue v0.5.4 [INFO] [stderr] Checking tange v0.1.1 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking tange-collection v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/collection/mod.rs:18:52 [INFO] [stdout] | [INFO] [stdout] 18 | F: 'static + Sync + Send + Clone + Fn(&A, &mut FnMut(B) -> ()), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 18 | F: 'static + Sync + Send + Clone + Fn(&A, &mut dyn FnMut(B) -> ()), [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/collection/memory.rs:169:56 [INFO] [stdout] | [INFO] [stdout] 169 | F: 'static + Sync + Send + Clone + Fn(&A, &mut FnMut(B) -> ()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 169 | F: 'static + Sync + Send + Clone + Fn(&A, &mut dyn FnMut(B) -> ()) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/collection/memory.rs:197:56 [INFO] [stdout] | [INFO] [stdout] 197 | F: 'static + Sync + Send + Clone + Fn(&A, &mut FnMut(B) -> ()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 197 | F: 'static + Sync + Send + Clone + Fn(&A, &mut dyn FnMut(B) -> ()) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/collection/mod.rs:18:52 [INFO] [stdout] | [INFO] [stdout] 18 | F: 'static + Sync + Send + Clone + Fn(&A, &mut FnMut(B) -> ()), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 18 | F: 'static + Sync + Send + Clone + Fn(&A, &mut dyn FnMut(B) -> ()), [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/collection/memory.rs:169:56 [INFO] [stdout] | [INFO] [stdout] 169 | F: 'static + Sync + Send + Clone + Fn(&A, &mut FnMut(B) -> ()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 169 | F: 'static + Sync + Send + Clone + Fn(&A, &mut dyn FnMut(B) -> ()) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/collection/memory.rs:197:56 [INFO] [stdout] | [INFO] [stdout] 197 | F: 'static + Sync + Send + Clone + Fn(&A, &mut FnMut(B) -> ()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 197 | F: 'static + Sync + Send + Clone + Fn(&A, &mut dyn FnMut(B) -> ()) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/collection/disk.rs:199:56 [INFO] [stdout] | [INFO] [stdout] 199 | F: 'static + Sync + Send + Clone + Fn(&A, &mut FnMut(B) -> ()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 199 | F: 'static + Sync + Send + Clone + Fn(&A, &mut dyn FnMut(B) -> ()) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/collection/disk.rs:199:56 [INFO] [stdout] | [INFO] [stdout] 199 | F: 'static + Sync + Send + Clone + Fn(&A, &mut FnMut(B) -> ()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 199 | F: 'static + Sync + Send + Clone + Fn(&A, &mut dyn FnMut(B) -> ()) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 17 | let mut dfs = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Ok(MemoryCollection::from_defs(batch_apply(&dfs, read))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interfaces.rs:208:18 [INFO] [stdout] | [INFO] [stdout] 207 | fn finish(self) -> Self::Out { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | Arc::new(FileStore { [INFO] [stdout] | __________________^ [INFO] [stdout] 209 | | root_path: self.root_path.clone(), [INFO] [stdout] 210 | | name: Some(self.name), [INFO] [stdout] 211 | | pd: PhantomData [INFO] [stdout] 212 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/mod.rs:22:24 [INFO] [stdout] | [INFO] [stdout] 20 | >(defs: &[Deferred], acc: Acc, f: F) -> Vec>::VW as ValueWriter>::Out>> { [INFO] [stdout] | -------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | batch_apply(&defs, move |_idx, vs| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 23 | | let mut out = acc.writer(); [INFO] [stdout] 24 | | for v in vs.stream().into_iter() { [INFO] [stdout] 25 | | f(&v, &mut |r| out.add(r)); [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | out.finish() [INFO] [stdout] 28 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/memory.rs:106:19 [INFO] [stdout] | [INFO] [stdout] 105 | >(&self, f: F) -> MemoryCollection { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | self.emit(move |x, emitter| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 107 | | emitter(f(x)) [INFO] [stdout] 108 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/memory.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 105 | >(&self, f: F) -> MemoryCollection { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | self.emit(move |x, emitter| { [INFO] [stdout] 107 | emitter(f(x)) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/memory.rs:127:19 [INFO] [stdout] | [INFO] [stdout] 126 | >(&self, f: F) -> MemoryCollection { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | self.emit(move |x, emitter| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 128 | | if f(x) { [INFO] [stdout] 129 | | emitter(x.clone()) [INFO] [stdout] 130 | | } [INFO] [stdout] 131 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/memory.rs:288:53 [INFO] [stdout] | [INFO] [stdout] 288 | let groups = results.into_iter().map(|part| concat(&part).unwrap()).collect(); [INFO] [stdout] | ---- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/memory.rs:356:37 [INFO] [stdout] | [INFO] [stdout] 350 | key1: KF1, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 356 | let p1 = self.map(move |x| (key1(x), x.clone())) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/memory.rs:356:46 [INFO] [stdout] | [INFO] [stdout] 350 | key1: KF1, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 356 | let p1 = self.map(move |x| (key1(x), x.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/memory.rs:358:38 [INFO] [stdout] | [INFO] [stdout] 351 | key2: KF2, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | let p2 = other.map(move |x| (key2(x), x.clone())) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/memory.rs:358:47 [INFO] [stdout] | [INFO] [stdout] 351 | key2: KF2, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | let p2 = other.map(move |x| (key2(x), x.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn from_vec(path: String, vec: Vec) -> DiskCollection { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | MemoryCollection::from_vec(vec).to_disk(path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:63:27 [INFO] [stdout] | [INFO] [stdout] 61 | let acc = Arc::new(FileStore::empty(shared.clone())); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let defs = batch_apply(&mc, move |_idx, vs| { [INFO] [stdout] 63 | acc.write_vec(vs.clone()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:70:32 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn from_stores(path: String, fs: Vec>>>) -> DiskCollection { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | DiskCollection { path: Arc::new(path), partitions: fs } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:92:32 [INFO] [stdout] | [INFO] [stdout] 91 | fn from_defs(&self, defs: Vec>>>) -> DiskCollection { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | DiskCollection { path: self.path.clone(), partitions: defs } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:134:19 [INFO] [stdout] | [INFO] [stdout] 133 | >(&self, f: F) -> DiskCollection { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | self.emit(move |x, emitter| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 135 | | emitter(f(x)) [INFO] [stdout] 136 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:135:21 [INFO] [stdout] | [INFO] [stdout] 133 | >(&self, f: F) -> DiskCollection { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | self.emit(move |x, emitter| { [INFO] [stdout] 135 | emitter(f(x)) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:155:19 [INFO] [stdout] | [INFO] [stdout] 154 | >(&self, f: F) -> DiskCollection { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | self.emit(move |x, emitter| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 156 | | if f(x) { [INFO] [stdout] 157 | | emitter(x.clone()) [INFO] [stdout] 158 | | } [INFO] [stdout] 159 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:294:53 [INFO] [stdout] | [INFO] [stdout] 294 | let groups = results.into_iter().map(|part| concat(&part).unwrap()).collect(); [INFO] [stdout] | ---- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:365:37 [INFO] [stdout] | [INFO] [stdout] 359 | key1: KF1, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 365 | let p1 = self.map(move |x| (key1(x), x.clone())) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:365:46 [INFO] [stdout] | [INFO] [stdout] 359 | key1: KF1, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 365 | let p1 = self.map(move |x| (key1(x), x.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:367:38 [INFO] [stdout] | [INFO] [stdout] 360 | key2: KF2, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 367 | let p2 = other.map(move |x| (key2(x), x.clone())) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:367:47 [INFO] [stdout] | [INFO] [stdout] 360 | key2: KF2, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 367 | let p2 = other.map(move |x| (key2(x), x.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/partitioned.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 24 | key: F, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | default: D, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | binop: O, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | map: M [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | ) -> Vec> { [INFO] [stdout] 29 | batch_apply(defs, move |_idx, vs| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 30 | | let mut reducer = HashMap::new(); [INFO] [stdout] 31 | | for v in vs.stream().into_iter() { [INFO] [stdout] 32 | | let k = key(&v); [INFO] [stdout] ... | [INFO] [stdout] 36 | | map(reducer) [INFO] [stdout] 37 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/partitioned.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 47 | hash_function: F [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let mut parts: Vec<_> = (0..partitions).map(|_| vs.writer()).collect(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | parts.into_iter().map(|x| x.finish()).collect::>() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/partitioned.rs:133:29 [INFO] [stdout] | [INFO] [stdout] 130 | let am = acc2.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | let concat: Vec<_> = chunks.into_iter().map(move |chunk| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | let am = am.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | batch_apply(&chunk, move |_idx, vs| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 134 | | let mut hm = HashMap::new(); [INFO] [stdout] 135 | | for (k, v) in vs.stream() { [INFO] [stdout] 136 | | hm.insert(k, v); [INFO] [stdout] ... | [INFO] [stdout] 140 | | out.finish() [INFO] [stdout] 141 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/partitioned.rs:187:34 [INFO] [stdout] | [INFO] [stdout] 184 | key: F [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | split_by_key(defs, n_chunks, move |_idx, v| { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 188 | | let k = key(v); [INFO] [stdout] 189 | | let mut hasher = DefaultHasher::new(); [INFO] [stdout] 190 | | k.hash(&mut hasher); [INFO] [stdout] 191 | | hasher.finish() as usize [INFO] [stdout] 192 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/partitioned.rs:231:17 [INFO] [stdout] | [INFO] [stdout] 227 | acc: Acc, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | joiner: J [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | d1.join(d2, move |left, right| { [INFO] [stdout] | _________________^ [INFO] [stdout] 232 | | // Slurp up left into a hashmap [INFO] [stdout] 233 | | let mut hm = HashMap::new(); [INFO] [stdout] 234 | | for (k, lv) in left.stream() { [INFO] [stdout] ... | [INFO] [stdout] 246 | | ret.finish() [INFO] [stdout] 247 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 28 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tange-collection` (lib) due to 29 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 17 | let mut dfs = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Ok(MemoryCollection::from_defs(batch_apply(&dfs, read))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interfaces.rs:208:18 [INFO] [stdout] | [INFO] [stdout] 207 | fn finish(self) -> Self::Out { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | Arc::new(FileStore { [INFO] [stdout] | __________________^ [INFO] [stdout] 209 | | root_path: self.root_path.clone(), [INFO] [stdout] 210 | | name: Some(self.name), [INFO] [stdout] 211 | | pd: PhantomData [INFO] [stdout] 212 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/mod.rs:22:24 [INFO] [stdout] | [INFO] [stdout] 20 | >(defs: &[Deferred], acc: Acc, f: F) -> Vec>::VW as ValueWriter>::Out>> { [INFO] [stdout] | -------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | batch_apply(&defs, move |_idx, vs| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 23 | | let mut out = acc.writer(); [INFO] [stdout] 24 | | for v in vs.stream().into_iter() { [INFO] [stdout] 25 | | f(&v, &mut |r| out.add(r)); [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | out.finish() [INFO] [stdout] 28 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/memory.rs:106:19 [INFO] [stdout] | [INFO] [stdout] 105 | >(&self, f: F) -> MemoryCollection { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | self.emit(move |x, emitter| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 107 | | emitter(f(x)) [INFO] [stdout] 108 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/memory.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 105 | >(&self, f: F) -> MemoryCollection { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | self.emit(move |x, emitter| { [INFO] [stdout] 107 | emitter(f(x)) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/memory.rs:127:19 [INFO] [stdout] | [INFO] [stdout] 126 | >(&self, f: F) -> MemoryCollection { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | self.emit(move |x, emitter| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 128 | | if f(x) { [INFO] [stdout] 129 | | emitter(x.clone()) [INFO] [stdout] 130 | | } [INFO] [stdout] 131 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/memory.rs:288:53 [INFO] [stdout] | [INFO] [stdout] 288 | let groups = results.into_iter().map(|part| concat(&part).unwrap()).collect(); [INFO] [stdout] | ---- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/memory.rs:356:37 [INFO] [stdout] | [INFO] [stdout] 350 | key1: KF1, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 356 | let p1 = self.map(move |x| (key1(x), x.clone())) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/memory.rs:356:46 [INFO] [stdout] | [INFO] [stdout] 350 | key1: KF1, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 356 | let p1 = self.map(move |x| (key1(x), x.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/memory.rs:358:38 [INFO] [stdout] | [INFO] [stdout] 351 | key2: KF2, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | let p2 = other.map(move |x| (key2(x), x.clone())) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/memory.rs:358:47 [INFO] [stdout] | [INFO] [stdout] 351 | key2: KF2, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | let p2 = other.map(move |x| (key2(x), x.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn from_vec(path: String, vec: Vec) -> DiskCollection { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | MemoryCollection::from_vec(vec).to_disk(path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:63:27 [INFO] [stdout] | [INFO] [stdout] 61 | let acc = Arc::new(FileStore::empty(shared.clone())); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let defs = batch_apply(&mc, move |_idx, vs| { [INFO] [stdout] 63 | acc.write_vec(vs.clone()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:70:32 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn from_stores(path: String, fs: Vec>>>) -> DiskCollection { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | DiskCollection { path: Arc::new(path), partitions: fs } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:92:32 [INFO] [stdout] | [INFO] [stdout] 91 | fn from_defs(&self, defs: Vec>>>) -> DiskCollection { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | DiskCollection { path: self.path.clone(), partitions: defs } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:134:19 [INFO] [stdout] | [INFO] [stdout] 133 | >(&self, f: F) -> DiskCollection { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | self.emit(move |x, emitter| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 135 | | emitter(f(x)) [INFO] [stdout] 136 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:135:21 [INFO] [stdout] | [INFO] [stdout] 133 | >(&self, f: F) -> DiskCollection { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | self.emit(move |x, emitter| { [INFO] [stdout] 135 | emitter(f(x)) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:155:19 [INFO] [stdout] | [INFO] [stdout] 154 | >(&self, f: F) -> DiskCollection { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | self.emit(move |x, emitter| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 156 | | if f(x) { [INFO] [stdout] 157 | | emitter(x.clone()) [INFO] [stdout] 158 | | } [INFO] [stdout] 159 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:294:53 [INFO] [stdout] | [INFO] [stdout] 294 | let groups = results.into_iter().map(|part| concat(&part).unwrap()).collect(); [INFO] [stdout] | ---- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:365:37 [INFO] [stdout] | [INFO] [stdout] 359 | key1: KF1, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 365 | let p1 = self.map(move |x| (key1(x), x.clone())) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:365:46 [INFO] [stdout] | [INFO] [stdout] 359 | key1: KF1, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 365 | let p1 = self.map(move |x| (key1(x), x.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:367:38 [INFO] [stdout] | [INFO] [stdout] 360 | key2: KF2, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 367 | let p2 = other.map(move |x| (key2(x), x.clone())) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/disk.rs:367:47 [INFO] [stdout] | [INFO] [stdout] 360 | key2: KF2, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 367 | let p2 = other.map(move |x| (key2(x), x.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/partitioned.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 24 | key: F, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | default: D, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | binop: O, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | map: M [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | ) -> Vec> { [INFO] [stdout] 29 | batch_apply(defs, move |_idx, vs| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 30 | | let mut reducer = HashMap::new(); [INFO] [stdout] 31 | | for v in vs.stream().into_iter() { [INFO] [stdout] 32 | | let k = key(&v); [INFO] [stdout] ... | [INFO] [stdout] 36 | | map(reducer) [INFO] [stdout] 37 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/partitioned.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 47 | hash_function: F [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let mut parts: Vec<_> = (0..partitions).map(|_| vs.writer()).collect(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | parts.into_iter().map(|x| x.finish()).collect::>() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/partitioned.rs:133:29 [INFO] [stdout] | [INFO] [stdout] 130 | let am = acc2.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | let concat: Vec<_> = chunks.into_iter().map(move |chunk| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | let am = am.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | batch_apply(&chunk, move |_idx, vs| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 134 | | let mut hm = HashMap::new(); [INFO] [stdout] 135 | | for (k, v) in vs.stream() { [INFO] [stdout] 136 | | hm.insert(k, v); [INFO] [stdout] ... | [INFO] [stdout] 140 | | out.finish() [INFO] [stdout] 141 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/partitioned.rs:187:34 [INFO] [stdout] | [INFO] [stdout] 184 | key: F [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | split_by_key(defs, n_chunks, move |_idx, v| { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 188 | | let k = key(v); [INFO] [stdout] 189 | | let mut hasher = DefaultHasher::new(); [INFO] [stdout] 190 | | k.hash(&mut hasher); [INFO] [stdout] 191 | | hasher.finish() as usize [INFO] [stdout] 192 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/partitioned.rs:231:17 [INFO] [stdout] | [INFO] [stdout] 227 | acc: Acc, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | joiner: J [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | d1.join(d2, move |left, right| { [INFO] [stdout] | _________________^ [INFO] [stdout] 232 | | // Slurp up left into a hashmap [INFO] [stdout] 233 | | let mut hm = HashMap::new(); [INFO] [stdout] 234 | | for (k, lv) in left.stream() { [INFO] [stdout] ... | [INFO] [stdout] 246 | | ret.finish() [INFO] [stdout] 247 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 28 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tange-collection` (lib test) due to 29 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "577e29b839e176df2a4f9120a13c3f0bf0ff0ed260a5a0f473ac6a7c420be55b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "577e29b839e176df2a4f9120a13c3f0bf0ff0ed260a5a0f473ac6a7c420be55b", kill_on_drop: false }` [INFO] [stdout] 577e29b839e176df2a4f9120a13c3f0bf0ff0ed260a5a0f473ac6a7c420be55b