[INFO] fetching crate tang-rs 0.2.0... [INFO] checking tang-rs-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tang-rs 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate tang-rs 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tang-rs 0.2.0 [INFO] finished tweaking crates.io crate tang-rs 0.2.0 [INFO] tweaked toml for crates.io crate tang-rs 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 133 packages to latest compatible versions [INFO] [stderr] Adding async-channel v1.9.0 (latest: v2.3.1) [INFO] [stderr] Adding async-io v1.13.0 (latest: v2.3.4) [INFO] [stderr] Adding async-lock v2.8.0 (latest: v3.4.0) [INFO] [stderr] Adding async-process v1.8.1 (latest: v2.2.4) [INFO] [stderr] Adding async-task v3.0.0 (latest: v4.7.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding blocking v0.4.7 (latest: v1.6.1) [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding concurrent-queue v1.2.4 (latest: v2.5.0) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding event-listener v3.1.0 (latest: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding futures-lite v0.1.11 (latest: v2.3.0) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding gloo-timers v0.2.6 (latest: v0.3.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding io-lifetimes v1.0.11 (latest: v2.0.3) [INFO] [stderr] Adding linux-raw-sys v0.3.8 (latest: v0.6.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding miow v0.3.7 (latest: v0.6.0) [INFO] [stderr] Adding parking v1.0.6 (latest: v2.2.0) [INFO] [stderr] Adding pin-project-lite v0.1.12 (latest: v0.2.14) [INFO] [stderr] Adding polling v2.8.0 (latest: v3.7.3) [INFO] [stderr] Adding rustix v0.37.27 (latest: v0.38.35) [INFO] [stderr] Adding smol v0.1.18 (latest: v2.0.1) [INFO] [stderr] Adding socket2 v0.3.19 (latest: v0.5.7) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tokio v0.2.25 (latest: v1.40.0) [INFO] [stderr] Adding tokio-macros v0.2.6 (latest: v2.4.0) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dbd696e86f5a3976356b8638f56fb16e3b5fb36c3c8c6f8c22f39abff13cd35b [INFO] running `Command { std: "docker" "start" "-a" "dbd696e86f5a3976356b8638f56fb16e3b5fb36c3c8c6f8c22f39abff13cd35b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dbd696e86f5a3976356b8638f56fb16e3b5fb36c3c8c6f8c22f39abff13cd35b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dbd696e86f5a3976356b8638f56fb16e3b5fb36c3c8c6f8c22f39abff13cd35b", kill_on_drop: false }` [INFO] [stdout] dbd696e86f5a3976356b8638f56fb16e3b5fb36c3c8c6f8c22f39abff13cd35b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 450a77463d9cb3f418592ef06b68a07e52184958b041871df3d9e13a8a3ab519 [INFO] running `Command { std: "docker" "start" "-a" "450a77463d9cb3f418592ef06b68a07e52184958b041871df3d9e13a8a3ab519", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking value-bag v1.9.0 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking pin-project-lite v0.1.12 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking futures-lite v0.1.11 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking event-listener v3.1.0 [INFO] [stderr] Checking cache-padded v1.3.0 [INFO] [stderr] Checking parking v1.0.6 [INFO] [stderr] Checking concurrent-queue v1.2.4 [INFO] [stderr] Compiling tokio-macros v0.2.6 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking async-task v3.0.0 [INFO] [stderr] Checking tang-rs v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated function `std::sync::atomic::spin_loop_hint`: use hint::spin_loop instead [INFO] [stdout] --> src/util/spin_pool.rs:3:26 [INFO] [stdout] | [INFO] [stdout] 3 | use core::sync::atomic::{spin_loop_hint, AtomicUsize, Ordering}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::sync::atomic::spin_loop_hint`: use hint::spin_loop instead [INFO] [stdout] --> src/util/spin_pool.rs:131:17 [INFO] [stdout] | [INFO] [stdout] 131 | spin_loop_hint(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/util/spin_pool.rs:90:23 [INFO] [stdout] | [INFO] [stdout] 90 | if self.state.compare_and_swap(FREE, LOCKED, Ordering::Acquire) == FREE { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:39:19 [INFO] [stdout] | [INFO] [stdout] 36 | fn new(conn: M::Connection, marker: usize) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | conn: Conn { [INFO] [stdout] | ___________________^ [INFO] [stdout] 40 | | conn, [INFO] [stdout] 41 | | marker, [INFO] [stdout] 42 | | birth: now, [INFO] [stdout] 43 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:433:19 [INFO] [stdout] | [INFO] [stdout] 430 | pub(crate) fn new(builder: Builder, manager: M) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 431 | let pool = ManagedPool::new(builder, manager); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 432 | Pool { [INFO] [stdout] 433 | pool: WrapPointer::new(pool), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:535:19 [INFO] [stdout] | [INFO] [stdout] 533 | fn from_idle(conn: IdleConn, shared_pool: &'re SharedManagedPool) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 534 | Self { [INFO] [stdout] 535 | conn: Some(conn.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:549:19 [INFO] [stdout] | [INFO] [stdout] 547 | fn from_idle(conn: IdleConn, shared_pool: &SharedManagedPool) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 548 | Self { [INFO] [stdout] 549 | conn: Some(conn.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:550:26 [INFO] [stdout] | [INFO] [stdout] 547 | fn from_idle(conn: IdleConn, shared_pool: &SharedManagedPool) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 550 | shared_pool: WrapPointer::downgrade(shared_pool), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool_inner.rs:258:9 [INFO] [stdout] | [INFO] [stdout] 254 | pub(crate) fn try_drop_conn(&self, mut should_drop: F) -> Option<(usize, usize)> [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | self.try_lock_inner().and_then(|mut inner| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/spin_pool.rs:27:20 [INFO] [stdout] | [INFO] [stdout] 24 | pub const fn new(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | inner: UnsafeCell::new(t), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tang-rs` (lib) due to 8 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "450a77463d9cb3f418592ef06b68a07e52184958b041871df3d9e13a8a3ab519", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "450a77463d9cb3f418592ef06b68a07e52184958b041871df3d9e13a8a3ab519", kill_on_drop: false }` [INFO] [stdout] 450a77463d9cb3f418592ef06b68a07e52184958b041871df3d9e13a8a3ab519