[INFO] fetching crate tame-oauth 0.10.0... [INFO] checking tame-oauth-0.10.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tame-oauth 0.10.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate tame-oauth 0.10.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tame-oauth 0.10.0 [INFO] finished tweaking crates.io crate tame-oauth 0.10.0 [INFO] tweaked toml for crates.io crate tame-oauth 0.10.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate tame-oauth 0.10.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a5706802c843b4d2d3db7b1de7166539a5ff20af28469d6f0f33f25a466413e5 [INFO] running `Command { std: "docker" "start" "-a" "a5706802c843b4d2d3db7b1de7166539a5ff20af28469d6f0f33f25a466413e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a5706802c843b4d2d3db7b1de7166539a5ff20af28469d6f0f33f25a466413e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5706802c843b4d2d3db7b1de7166539a5ff20af28469d6f0f33f25a466413e5", kill_on_drop: false }` [INFO] [stdout] a5706802c843b4d2d3db7b1de7166539a5ff20af28469d6f0f33f25a466413e5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 26d3358eee6c397804119820470f5652798223f33218546b7154380b49cc5994 [INFO] running `Command { std: "docker" "start" "-a" "26d3358eee6c397804119820470f5652798223f33218546b7154380b49cc5994", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking rustls-pki-types v1.3.1 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling rustls v0.22.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking data-encoding v2.5.0 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking webpki-roots v0.26.1 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Compiling syn v2.0.53 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking rustls-webpki v0.102.2 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking hyper v1.2.0 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking tame-oauth v0.10.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking hyper-rustls v0.26.0 [INFO] [stderr] Checking reqwest v0.12.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gcp.rs:121:32 [INFO] [stdout] | [INFO] [stdout] 118 | sa::ServiceAccountProviderInner::new(sa_info).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | error: Box::new(e), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gcp.rs:166:32 [INFO] [stdout] | [INFO] [stdout] 164 | .map_err(|e| Error::InvalidCredentials { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | file: gcloud_file, [INFO] [stdout] 166 | error: Box::new(e), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gcp/end_user.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 115 | subject: Option, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | _scopes: I, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | let request = self.prepare_token_request()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | [INFO] [stdout] 141 | Ok(TokenOrRequest::Request { [INFO] [stdout] | ____________^ [INFO] [stdout] 142 | | request, [INFO] [stdout] 143 | | reason: RequestReason::ParametersChanged, [INFO] [stdout] 144 | | scope_hash: 0, [INFO] [stdout] 145 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gcp/end_user.rs:179:12 [INFO] [stdout] | [INFO] [stdout] 177 | let request = self.prepare_token_request()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | [INFO] [stdout] 179 | Ok(IdTokenOrRequest::IdTokenRequest { [INFO] [stdout] | ____________^ [INFO] [stdout] 180 | | request, [INFO] [stdout] 181 | | reason: RequestReason::ParametersChanged, [INFO] [stdout] 182 | | audience_hash: 0, [INFO] [stdout] 183 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gcp/end_user.rs:196:13 [INFO] [stdout] | [INFO] [stdout] 189 | _response: AccessTokenResponse, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | Err(Error::Auth(error::AuthError { [INFO] [stdout] | _____________^ [INFO] [stdout] 197 | | error: Some("Unsupported".to_string()), [INFO] [stdout] 198 | | error_description: Some( [INFO] [stdout] 199 | | "User credentials id tokens via access token not supported".to_string(), [INFO] [stdout] 200 | | ), [INFO] [stdout] 201 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gcp/metadata_server.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 42 | subject: Option, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | scopes: I, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let request = http::Request::builder() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | Ok(TokenOrRequest::Request { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | request, [INFO] [stdout] 87 | | reason: RequestReason::ParametersChanged, [INFO] [stdout] 88 | | scope_hash: 0, [INFO] [stdout] 89 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gcp/metadata_server.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 122 | let request = http::Request::builder() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | Ok(IdTokenOrRequest::IdTokenRequest { [INFO] [stdout] | ____________^ [INFO] [stdout] 129 | | request, [INFO] [stdout] 130 | | reason: RequestReason::ParametersChanged, [INFO] [stdout] 131 | | audience_hash: 0, [INFO] [stdout] 132 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gcp/metadata_server.rs:164:13 [INFO] [stdout] | [INFO] [stdout] 157 | _access_token_resp: crate::id_token::AccessTokenResponse, [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | Err(Error::Auth(error::AuthError { [INFO] [stdout] | _____________^ [INFO] [stdout] 165 | | error: Some("Unsupported".to_string()), [INFO] [stdout] 166 | | error_description: Some( [INFO] [stdout] 167 | | "Metadata server id tokens via access token not supported".to_string(), [INFO] [stdout] 168 | | ), [INFO] [stdout] 169 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gcp/service_account.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 173 | subject: Option, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | scopes: I, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | let request = self.prepare_access_token_request(subject, scopes)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | Ok(TokenOrRequest::Request { [INFO] [stdout] | ____________^ [INFO] [stdout] 183 | | reason: RequestReason::ParametersChanged, [INFO] [stdout] 184 | | request, [INFO] [stdout] 185 | | scope_hash: 0, [INFO] [stdout] 186 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gcp/service_account.rs:232:12 [INFO] [stdout] | [INFO] [stdout] 229 | let request = self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | Ok(IdTokenOrRequest::AccessTokenRequest { [INFO] [stdout] | ____________^ [INFO] [stdout] 233 | | request, [INFO] [stdout] 234 | | reason: RequestReason::ParametersChanged, [INFO] [stdout] 235 | | audience_hash: 0, [INFO] [stdout] 236 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/token_cache.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 42 | let cache = self.cache.read().map_err(|_e| Error::Poisoned)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok(TokenOrRequestReason::RequestReason(reason)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/token_cache.rs:138:15 [INFO] [stdout] | [INFO] [stdout] 123 | subject: Option, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | scopes: I, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | match self.inner.get_token_with_subject(subject, scopes)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/token_cache.rs:175:15 [INFO] [stdout] | [INFO] [stdout] 175 | match self.inner.get_id_token(audience)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tame-oauth` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "26d3358eee6c397804119820470f5652798223f33218546b7154380b49cc5994", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26d3358eee6c397804119820470f5652798223f33218546b7154380b49cc5994", kill_on_drop: false }` [INFO] [stdout] 26d3358eee6c397804119820470f5652798223f33218546b7154380b49cc5994