[INFO] fetching crate talos_certifier 0.2.15... [INFO] checking talos_certifier-0.2.15 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate talos_certifier 0.2.15 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate talos_certifier 0.2.15 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate talos_certifier 0.2.15 [INFO] finished tweaking crates.io crate talos_certifier 0.2.15 [INFO] tweaked toml for crates.io crate talos_certifier 0.2.15 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 163 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v3.2.25 (latest: v4.5.16) [INFO] [stderr] Adding clap_lex v0.2.4 (latest: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding env_logger v0.10.2 (latest: v0.11.5) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding mockall v0.11.4 (latest: v0.13.0) [INFO] [stderr] Adding mockall_derive v0.11.4 (latest: v0.13.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (latest: v7.0.0) [INFO] [stderr] Adding predicates v2.1.5 (latest: v3.1.2) [INFO] [stderr] Adding strum v0.24.1 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.24.3 (latest: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding termtree v0.4.1 (latest: v0.5.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f7c4a76737d42d279d72a3a67f19777c146fbc2bea14352c17be5b3fb4b84916 [INFO] running `Command { std: "docker" "start" "-a" "f7c4a76737d42d279d72a3a67f19777c146fbc2bea14352c17be5b3fb4b84916", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f7c4a76737d42d279d72a3a67f19777c146fbc2bea14352c17be5b3fb4b84916", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7c4a76737d42d279d72a3a67f19777c146fbc2bea14352c17be5b3fb4b84916", kill_on_drop: false }` [INFO] [stdout] f7c4a76737d42d279d72a3a67f19777c146fbc2bea14352c17be5b3fb4b84916 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4c7388230da42bef928730e995afdadbb6d95c9dcb9ab6ccc7d34fdffdd11515 [INFO] running `Command { std: "docker" "start" "-a" "4c7388230da42bef928730e995afdadbb6d95c9dcb9ab6ccc7d34fdffdd11515", kill_on_drop: false }` [INFO] [stderr] Compiling typeid v1.0.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking predicates-core v1.0.8 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling mockall_derive v0.11.4 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking predicates-tree v1.0.11 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Compiling cargo-husky v1.5.0 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking mockall v0.11.4 [INFO] [stderr] Checking serde_fmt v1.0.3 [INFO] [stderr] Checking erased-serde v0.4.5 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking value-bag-serde1 v1.9.0 [INFO] [stderr] Checking value-bag v1.9.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking criterion v0.4.0 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking talos_suffix v0.2.15 [INFO] [stderr] Checking talos_certifier v0.2.15 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/healthcheck_service.rs:20:26 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(system: System) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | healthcheck: healthcheck::HealthChecks::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/message_receiver_service.rs:37:30 [INFO] [stdout] | [INFO] [stdout] 27 | receiver: Box + Send + Sync>, [INFO] [stdout] | -------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | message_channel_tx: mpsc::Sender, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | commit_offset: Arc, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | system: System, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | commit_interval: tokio::time::interval(Duration::from_millis(10_000)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/talos_certifier_service.rs:22:32 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(system: System) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | certifier_service: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/talos_certifier_service.rs:49:28 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn build(self) -> TalosCertifierService { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let mut services = self.services; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | shutdown_flag: Arc::new(AtomicBool::new(false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/talos_certifier_service.rs:63:26 [INFO] [stdout] | [INFO] [stdout] 62 | let service_handle = self.services.into_iter().map(|mut service| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | tokio::spawn({ [INFO] [stdout] | __________________________^ [INFO] [stdout] 64 | | let shutdown_notifier_cloned = self.system.system_notifier.clone(); [INFO] [stdout] 65 | | let mut shutdown_receiver = shutdown_notifier_cloned.subscribe(); [INFO] [stdout] 66 | | let shutdown_flag = Arc::clone(&self.shutdown_flag); [INFO] [stdout] ... | [INFO] [stdout] 99 | | } [INFO] [stdout] 100 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `talos_certifier` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "4c7388230da42bef928730e995afdadbb6d95c9dcb9ab6ccc7d34fdffdd11515", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c7388230da42bef928730e995afdadbb6d95c9dcb9ab6ccc7d34fdffdd11515", kill_on_drop: false }` [INFO] [stdout] 4c7388230da42bef928730e995afdadbb6d95c9dcb9ab6ccc7d34fdffdd11515