[INFO] fetching crate tacview 0.2.0... [INFO] checking tacview-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tacview 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate tacview 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tacview 0.2.0 [INFO] finished tweaking crates.io crate tacview 0.2.0 [INFO] tweaked toml for crates.io crate tacview 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate tacview 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a30f399ad2a69315f7720a4d9af27350b3897db102997afbf7a9e2e6da7acf18 [INFO] running `Command { std: "docker" "start" "-a" "a30f399ad2a69315f7720a4d9af27350b3897db102997afbf7a9e2e6da7acf18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a30f399ad2a69315f7720a4d9af27350b3897db102997afbf7a9e2e6da7acf18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a30f399ad2a69315f7720a4d9af27350b3897db102997afbf7a9e2e6da7acf18", kill_on_drop: false }` [INFO] [stdout] a30f399ad2a69315f7720a4d9af27350b3897db102997afbf7a9e2e6da7acf18 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 92c1a163de1ac34600d82da60538f5d205c9b1198fce043a5cd60ba4b6c12ac0 [INFO] running `Command { std: "docker" "start" "-a" "92c1a163de1ac34600d82da60538f5d205c9b1198fce043a5cd60ba4b6c12ac0", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.6 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Compiling zip v2.1.6 [INFO] [stderr] Checking lockfree-object-pool v0.1.6 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking zopfli v0.8.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking tacview v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(rd: R) -> Result [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let mut lines = lines::Lines::new(BufReader::new(rd)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | Ok(Parser { lines }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/property.rs:537:12 [INFO] [stdout] | [INFO] [stdout] 537 | Ok(match name { [INFO] [stdout] | ____________^ [INFO] [stdout] 538 | | "T" => Property::T(Coords::from_str(value)?), [INFO] [stdout] 539 | | "Name" => Property::Name(value.to_string()), [INFO] [stdout] 540 | | "Type" => Property::Type(value.split('+').map(Tag::from).collect()), [INFO] [stdout] ... | [INFO] [stdout] 663 | | name => Self::Unknown(name.to_string(), value.to_string()), [INFO] [stdout] 664 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/update.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 19 | let mut props = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(Update { id, props }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(mut wr: W) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | Ok(Self { wr }) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tacview` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(rd: R) -> Result [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let mut lines = lines::Lines::new(BufReader::new(rd)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | Ok(Parser { lines }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/property.rs:537:12 [INFO] [stdout] | [INFO] [stdout] 537 | Ok(match name { [INFO] [stdout] | ____________^ [INFO] [stdout] 538 | | "T" => Property::T(Coords::from_str(value)?), [INFO] [stdout] 539 | | "Name" => Property::Name(value.to_string()), [INFO] [stdout] 540 | | "Type" => Property::Type(value.split('+').map(Tag::from).collect()), [INFO] [stdout] ... | [INFO] [stdout] 663 | | name => Self::Unknown(name.to_string(), value.to_string()), [INFO] [stdout] 664 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/update.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 19 | let mut props = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(Update { id, props }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(mut wr: W) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | Ok(Self { wr }) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tacview` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "92c1a163de1ac34600d82da60538f5d205c9b1198fce043a5cd60ba4b6c12ac0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "92c1a163de1ac34600d82da60538f5d205c9b1198fce043a5cd60ba4b6c12ac0", kill_on_drop: false }` [INFO] [stdout] 92c1a163de1ac34600d82da60538f5d205c9b1198fce043a5cd60ba4b6c12ac0