[INFO] fetching crate systemstat 0.2.3... [INFO] checking systemstat-0.2.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate systemstat 0.2.3 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate systemstat 0.2.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate systemstat 0.2.3 [INFO] finished tweaking crates.io crate systemstat 0.2.3 [INFO] tweaked toml for crates.io crate systemstat 0.2.3 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate systemstat 0.2.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8ac5124e439dd6c5c071c94f3b6e29a29a98d2142a2bf7debb28afd28692c49b [INFO] running `Command { std: "docker" "start" "-a" "8ac5124e439dd6c5c071c94f3b6e29a29a98d2142a2bf7debb28afd28692c49b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8ac5124e439dd6c5c071c94f3b6e29a29a98d2142a2bf7debb28afd28692c49b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ac5124e439dd6c5c071c94f3b6e29a29a98d2142a2bf7debb28afd28692c49b", kill_on_drop: false }` [INFO] [stdout] 8ac5124e439dd6c5c071c94f3b6e29a29a98d2142a2bf7debb28afd28692c49b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 27974ab9a9c8752a552f7f53feb0ee8165346c4565ebad5bef6f52345ad120d8 [INFO] running `Command { std: "docker" "start" "-a" "27974ab9a9c8752a552f7f53feb0ee8165346c4565ebad5bef6f52345ad120d8", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Checking time-core v0.1.0 [INFO] [stderr] Checking bytesize v1.1.0 [INFO] [stderr] Checking time v0.3.17 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking systemstat v0.2.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/common.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 21 | let measurement = self.cpu_load()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(DelayedMeasurement::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | Box::new(move || measurement.done().map(|ls| { [INFO] [stdout] 24 | | let mut it = ls.iter(); [INFO] [stdout] 25 | | let first = it.next().unwrap().clone(); // has to be a variable, rust moves the iterator otherwise [INFO] [stdout] 26 | | it.fold(first, |acc, l| acc.avg_add(l)) [INFO] [stdout] 27 | | })))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/common.rs:23:34 [INFO] [stdout] | [INFO] [stdout] 21 | let measurement = self.cpu_load()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(DelayedMeasurement::new( [INFO] [stdout] 23 | Box::new(move || measurement.done().map(|ls| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/common.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 77 | fn mount_at>(&self, path: P) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | self.mounts() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/linux.rs:651:41 [INFO] [stdout] | [INFO] [stdout] 651 | .filter_map(|mount| stat_mount(mount).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/linux.rs:657:9 [INFO] [stdout] | [INFO] [stdout] 656 | fn mount_at>(&self, path: P) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 657 | / read_file("/proc/mounts") [INFO] [stdout] 658 | | .and_then(|data| { [INFO] [stdout] 659 | | proc_mounts(&data) [INFO] [stdout] 660 | | .map(|(_, res)| res) [INFO] [stdout] ... | [INFO] [stdout] 667 | | .ok_or_else(|| io::Error::new(io::ErrorKind::NotFound, "No such mount")) [INFO] [stdout] 668 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `systemstat` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/common.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 21 | let measurement = self.cpu_load()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(DelayedMeasurement::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | Box::new(move || measurement.done().map(|ls| { [INFO] [stdout] 24 | | let mut it = ls.iter(); [INFO] [stdout] 25 | | let first = it.next().unwrap().clone(); // has to be a variable, rust moves the iterator otherwise [INFO] [stdout] 26 | | it.fold(first, |acc, l| acc.avg_add(l)) [INFO] [stdout] 27 | | })))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/common.rs:23:34 [INFO] [stdout] | [INFO] [stdout] 21 | let measurement = self.cpu_load()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(DelayedMeasurement::new( [INFO] [stdout] 23 | Box::new(move || measurement.done().map(|ls| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/common.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 77 | fn mount_at>(&self, path: P) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | self.mounts() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/linux.rs:651:41 [INFO] [stdout] | [INFO] [stdout] 651 | .filter_map(|mount| stat_mount(mount).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/linux.rs:657:9 [INFO] [stdout] | [INFO] [stdout] 656 | fn mount_at>(&self, path: P) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 657 | / read_file("/proc/mounts") [INFO] [stdout] 658 | | .and_then(|data| { [INFO] [stdout] 659 | | proc_mounts(&data) [INFO] [stdout] 660 | | .map(|(_, res)| res) [INFO] [stdout] ... | [INFO] [stdout] 667 | | .ok_or_else(|| io::Error::new(io::ErrorKind::NotFound, "No such mount")) [INFO] [stdout] 668 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `systemstat` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "27974ab9a9c8752a552f7f53feb0ee8165346c4565ebad5bef6f52345ad120d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27974ab9a9c8752a552f7f53feb0ee8165346c4565ebad5bef6f52345ad120d8", kill_on_drop: false }` [INFO] [stdout] 27974ab9a9c8752a552f7f53feb0ee8165346c4565ebad5bef6f52345ad120d8