[INFO] fetching crate systemd-parser 0.1.3... [INFO] checking systemd-parser-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate systemd-parser 0.1.3 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate systemd-parser 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate systemd-parser 0.1.3 [INFO] finished tweaking crates.io crate systemd-parser 0.1.3 [INFO] tweaked toml for crates.io crate systemd-parser 0.1.3 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] [stderr] Adding itertools v0.5.10 (latest: v0.13.0) [INFO] [stderr] Adding nom v2.2.1 (latest: v7.1.3) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9d2ce9807d60aeac80e03373c1731524f792fafdd292ef2f21776129202137d4 [INFO] running `Command { std: "docker" "start" "-a" "9d2ce9807d60aeac80e03373c1731524f792fafdd292ef2f21776129202137d4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9d2ce9807d60aeac80e03373c1731524f792fafdd292ef2f21776129202137d4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d2ce9807d60aeac80e03373c1731524f792fafdd292ef2f21776129202137d4", kill_on_drop: false }` [INFO] [stdout] 9d2ce9807d60aeac80e03373c1731524f792fafdd292ef2f21776129202137d4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 95c50a529fd741b0e33cc49b3c4aa355142c91daac2a57532b7621928624c87e [INFO] running `Command { std: "docker" "start" "-a" "95c50a529fd741b0e33cc49b3c4aa355142c91daac2a57532b7621928624c87e", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking itertools v0.5.10 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking nom v2.2.1 [INFO] [stderr] Checking systemd-parser v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/items.rs:49:23 [INFO] [stdout] | [INFO] [stdout] 49 | let mut cat = try!(UnitDirective::get_first_category(unit_items)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/items.rs:105:26 [INFO] [stdout] | [INFO] [stdout] 105 | let directives = try!( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/items.rs:109:31 [INFO] [stdout] | [INFO] [stdout] 109 | let directives_hash = try!( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/items.rs:137:21 [INFO] [stdout] | [INFO] [stdout] 137 | try!(SystemdUnit::validate_many(&vecs)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/parser.rs:57:38 [INFO] [stdout] | [INFO] [stdout] 57 | (SystemdItem::Directive(key, (if value.is_empty() { None } else { Some(value) }))) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 57 - (SystemdItem::Directive(key, (if value.is_empty() { None } else { Some(value) }))) [INFO] [stdout] 57 + (SystemdItem::Directive(key, if value.is_empty() { None } else { Some(value) })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | let units = try!(parser::parse_unit(&input)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:22:24 [INFO] [stdout] | [INFO] [stdout] 22 | let systemd_unit = try!(items::SystemdUnit::new(&units)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/items.rs:49:23 [INFO] [stdout] | [INFO] [stdout] 49 | let mut cat = try!(UnitDirective::get_first_category(unit_items)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/items.rs:105:26 [INFO] [stdout] | [INFO] [stdout] 105 | let directives = try!( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/items.rs:109:31 [INFO] [stdout] | [INFO] [stdout] 109 | let directives_hash = try!( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/items.rs:137:21 [INFO] [stdout] | [INFO] [stdout] 137 | try!(SystemdUnit::validate_many(&vecs)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/parser.rs:57:38 [INFO] [stdout] | [INFO] [stdout] 57 | (SystemdItem::Directive(key, (if value.is_empty() { None } else { Some(value) }))) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 57 - (SystemdItem::Directive(key, (if value.is_empty() { None } else { Some(value) }))) [INFO] [stdout] 57 + (SystemdItem::Directive(key, if value.is_empty() { None } else { Some(value) })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | let units = try!(parser::parse_unit(&input)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:22:24 [INFO] [stdout] | [INFO] [stdout] 22 | let systemd_unit = try!(items::SystemdUnit::new(&units)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:35:57 [INFO] [stdout] | [INFO] [stdout] 35 | display(error) -> ("{}, errors:\n{}", error.description(), helper_format(errors)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:35:57 [INFO] [stdout] | [INFO] [stdout] 35 | display(error) -> ("{}, errors:\n{}", error.description(), helper_format(errors)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:40:48 [INFO] [stdout] | [INFO] [stdout] 40 | display(error) -> ("{}: {}", error.description(), err) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:40:48 [INFO] [stdout] | [INFO] [stdout] 40 | display(error) -> ("{}: {}", error.description(), err) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_comment` and `is_category` are never used [INFO] [stdout] --> src/items.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 11 | impl<'a> SystemdItem<'a> { [INFO] [stdout] | ------------------------ methods in this implementation [INFO] [stdout] 12 | fn is_comment(&self) -> bool { match *self { SystemdItem::Comment(_) => true, _ => false } } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 13 | fn is_category(&self) -> bool { match *self { SystemdItem::Category(_) => true, _ => false } } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_comment` and `is_category` are never used [INFO] [stdout] --> src/items.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 11 | impl<'a> SystemdItem<'a> { [INFO] [stdout] | ------------------------ methods in this implementation [INFO] [stdout] 12 | fn is_comment(&self) -> bool { match *self { SystemdItem::Comment(_) => true, _ => false } } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 13 | fn is_category(&self) -> bool { match *self { SystemdItem::Category(_) => true, _ => false } } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser_test.rs:250:13 [INFO] [stdout] | [INFO] [stdout] 247 | let res = parse_unit(&input); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | res.unwrap_err().get(0).unwrap().1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser_test.rs:260:13 [INFO] [stdout] | [INFO] [stdout] 257 | let res = parse_unit(&input); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | res.unwrap_err().get(1).unwrap().1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `systemd-parser` (lib test) due to 3 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "95c50a529fd741b0e33cc49b3c4aa355142c91daac2a57532b7621928624c87e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95c50a529fd741b0e33cc49b3c4aa355142c91daac2a57532b7621928624c87e", kill_on_drop: false }` [INFO] [stdout] 95c50a529fd741b0e33cc49b3c4aa355142c91daac2a57532b7621928624c87e