[INFO] fetching crate system-deps 7.0.2... [INFO] checking system-deps-7.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate system-deps 7.0.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate system-deps 7.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate system-deps 7.0.2 [INFO] finished tweaking crates.io crate system-deps 7.0.2 [INFO] tweaked toml for crates.io crate system-deps 7.0.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 26 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8365cae519c3ffbfba6e059fbd89f8a0479115126ff50b165960e095e0d375cb [INFO] running `Command { std: "docker" "start" "-a" "8365cae519c3ffbfba6e059fbd89f8a0479115126ff50b165960e095e0d375cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8365cae519c3ffbfba6e059fbd89f8a0479115126ff50b165960e095e0d375cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8365cae519c3ffbfba6e059fbd89f8a0479115126ff50b165960e095e0d375cb", kill_on_drop: false }` [INFO] [stdout] 8365cae519c3ffbfba6e059fbd89f8a0479115126ff50b165960e095e0d375cb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8443d14977155039bfb954a151cc925826e1b53825bc12434dcee79fe5b9bdac [INFO] running `Command { std: "docker" "start" "-a" "8443d14977155039bfb954a151cc925826e1b53825bc12434dcee79fe5b9bdac", kill_on_drop: false }` [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking heck v0.5.0 [INFO] [stderr] Checking version-compare v0.2.0 [INFO] [stderr] Checking pkg-config v0.3.30 [INFO] [stderr] Checking cfg-expr v0.16.0 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking system-deps v7.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 178 | let mut manifest = fs::File::open(path).map_err(|e| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | Self::from_str(manifest_str) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:202:12 [INFO] [stdout] | [INFO] [stdout] 200 | let deps = Self::parse_deps_table(meta, key, true)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | [INFO] [stdout] 202 | Ok(MetaData { deps }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `system-deps` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:729:11 [INFO] [stdout] | [INFO] [stdout] 717 | let config = create_config(path, env).add_build_internal(expected_lib, move |lib, version| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 729 | match config.probe_full() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 178 | let mut manifest = fs::File::open(path).map_err(|e| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | Self::from_str(manifest_str) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:202:12 [INFO] [stdout] | [INFO] [stdout] 200 | let deps = Self::parse_deps_table(meta, key, true)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | [INFO] [stdout] 202 | Ok(MetaData { deps }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:436:13 [INFO] [stdout] | [INFO] [stdout] 432 | let m = parse_file("toml-good").unwrap(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | / MetaData { [INFO] [stdout] 437 | | deps: vec![ [INFO] [stdout] 438 | | Dependency { [INFO] [stdout] 439 | | key: "testdata".into(), [INFO] [stdout] ... | [INFO] [stdout] 455 | | ] [INFO] [stdout] 456 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:474:13 [INFO] [stdout] | [INFO] [stdout] 470 | let m = parse_file("toml-override-name").unwrap(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 474 | / MetaData { [INFO] [stdout] 475 | | deps: vec![Dependency { [INFO] [stdout] 476 | | key: "test_lib".into(), [INFO] [stdout] 477 | | version: Some("1.0".into()), [INFO] [stdout] ... | [INFO] [stdout] 487 | | },] [INFO] [stdout] 488 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:498:13 [INFO] [stdout] | [INFO] [stdout] 494 | let m = parse_file("toml-feature-versions").unwrap(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 498 | / MetaData { [INFO] [stdout] 499 | | deps: vec![Dependency { [INFO] [stdout] 500 | | key: "testdata".into(), [INFO] [stdout] 501 | | version: Some("4".into()), [INFO] [stdout] ... | [INFO] [stdout] 519 | | },] [INFO] [stdout] 520 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:530:13 [INFO] [stdout] | [INFO] [stdout] 526 | let m = parse_file("toml-fallback-names").unwrap(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 530 | / MetaData { [INFO] [stdout] 531 | | deps: vec![Dependency { [INFO] [stdout] 532 | | key: "test_lib".into(), [INFO] [stdout] 533 | | version: Some("1.0".into()), [INFO] [stdout] ... | [INFO] [stdout] 542 | | }] [INFO] [stdout] 543 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:553:13 [INFO] [stdout] | [INFO] [stdout] 549 | let m = parse_file("toml-version-fallback-names").unwrap(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 553 | / MetaData { [INFO] [stdout] 554 | | deps: vec![Dependency { [INFO] [stdout] 555 | | key: "test_lib".into(), [INFO] [stdout] 556 | | version: Some("0.1".into()), [INFO] [stdout] ... | [INFO] [stdout] 587 | | }] [INFO] [stdout] 588 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:598:13 [INFO] [stdout] | [INFO] [stdout] 594 | let m = parse_file("toml-optional").unwrap(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 598 | / MetaData { [INFO] [stdout] 599 | | deps: vec![ [INFO] [stdout] 600 | | Dependency { [INFO] [stdout] 601 | | key: "testbadger".into(), [INFO] [stdout] ... | [INFO] [stdout] 631 | | ] [INFO] [stdout] 632 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:642:13 [INFO] [stdout] | [INFO] [stdout] 638 | let m = parse_file("toml-os-specific").unwrap(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 642 | / MetaData { [INFO] [stdout] 643 | | deps: vec![ [INFO] [stdout] 644 | | Dependency { [INFO] [stdout] 645 | | key: "testlib".into(), [INFO] [stdout] ... | [INFO] [stdout] 663 | | ] [INFO] [stdout] 664 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `system-deps` (lib test) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "8443d14977155039bfb954a151cc925826e1b53825bc12434dcee79fe5b9bdac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8443d14977155039bfb954a151cc925826e1b53825bc12434dcee79fe5b9bdac", kill_on_drop: false }` [INFO] [stdout] 8443d14977155039bfb954a151cc925826e1b53825bc12434dcee79fe5b9bdac