[INFO] fetching crate syslog-rs 0.6.0... [INFO] checking syslog-rs-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate syslog-rs 0.6.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate syslog-rs 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate syslog-rs 0.6.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate syslog-rs 0.6.0 [INFO] tweaked toml for crates.io crate syslog-rs 0.6.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate syslog-rs 0.6.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9c7b0c461f5795c01457a4d31bbb9ca36705720212511c7f5eddba3b656e4e4d [INFO] running `Command { std: "docker" "start" "-a" "9c7b0c461f5795c01457a4d31bbb9ca36705720212511c7f5eddba3b656e4e4d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9c7b0c461f5795c01457a4d31bbb9ca36705720212511c7f5eddba3b656e4e4d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c7b0c461f5795c01457a4d31bbb9ca36705720212511c7f5eddba3b656e4e4d", kill_on_drop: false }` [INFO] [stdout] 9c7b0c461f5795c01457a4d31bbb9ca36705720212511c7f5eddba3b656e4e4d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cc33a64af3d8f902ed17a4fe298af27f35ef53daa9610bd5264bf3960c302743 [INFO] running `Command { std: "docker" "start" "-a" "cc33a64af3d8f902ed17a4fe298af27f35ef53daa9610bd5264bf3960c302743", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-channel v0.5.11 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking chrono v0.4.33 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling async-recursion v1.0.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking syslog-rs v0.6.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking tokio-test v0.4.3 [INFO] [stdout] warning: method `get_raw_fd` is never used [INFO] [stdout] --> src/sync/socket.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 32 | pub(crate) trait SyslogTap [INFO] [stdout] | --------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 35 | fn get_raw_fd(&self) -> RawFd; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_raw_fd` is never used [INFO] [stdout] --> src/a_sync/async_socket.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 36 | pub(crate) trait AsyncSyslogTap [INFO] [stdout] | -------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 39 | fn get_raw_fd(&self) -> RawFd; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/syslog_sync.rs:151:15 [INFO] [stdout] | [INFO] [stdout] 149 | fn vsyslog>(&self, pri: Priority, fmt: S) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | { [INFO] [stdout] 151 | match self.inner.lock() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/a_sync/syslog_async.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 89 | fn vsyslog + Send>(&self, pri: Priority, fmt: S) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | / { [INFO] [stdout] 91 | | let f = fmt.as_ref(); [INFO] [stdout] 92 | | [INFO] [stdout] 93 | | self [INFO] [stdout] ... | [INFO] [stdout] 98 | | .await; [INFO] [stdout] 99 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/a_sync/syslog_async.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 107 | fn openlog_custom

(ident: Option<&str>, logstat: LogStat, facility: LogFacility, sock_path: P, use_altr_path: bool) -> SyRes [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | where Self: Sized, P: AsRef + Send [INFO] [stdout] 109 | / { [INFO] [stdout] 110 | | let mut syslog = [INFO] [stdout] 111 | | AsyncSyslogInternal::new(ident, logstat, facility, Some(sock_path.as_ref()), use_altr_path) [INFO] [stdout] 112 | | .await?; [INFO] [stdout] ... | [INFO] [stdout] 124 | | ); [INFO] [stdout] 125 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/a_sync/syslog_async.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 128 | fn change_identity + Send>(&self, ident: I) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | / { [INFO] [stdout] 130 | | self.lock.lock().await.set_logtag(ident); [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/a_sync/syslog_async.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 139 | fn openlog_tcp

(ident: Option<&str>, logstat: LogStat, facility: LogFacility, ip_port: P) -> SyRes [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | where P: AsRef + Send, Self: Sized [INFO] [stdout] 141 | / { [INFO] [stdout] 142 | | let mut syslog = [INFO] [stdout] 143 | | AsyncSyslogInternal::new_net_tcp(ident, logstat, facility, ip_port)?; [INFO] [stdout] ... | [INFO] [stdout] 155 | | ); [INFO] [stdout] 156 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/a_sync/syslog_async.rs:161:5 [INFO] [stdout] | [INFO] [stdout] 159 | fn openlog_udp

(ident: Option<&str>, logstat: LogStat, facility: LogFacility, bind_ip_port: Option

, ip_port: P) -> SyRes [INFO] [stdout] | ----------------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | where P: AsRef + Send, Self: Sized [INFO] [stdout] 161 | / { [INFO] [stdout] 162 | | let o_bind_ip_port = bind_ip_port.as_ref().map(|f| f.as_ref()); [INFO] [stdout] 163 | | [INFO] [stdout] 164 | | let mut syslog = [INFO] [stdout] ... | [INFO] [stdout] 177 | | ); [INFO] [stdout] 178 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `syslog-rs` (lib) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `get_raw_fd` is never used [INFO] [stdout] --> src/sync/socket.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 32 | pub(crate) trait SyslogTap [INFO] [stdout] | --------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 35 | fn get_raw_fd(&self) -> RawFd; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_raw_fd` is never used [INFO] [stdout] --> src/a_sync/async_socket.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 36 | pub(crate) trait AsyncSyslogTap [INFO] [stdout] | -------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 39 | fn get_raw_fd(&self) -> RawFd; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/syslog_sync.rs:151:15 [INFO] [stdout] | [INFO] [stdout] 149 | fn vsyslog>(&self, pri: Priority, fmt: S) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | { [INFO] [stdout] 151 | match self.inner.lock() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/a_sync/syslog_async.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 89 | fn vsyslog + Send>(&self, pri: Priority, fmt: S) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | / { [INFO] [stdout] 91 | | let f = fmt.as_ref(); [INFO] [stdout] 92 | | [INFO] [stdout] 93 | | self [INFO] [stdout] ... | [INFO] [stdout] 98 | | .await; [INFO] [stdout] 99 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/a_sync/syslog_async.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 107 | fn openlog_custom

(ident: Option<&str>, logstat: LogStat, facility: LogFacility, sock_path: P, use_altr_path: bool) -> SyRes [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | where Self: Sized, P: AsRef + Send [INFO] [stdout] 109 | / { [INFO] [stdout] 110 | | let mut syslog = [INFO] [stdout] 111 | | AsyncSyslogInternal::new(ident, logstat, facility, Some(sock_path.as_ref()), use_altr_path) [INFO] [stdout] 112 | | .await?; [INFO] [stdout] ... | [INFO] [stdout] 124 | | ); [INFO] [stdout] 125 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/a_sync/syslog_async.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 128 | fn change_identity + Send>(&self, ident: I) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | / { [INFO] [stdout] 130 | | self.lock.lock().await.set_logtag(ident); [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/a_sync/syslog_async.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 139 | fn openlog_tcp

(ident: Option<&str>, logstat: LogStat, facility: LogFacility, ip_port: P) -> SyRes [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | where P: AsRef + Send, Self: Sized [INFO] [stdout] 141 | / { [INFO] [stdout] 142 | | let mut syslog = [INFO] [stdout] 143 | | AsyncSyslogInternal::new_net_tcp(ident, logstat, facility, ip_port)?; [INFO] [stdout] ... | [INFO] [stdout] 155 | | ); [INFO] [stdout] 156 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/a_sync/syslog_async.rs:161:5 [INFO] [stdout] | [INFO] [stdout] 159 | fn openlog_udp

(ident: Option<&str>, logstat: LogStat, facility: LogFacility, bind_ip_port: Option

, ip_port: P) -> SyRes [INFO] [stdout] | ----------------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | where P: AsRef + Send, Self: Sized [INFO] [stdout] 161 | / { [INFO] [stdout] 162 | | let o_bind_ip_port = bind_ip_port.as_ref().map(|f| f.as_ref()); [INFO] [stdout] 163 | | [INFO] [stdout] 164 | | let mut syslog = [INFO] [stdout] ... | [INFO] [stdout] 177 | | ); [INFO] [stdout] 178 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `syslog-rs` (lib test) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "cc33a64af3d8f902ed17a4fe298af27f35ef53daa9610bd5264bf3960c302743", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc33a64af3d8f902ed17a4fe298af27f35ef53daa9610bd5264bf3960c302743", kill_on_drop: false }` [INFO] [stdout] cc33a64af3d8f902ed17a4fe298af27f35ef53daa9610bd5264bf3960c302743