[INFO] fetching crate syncthreads 0.7.0... [INFO] checking syncthreads-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate syncthreads 0.7.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate syncthreads 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate syncthreads 0.7.0 [INFO] finished tweaking crates.io crate syncthreads 0.7.0 [INFO] tweaked toml for crates.io crate syncthreads 0.7.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 121 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding aligned-vec v0.5.0 (latest: v0.6.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding colorgrad v0.6.2 (latest: v0.7.0) [INFO] [stderr] Adding csscolorparser v0.6.2 (latest: v0.7.0) [INFO] [stderr] Adding equator v0.2.2 (latest: v0.4.1) [INFO] [stderr] Adding equator-macro v0.2.1 (latest: v0.4.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d66250697fb629df32a23ab12b420a155acc0c33215752326c00db7981483a47 [INFO] running `Command { std: "docker" "start" "-a" "d66250697fb629df32a23ab12b420a155acc0c33215752326c00db7981483a47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d66250697fb629df32a23ab12b420a155acc0c33215752326c00db7981483a47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d66250697fb629df32a23ab12b420a155acc0c33215752326c00db7981483a47", kill_on_drop: false }` [INFO] [stdout] d66250697fb629df32a23ab12b420a155acc0c33215752326c00db7981483a47 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 062c09a5fc8f1c76ed920c045c00a65a68d5a6d4476b26618eaca37af9d5e1c8 [INFO] running `Command { std: "docker" "start" "-a" "062c09a5fc8f1c76ed920c045c00a65a68d5a6d4476b26618eaca37af9d5e1c8", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling equator-macro v0.2.1 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking aligned-vec v0.5.0 [INFO] [stderr] Checking reborrow v0.5.5 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking core_affinity v0.8.1 [INFO] [stderr] Checking pollster v0.3.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking equator v0.2.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking csscolorparser v0.6.2 [INFO] [stderr] Checking colorgrad v0.6.2 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking syncthreads v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:178:20 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | value: UnsafeCell::new(value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:264:19 [INFO] [stdout] | [INFO] [stdout] 261 | pub fn new(value: T, num_threads: usize, hint: AllocHint, params: BarrierParams) -> Self { [INFO] [stdout] | -------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 264 | data: UnsafeCell::new(value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:265:21 [INFO] [stdout] | [INFO] [stdout] 261 | pub fn new(value: T, num_threads: usize, hint: AllocHint, params: BarrierParams) -> Self { [INFO] [stdout] | -------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | shared: UnsafeCell::new(hint.shared.make_vec()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:266:24 [INFO] [stdout] | [INFO] [stdout] 261 | pub fn new(value: T, num_threads: usize, hint: AllocHint, params: BarrierParams) -> Self { [INFO] [stdout] | -------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 266 | exclusive: UnsafeCell::new(hint.exclusive.make_vec()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 273 | pub fn into_inner(self) -> (T, AllocHint) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | ( [INFO] [stdout] 275 | self.data.into_inner(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:276:13 [INFO] [stdout] | [INFO] [stdout] 273 | pub fn into_inner(self) -> (T, AllocHint) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | / AllocHint { [INFO] [stdout] 277 | | shared: Alloc::Storage(Storage { [INFO] [stdout] 278 | | alloc: self.shared.into_inner(), [INFO] [stdout] 279 | | }), [INFO] [stdout] ... | [INFO] [stdout] 282 | | }), [INFO] [stdout] 283 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:327:20 [INFO] [stdout] | [INFO] [stdout] 325 | pub fn new(value: T, num_threads: usize, hint: AllocHint, params: AsyncBarrierParams) -> Self { [INFO] [stdout] | -------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 326 | AsyncBarrierInit { [INFO] [stdout] 327 | inner: sync::AsyncBarrierInit::new(num_threads, params), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:328:19 [INFO] [stdout] | [INFO] [stdout] 325 | pub fn new(value: T, num_threads: usize, hint: AllocHint, params: AsyncBarrierParams) -> Self { [INFO] [stdout] | -------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | data: UnsafeCell::new(value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:329:21 [INFO] [stdout] | [INFO] [stdout] 325 | pub fn new(value: T, num_threads: usize, hint: AllocHint, params: AsyncBarrierParams) -> Self { [INFO] [stdout] | -------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 329 | shared: UnsafeCell::new(hint.shared.make_vec()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:330:24 [INFO] [stdout] | [INFO] [stdout] 325 | pub fn new(value: T, num_threads: usize, hint: AllocHint, params: AsyncBarrierParams) -> Self { [INFO] [stdout] | -------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 330 | exclusive: UnsafeCell::new(hint.exclusive.make_vec()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:339:13 [INFO] [stdout] | [INFO] [stdout] 337 | pub fn into_inner(self) -> (T, AllocHint) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 338 | ( [INFO] [stdout] 339 | self.data.into_inner(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:340:13 [INFO] [stdout] | [INFO] [stdout] 337 | pub fn into_inner(self) -> (T, AllocHint) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 340 | / AllocHint { [INFO] [stdout] 341 | | shared: Alloc::Storage(Storage { [INFO] [stdout] 342 | | alloc: self.shared.into_inner(), [INFO] [stdout] 343 | | }), [INFO] [stdout] ... | [INFO] [stdout] 346 | | }), [INFO] [stdout] 347 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:431:12 [INFO] [stdout] | [INFO] [stdout] 397 | f: impl FnOnce(&'b mut T) -> (Shared, I), [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 398 | tag: impl core::any::Any, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 431 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 432 | | unsafe { &(&*self.shared.get()).assume_ref::()[0] }, [INFO] [stdout] 433 | | (unsafe { [INFO] [stdout] 434 | | &mut *((&*self.exclusive.get()) [INFO] [stdout] ... | [INFO] [stdout] 439 | | .unwrap(), [INFO] [stdout] 440 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `syncthreads` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "062c09a5fc8f1c76ed920c045c00a65a68d5a6d4476b26618eaca37af9d5e1c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "062c09a5fc8f1c76ed920c045c00a65a68d5a6d4476b26618eaca37af9d5e1c8", kill_on_drop: false }` [INFO] [stdout] 062c09a5fc8f1c76ed920c045c00a65a68d5a6d4476b26618eaca37af9d5e1c8