[INFO] fetching crate sync42 0.8.0... [INFO] checking sync42-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sync42 0.8.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate sync42 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sync42 0.8.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate sync42 0.8.0 [INFO] tweaked toml for crates.io crate sync42 0.8.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate sync42 0.8.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ce3e41e168403e6deed4e915cf507b2490f8e9cfed4e78b55e20be3dac6514e0 [INFO] running `Command { std: "docker" "start" "-a" "ce3e41e168403e6deed4e915cf507b2490f8e9cfed4e78b55e20be3dac6514e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ce3e41e168403e6deed4e915cf507b2490f8e9cfed4e78b55e20be3dac6514e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ce3e41e168403e6deed4e915cf507b2490f8e9cfed4e78b55e20be3dac6514e0", kill_on_drop: false }` [INFO] [stdout] ce3e41e168403e6deed4e915cf507b2490f8e9cfed4e78b55e20be3dac6514e0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 568cb17ba7cf655de65d087f37474eab594a9d613e7824f564ab88d7fa75e390 [INFO] running `Command { std: "docker" "start" "-a" "568cb17ba7cf655de65d087f37474eab594a9d613e7824f564ab88d7fa75e390", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking biometrics v0.8.0 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking sync42 v0.8.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lru.rs:240:19 [INFO] [stdout] | [INFO] [stdout] 239 | fn new(key: K, value: V) -> *mut Node { [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | Box::leak(Box::new(Self { [INFO] [stdout] | ___________________^ [INFO] [stdout] 241 | | next: std::ptr::null_mut(), [INFO] [stdout] 242 | | prev: std::ptr::null_mut(), [INFO] [stdout] 243 | | key, [INFO] [stdout] 244 | | value, [INFO] [stdout] 245 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monitor.rs:51:27 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(core: M, coordination: COORD, critical_section: CRIT) -> Self { [INFO] [stdout] | ------- ------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | coordination: Mutex::new(coordination), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monitor.rs:53:31 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(core: M, coordination: COORD, critical_section: CRIT) -> Self { [INFO] [stdout] | ------- ------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | critical_section: UnsafeCell::new(critical_section), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monitor.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn decompose(self) -> (M, COORD, CRIT) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | self.coordination.into_inner().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monitor.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn decompose(self) -> (M, COORD, CRIT) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | self.critical_section.into_inner(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spin_lock.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | data: UnsafeCell::new(t), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_hash_table.rs:235:31 [INFO] [stdout] | [INFO] [stdout] 233 | pub fn get_state<'a: 'b, 'b>(&'a self, key: K) -> Option> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | let entries = self.entries.lock().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | entries.get(&key).map(|value| Handle { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 236 | | table: self, [INFO] [stdout] 237 | | key, [INFO] [stdout] 238 | | value: Arc::clone(value), [INFO] [stdout] 239 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_hash_table.rs:238:20 [INFO] [stdout] | [INFO] [stdout] 233 | pub fn get_state<'a: 'b, 'b>(&'a self, key: K) -> Option> { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | value: Arc::clone(value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wait_list.rs:81:17 [INFO] [stdout] | [INFO] [stdout] 80 | fn load<'a, M>(&self, guard: MutexGuard<'a, M>) -> (MutexGuard<'a, M>, T) { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | (guard, self.value.lock().unwrap().as_ref().unwrap().clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wait_list.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 97 | fn naked_wait<'a, M>(&self, guard: MutexGuard<'a, M>) -> MutexGuard<'a, M> { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | self.cond.wait(guard).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wait_list.rs:321:14 [INFO] [stdout] | [INFO] [stdout] 310 | let state = self.list.state.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 321 | Some(WaitGuard { [INFO] [stdout] | ______________^ [INFO] [stdout] 322 | | list: self.list, [INFO] [stdout] 323 | | index, [INFO] [stdout] 324 | | owned: false, [INFO] [stdout] 325 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/work_coalescing_queue.rs:182:9 [INFO] [stdout] | [INFO] [stdout] 181 | pub fn into_inner(self) -> C { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | self.core.into_inner().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sync42` (lib) due to 13 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "568cb17ba7cf655de65d087f37474eab594a9d613e7824f564ab88d7fa75e390", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "568cb17ba7cf655de65d087f37474eab594a9d613e7824f564ab88d7fa75e390", kill_on_drop: false }` [INFO] [stdout] 568cb17ba7cf655de65d087f37474eab594a9d613e7824f564ab88d7fa75e390