[INFO] fetching crate sync-resolve 0.3.1... [INFO] checking sync-resolve-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sync-resolve 0.3.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate sync-resolve 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sync-resolve 0.3.1 [INFO] finished tweaking crates.io crate sync-resolve 0.3.1 [INFO] tweaked toml for crates.io crate sync-resolve 0.3.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate sync-resolve 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 42512619ea6bb83353c8ab4f76ed9d1b3c3ee8e9a73bb2a35627222a67b2cf18 [INFO] running `Command { std: "docker" "start" "-a" "42512619ea6bb83353c8ab4f76ed9d1b3c3ee8e9a73bb2a35627222a67b2cf18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "42512619ea6bb83353c8ab4f76ed9d1b3c3ee8e9a73bb2a35627222a67b2cf18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "42512619ea6bb83353c8ab4f76ed9d1b3c3ee8e9a73bb2a35627222a67b2cf18", kill_on_drop: false }` [INFO] [stdout] 42512619ea6bb83353c8ab4f76ed9d1b3c3ee8e9a73bb2a35627222a67b2cf18 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 354f4b54c6c6ca402a1e93dcd528c083927a421b5fea30b92ed24697e5919e49 [INFO] running `Command { std: "docker" "start" "-a" "354f4b54c6c6ca402a1e93dcd528c083927a421b5fea30b92ed24697e5919e49", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking sync-resolve v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 41 | fn with_sock(sock: DnsSocket, config: DnsConfig) -> io::Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Ok(DnsResolver { [INFO] [stdout] | ____________^ [INFO] [stdout] 43 | | sock, [INFO] [stdout] 44 | | config, [INFO] [stdout] 45 | | next_ns: Cell::new(0), [INFO] [stdout] 46 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | Err(Error::IoError(io::Error::new( [INFO] [stdout] | _________________^ [INFO] [stdout] 75 | | io::ErrorKind::Other, [INFO] [stdout] 76 | | "failed to resolve address: name not found", [INFO] [stdout] 77 | | ))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:279:13 [INFO] [stdout] | [INFO] [stdout] 217 | let mut last_err = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | Err(last_err.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:300:11 [INFO] [stdout] | [INFO] [stdout] 296 | fn convert_error(desc: &str, f: F) -> io::Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | match f() { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn bind(addr: A) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Ok(DnsSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 26 | | sock: UdpSocket::bind(addr)?, [INFO] [stdout] 27 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 41 | fn with_sock(sock: DnsSocket, config: DnsConfig) -> io::Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Ok(DnsResolver { [INFO] [stdout] | ____________^ [INFO] [stdout] 43 | | sock, [INFO] [stdout] 44 | | config, [INFO] [stdout] 45 | | next_ns: Cell::new(0), [INFO] [stdout] 46 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | Err(Error::IoError(io::Error::new( [INFO] [stdout] | _________________^ [INFO] [stdout] 75 | | io::ErrorKind::Other, [INFO] [stdout] 76 | | "failed to resolve address: name not found", [INFO] [stdout] 77 | | ))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:279:13 [INFO] [stdout] | [INFO] [stdout] 217 | let mut last_err = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | Err(last_err.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:300:11 [INFO] [stdout] | [INFO] [stdout] 296 | fn convert_error(desc: &str, f: F) -> io::Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | match f() { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn bind(addr: A) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Ok(DnsSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 26 | | sock: UdpSocket::bind(addr)?, [INFO] [stdout] 27 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sync-resolve` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `sync-resolve` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "354f4b54c6c6ca402a1e93dcd528c083927a421b5fea30b92ed24697e5919e49", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "354f4b54c6c6ca402a1e93dcd528c083927a421b5fea30b92ed24697e5919e49", kill_on_drop: false }` [INFO] [stdout] 354f4b54c6c6ca402a1e93dcd528c083927a421b5fea30b92ed24697e5919e49