[INFO] fetching crate symsrv 0.5.3... [INFO] checking symsrv-0.5.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate symsrv 0.5.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate symsrv 0.5.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate symsrv 0.5.3 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate symsrv 0.5.3 [INFO] tweaked toml for crates.io crate symsrv 0.5.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate symsrv 0.5.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 720a5314a4176212105c0f05b37a4c6ce8ff71370de146a7830bdafaabf9bafb [INFO] running `Command { std: "docker" "start" "-a" "720a5314a4176212105c0f05b37a4c6ce8ff71370de146a7830bdafaabf9bafb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "720a5314a4176212105c0f05b37a4c6ce8ff71370de146a7830bdafaabf9bafb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "720a5314a4176212105c0f05b37a4c6ce8ff71370de146a7830bdafaabf9bafb", kill_on_drop: false }` [INFO] [stdout] 720a5314a4176212105c0f05b37a4c6ce8ff71370de146a7830bdafaabf9bafb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 19a305fef3d151000be664c86af6259d0a9a1e1c23060b48b58348d2e1bda002 [INFO] running `Command { std: "docker" "start" "-a" "19a305fef3d151000be664c86af6259d0a9a1e1c23060b48b58348d2e1bda002", kill_on_drop: false }` [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Compiling portable-atomic v1.7.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking ring v0.17.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking lzxd v0.2.5 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking cab v0.6.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking rustls-webpki v0.102.6 [INFO] [stderr] Checking fs4 v0.9.1 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling clap_derive v4.5.11 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_json v1.0.121 [INFO] [stderr] Checking ppv-lite86 v0.2.19 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking assert-json-diff v2.0.2 [INFO] [stderr] Checking clap v4.5.11 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking async-compression v0.4.12 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking symsrv v0.5.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:569:93 [INFO] [stdout] | [INFO] [stdout] 560 | let inner = self.inner.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 569 | async move { inner.get_file_impl(&filename, &hash, allow_downloads).await }; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:597:23 [INFO] [stdout] | [INFO] [stdout] 579 | let builder = reqwest::Client::builder(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 582 | let builder = builder.http1_only(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 588 | let builder = builder.no_gzip().no_brotli().no_deflate(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 592 | let client = builder.build(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 597 | observer: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:964:17 [INFO] [stdout] | [INFO] [stdout] 938 | cab_data_source: CabDataSource, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 960 | let observer = self.observer.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 963 | |mut dest_file: std::fs::File| async { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 964 | / tokio::task::spawn_blocking(move || match cab_data_source { [INFO] [stdout] 965 | | CabDataSource::Filename(compressed_input_path) => { [INFO] [stdout] 966 | | let file = std::fs::File::open(compressed_input_path) [INFO] [stdout] 967 | | .map_err(CabExtractionError::CouldNotOpenCabFile)?; [INFO] [stdout] ... | [INFO] [stdout] 974 | | }) [INFO] [stdout] 975 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:982:29 [INFO] [stdout] | [INFO] [stdout] 980 | .map_err(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 981 | CabExtractionError::Other( [INFO] [stdout] 982 | "Could not get size of existing extracted file".into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/computation_coalescing.rs:70:20 [INFO] [stdout] | [INFO] [stdout] 43 | let future = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let remover = scopeguard::guard((), |_| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let _remover = remover; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | [INFO] [stdout] 70 | future.await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/download.rs:136:14 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn new(progress_fun: F, total_size: Option) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | Self(Mutex::new(ProgressNotifierData { [INFO] [stdout] | ______________^ [INFO] [stdout] 137 | | progress_fun, [INFO] [stdout] 138 | | total_size, [INFO] [stdout] 139 | | accumulated_size: 0, [INFO] [stdout] 140 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/download.rs:152:20 [INFO] [stdout] | [INFO] [stdout] 150 | pub fn new(inner: I, observer: O) -> Self { [INFO] [stdout] | -------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | Self { [INFO] [stdout] 152 | inner: Box::pin(inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/download.rs:153:23 [INFO] [stdout] | [INFO] [stdout] 150 | pub fn new(inner: I, observer: O) -> Self { [INFO] [stdout] | -------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | observer: Box::pin(observer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/download.rs:190:37 [INFO] [stdout] | [INFO] [stdout] 186 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | progress_fun: F, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | AsyncReadWrapper::new(self, ProgressNotifier::new(progress_fun, total_size)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_creation.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 232 | file: std::fs::File, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | Err(io::Error::new( [INFO] [stdout] | _________^ [INFO] [stdout] 244 | | io::ErrorKind::Interrupted, [INFO] [stdout] 245 | | "File locking was interrupted too many times", [INFO] [stdout] 246 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/poll_all.rs:18:21 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(futures: Vec) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Self { [INFO] [stdout] 18 | values: futures.iter().map(|_| None).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/poll_all.rs:19:30 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(futures: Vec) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | pending_futures: futures.into_iter().enumerate().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/poll_all.rs:33:44 [INFO] [stdout] | [INFO] [stdout] 33 | .retain_mut(|(i, f)| match f.poll_unpin(cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `symsrv` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "19a305fef3d151000be664c86af6259d0a9a1e1c23060b48b58348d2e1bda002", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19a305fef3d151000be664c86af6259d0a9a1e1c23060b48b58348d2e1bda002", kill_on_drop: false }` [INFO] [stdout] 19a305fef3d151000be664c86af6259d0a9a1e1c23060b48b58348d2e1bda002