[INFO] fetching crate symphonia-codec-aac 0.5.4... [INFO] checking symphonia-codec-aac-0.5.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate symphonia-codec-aac 0.5.4 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate symphonia-codec-aac 0.5.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate symphonia-codec-aac 0.5.4 [INFO] finished tweaking crates.io crate symphonia-codec-aac 0.5.4 [INFO] tweaked toml for crates.io crate symphonia-codec-aac 0.5.4 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9e894ea59e066ea91d84d1c7f6abc9903dd71e481c5ebfc704a5162c7435e35b [INFO] running `Command { std: "docker" "start" "-a" "9e894ea59e066ea91d84d1c7f6abc9903dd71e481c5ebfc704a5162c7435e35b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9e894ea59e066ea91d84d1c7f6abc9903dd71e481c5ebfc704a5162c7435e35b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9e894ea59e066ea91d84d1c7f6abc9903dd71e481c5ebfc704a5162c7435e35b", kill_on_drop: false }` [INFO] [stdout] 9e894ea59e066ea91d84d1c7f6abc9903dd71e481c5ebfc704a5162c7435e35b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 280569cd47d7a2f700dddb4e162f5d8a5bc595c05a9d45007340600dcd6d4693 [INFO] running `Command { std: "docker" "start" "-a" "280569cd47d7a2f700dddb4e162f5d8a5bc595c05a9d45007340600dcd6d4693", kill_on_drop: false }` [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking symphonia-core v0.5.4 [INFO] [stderr] Checking symphonia-codec-aac v0.5.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aac/codebooks.rs:590:22 [INFO] [stdout] | [INFO] [stdout] 580 | fn make_value_codebook(table: &VlcTable, f: F) -> C [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 588 | let values: Vec = (0..table.codes.len()).map(f).collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 589 | [INFO] [stdout] 590 | C::new(codebook, values.into_boxed_slice()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adts.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 128 | fn try_new(mut source: MediaSourceStream, _options: &FormatOptions) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let mut params = CodecParameters::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Ok(AdtsReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 146 | | reader: source, [INFO] [stdout] 147 | | tracks: vec![Track::new(0, params)], [INFO] [stdout] 148 | | cues: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 151 | | next_packet_ts: 0, [INFO] [stdout] 152 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adts.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 165 | Ok(Packet::new_from_boxed_slice( [INFO] [stdout] | ____________^ [INFO] [stdout] 166 | | 0, [INFO] [stdout] 167 | | ts, [INFO] [stdout] 168 | | SAMPLES_PER_AAC_PACKET, [INFO] [stdout] 169 | | self.reader.read_boxed_slice_exact(header.frame_len)?, [INFO] [stdout] 170 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aac/codebooks.rs:590:22 [INFO] [stdout] | [INFO] [stdout] 580 | fn make_value_codebook(table: &VlcTable, f: F) -> C [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 588 | let values: Vec = (0..table.codes.len()).map(f).collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 589 | [INFO] [stdout] 590 | C::new(codebook, values.into_boxed_slice()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adts.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 128 | fn try_new(mut source: MediaSourceStream, _options: &FormatOptions) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let mut params = CodecParameters::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Ok(AdtsReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 146 | | reader: source, [INFO] [stdout] 147 | | tracks: vec![Track::new(0, params)], [INFO] [stdout] 148 | | cues: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 151 | | next_packet_ts: 0, [INFO] [stdout] 152 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adts.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 165 | Ok(Packet::new_from_boxed_slice( [INFO] [stdout] | ____________^ [INFO] [stdout] 166 | | 0, [INFO] [stdout] 167 | | ts, [INFO] [stdout] 168 | | SAMPLES_PER_AAC_PACKET, [INFO] [stdout] 169 | | self.reader.read_boxed_slice_exact(header.frame_len)?, [INFO] [stdout] 170 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `symphonia-codec-aac` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `symphonia-codec-aac` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "280569cd47d7a2f700dddb4e162f5d8a5bc595c05a9d45007340600dcd6d4693", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "280569cd47d7a2f700dddb4e162f5d8a5bc595c05a9d45007340600dcd6d4693", kill_on_drop: false }` [INFO] [stdout] 280569cd47d7a2f700dddb4e162f5d8a5bc595c05a9d45007340600dcd6d4693