[INFO] fetching crate syml 0.4.0... [INFO] checking syml-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate syml 0.4.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate syml 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate syml 0.4.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate syml 0.4.0 [INFO] tweaked toml for crates.io crate syml 0.4.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate syml 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aff5ee109e1c1cf370bc24225bfc2c9fb3755ce59f455f2acff236fe26372958 [INFO] running `Command { std: "docker" "start" "-a" "aff5ee109e1c1cf370bc24225bfc2c9fb3755ce59f455f2acff236fe26372958", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aff5ee109e1c1cf370bc24225bfc2c9fb3755ce59f455f2acff236fe26372958", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aff5ee109e1c1cf370bc24225bfc2c9fb3755ce59f455f2acff236fe26372958", kill_on_drop: false }` [INFO] [stdout] aff5ee109e1c1cf370bc24225bfc2c9fb3755ce59f455f2acff236fe26372958 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b745cbae81d4f0d191a6f81254a0e90b41f8c161e73bfb4a65f349ecfb33e7f2 [INFO] running `Command { std: "docker" "start" "-a" "b745cbae81d4f0d191a6f81254a0e90b41f8c161e73bfb4a65f349ecfb33e7f2", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.80 [INFO] [stderr] Compiling peg-runtime v0.8.2 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling peg-macros v0.8.2 [INFO] [stderr] Checking peg v0.8.2 [INFO] [stderr] Checking syml v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:145:21 [INFO] [stdout] | [INFO] [stdout] 144 | fn from(value: [T; N]) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | Self::Array(value.into_iter() [INFO] [stdout] | _____________________^ [INFO] [stdout] 146 | | .map(Into::into) [INFO] [stdout] 147 | | .collect()) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:154:21 [INFO] [stdout] | [INFO] [stdout] 153 | fn from(value: [(K, V); N]) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | Self::Table(value.into_iter() [INFO] [stdout] | _____________________^ [INFO] [stdout] 155 | | .map(|(k, v)| (k.into(), v.into())) [INFO] [stdout] 156 | | .collect()) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:155:38 [INFO] [stdout] | [INFO] [stdout] 155 | .map(|(k, v)| (k.into(), v.into())) [INFO] [stdout] | ------ ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:182:9 [INFO] [stdout] | [INFO] [stdout] 181 | fn from_iter>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | / Vec::from_iter(iter.into_iter() [INFO] [stdout] 183 | | .map(Into::into)).into() [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:154:11 [INFO] [stdout] | [INFO] [stdout] 151 | = "{" _ vals:close_args(< [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | { vals.unwrap_or_default().into() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:175:28 [INFO] [stdout] | [INFO] [stdout] 170 | k:(k:simple_val() _ ":" { k }) ++ _ v:table_val(indent_level) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | .rfold((tail, v), |tab, key| { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:176:31 [INFO] [stdout] | [INFO] [stdout] 175 | .rfold((tail, v), |tab, key| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | (key, [tab].into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `syml` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:145:21 [INFO] [stdout] | [INFO] [stdout] 144 | fn from(value: [T; N]) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | Self::Array(value.into_iter() [INFO] [stdout] | _____________________^ [INFO] [stdout] 146 | | .map(Into::into) [INFO] [stdout] 147 | | .collect()) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:154:21 [INFO] [stdout] | [INFO] [stdout] 153 | fn from(value: [(K, V); N]) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | Self::Table(value.into_iter() [INFO] [stdout] | _____________________^ [INFO] [stdout] 155 | | .map(|(k, v)| (k.into(), v.into())) [INFO] [stdout] 156 | | .collect()) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:155:38 [INFO] [stdout] | [INFO] [stdout] 155 | .map(|(k, v)| (k.into(), v.into())) [INFO] [stdout] | ------ ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:182:9 [INFO] [stdout] | [INFO] [stdout] 181 | fn from_iter>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | / Vec::from_iter(iter.into_iter() [INFO] [stdout] 183 | | .map(Into::into)).into() [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:154:11 [INFO] [stdout] | [INFO] [stdout] 151 | = "{" _ vals:close_args(< [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | { vals.unwrap_or_default().into() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:175:28 [INFO] [stdout] | [INFO] [stdout] 170 | k:(k:simple_val() _ ":" { k }) ++ _ v:table_val(indent_level) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | .rfold((tail, v), |tab, key| { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:176:31 [INFO] [stdout] | [INFO] [stdout] 175 | .rfold((tail, v), |tab, key| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | (key, [tab].into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `syml` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "b745cbae81d4f0d191a6f81254a0e90b41f8c161e73bfb4a65f349ecfb33e7f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b745cbae81d4f0d191a6f81254a0e90b41f8c161e73bfb4a65f349ecfb33e7f2", kill_on_drop: false }` [INFO] [stdout] b745cbae81d4f0d191a6f81254a0e90b41f8c161e73bfb4a65f349ecfb33e7f2