[INFO] fetching crate sybot 0.10.4... [INFO] checking sybot-0.10.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sybot 0.10.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate sybot 0.10.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sybot 0.10.4 [INFO] removed 1 missing tests [INFO] finished tweaking crates.io crate sybot 0.10.4 [INFO] tweaked toml for crates.io crate sybot 0.10.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 59 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding glam v0.27.0 (latest: v0.29.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7813b649c7452ba9d64efc5bfbbcbf2db25e9533c2e097cf87bf2ed134c64272 [INFO] running `Command { std: "docker" "start" "-a" "7813b649c7452ba9d64efc5bfbbcbf2db25e9533c2e097cf87bf2ed134c64272", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7813b649c7452ba9d64efc5bfbbcbf2db25e9533c2e097cf87bf2ed134c64272", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7813b649c7452ba9d64efc5bfbbcbf2db25e9533c2e097cf87bf2ed134c64272", kill_on_drop: false }` [INFO] [stdout] 7813b649c7452ba9d64efc5bfbbcbf2db25e9533c2e097cf87bf2ed134c64272 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 01bba3b8c2e30d5153a58e035a7ee50be11d8f2c77192125bd1f195218c9fbf9 [INFO] running `Command { std: "docker" "start" "-a" "01bba3b8c2e30d5153a58e035a7ee50be11d8f2c77192125bd1f195218c9fbf9", kill_on_drop: false }` [INFO] [stderr] Checking embedded-hal v1.0.0 [INFO] [stderr] Checking glam v0.27.0 [INFO] [stderr] Checking spin_sleep v1.2.1 [INFO] [stderr] Checking atomic_float v1.1.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling syact_macros v0.1.1 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking syunit v0.2.1 [INFO] [stderr] Checking syact v0.13.7 [INFO] [stderr] Checking sybot v0.10.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rcs.rs:168:14 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn new(point : T) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | Self(Rc::new(RefCell::new(point))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rcs/des.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 88 | fn serialize(&self, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | PointEnum::from(self.clone()).serialize(serializer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rcs/des.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 96 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | let point = PointEnum::deserialize(deserializer)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | [INFO] [stdout] 101 | Ok(match point { [INFO] [stdout] | ____________^ [INFO] [stdout] 102 | | PointEnum::Pos { ori, pos } => [INFO] [stdout] 103 | | PointRef(Rc::new(RefCell::new(Position::new_ori(Vec3::from(pos), if let Some(o) = &ori { [INFO] [stdout] 104 | | Mat3::from_cols_array_2d(o) [INFO] [stdout] ... | [INFO] [stdout] 111 | | PointRef(Rc::new(RefCell::new(WorldObj::from_pos_sub(Position::from_vec3(Vec3::from(pos)), sub)))) [INFO] [stdout] 112 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/robs/stepper.rs:51:22 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn new(ang_confs : [AngleConfig; C], comps : G, tools : Vec>) -> Self { [INFO] [stdout] | --------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | remotes: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/desc/common.rs:92:29 [INFO] [stdout] | [INFO] [stdout] 81 | let wobj = WorldObj::zero() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | _kinematic: SerialKinematic::new([ [INFO] [stdout] | _____________________________^ [INFO] [stdout] 93 | | KinElement::new(Movement::Linear(Vec3::X), wobj.point("x").unwrap()), [INFO] [stdout] 94 | | KinElement::new(Movement::Linear(Vec3::Y), wobj.point("x/y").unwrap()) [INFO] [stdout] 95 | | ]), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/desc/common.rs:186:29 [INFO] [stdout] | [INFO] [stdout] 175 | let wobj = WorldObj::zero() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | _kinematic: SerialKinematic::new([ [INFO] [stdout] | _____________________________^ [INFO] [stdout] 187 | | KinElement::new(Movement::Linear(Vec3::X), wobj.point("x").unwrap()), [INFO] [stdout] 188 | | KinElement::new(Movement::Linear(Vec3::Y), wobj.point("x/y").unwrap()), [INFO] [stdout] 189 | | KinElement::new(Movement::Linear(Vec3::Z), wobj.point("x/y/z").unwrap()) [INFO] [stdout] 190 | | ]), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/desc/elem.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(movement : Movement, point_0 : PointRef) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | _point: point_0.clone_no_ref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/desc/kin.rs:59:18 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(segments : [KinElement; C]) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | tcp: last.point().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sybot` (lib test) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rcs.rs:168:14 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn new(point : T) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | Self(Rc::new(RefCell::new(point))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rcs/des.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 88 | fn serialize(&self, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | PointEnum::from(self.clone()).serialize(serializer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rcs/des.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 96 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | let point = PointEnum::deserialize(deserializer)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | [INFO] [stdout] 101 | Ok(match point { [INFO] [stdout] | ____________^ [INFO] [stdout] 102 | | PointEnum::Pos { ori, pos } => [INFO] [stdout] 103 | | PointRef(Rc::new(RefCell::new(Position::new_ori(Vec3::from(pos), if let Some(o) = &ori { [INFO] [stdout] 104 | | Mat3::from_cols_array_2d(o) [INFO] [stdout] ... | [INFO] [stdout] 111 | | PointRef(Rc::new(RefCell::new(WorldObj::from_pos_sub(Position::from_vec3(Vec3::from(pos)), sub)))) [INFO] [stdout] 112 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/robs/stepper.rs:51:22 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn new(ang_confs : [AngleConfig; C], comps : G, tools : Vec>) -> Self { [INFO] [stdout] | --------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | remotes: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/desc/common.rs:92:29 [INFO] [stdout] | [INFO] [stdout] 81 | let wobj = WorldObj::zero() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | _kinematic: SerialKinematic::new([ [INFO] [stdout] | _____________________________^ [INFO] [stdout] 93 | | KinElement::new(Movement::Linear(Vec3::X), wobj.point("x").unwrap()), [INFO] [stdout] 94 | | KinElement::new(Movement::Linear(Vec3::Y), wobj.point("x/y").unwrap()) [INFO] [stdout] 95 | | ]), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/desc/common.rs:186:29 [INFO] [stdout] | [INFO] [stdout] 175 | let wobj = WorldObj::zero() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | _kinematic: SerialKinematic::new([ [INFO] [stdout] | _____________________________^ [INFO] [stdout] 187 | | KinElement::new(Movement::Linear(Vec3::X), wobj.point("x").unwrap()), [INFO] [stdout] 188 | | KinElement::new(Movement::Linear(Vec3::Y), wobj.point("x/y").unwrap()), [INFO] [stdout] 189 | | KinElement::new(Movement::Linear(Vec3::Z), wobj.point("x/y/z").unwrap()) [INFO] [stdout] 190 | | ]), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/desc/elem.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(movement : Movement, point_0 : PointRef) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | _point: point_0.clone_no_ref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/desc/kin.rs:59:18 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(segments : [KinElement; C]) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | tcp: last.point().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sybot` (lib) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "01bba3b8c2e30d5153a58e035a7ee50be11d8f2c77192125bd1f195218c9fbf9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01bba3b8c2e30d5153a58e035a7ee50be11d8f2c77192125bd1f195218c9fbf9", kill_on_drop: false }` [INFO] [stdout] 01bba3b8c2e30d5153a58e035a7ee50be11d8f2c77192125bd1f195218c9fbf9