[INFO] fetching crate swsurface 0.1.4... [INFO] checking swsurface-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate swsurface 0.1.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate swsurface 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate swsurface 0.1.4 [INFO] finished tweaking crates.io crate swsurface 0.1.4 [INFO] tweaked toml for crates.io crate swsurface 0.1.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate swsurface 0.1.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ea932b8f035af17c4442061d8503f3e00e41faacfa5e31e2427abe53abc34e99 [INFO] running `Command { std: "docker" "start" "-a" "ea932b8f035af17c4442061d8503f3e00e41faacfa5e31e2427abe53abc34e99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ea932b8f035af17c4442061d8503f3e00e41faacfa5e31e2427abe53abc34e99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ea932b8f035af17c4442061d8503f3e00e41faacfa5e31e2427abe53abc34e99", kill_on_drop: false }` [INFO] [stdout] ea932b8f035af17c4442061d8503f3e00e41faacfa5e31e2427abe53abc34e99 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5c62047765a5f4553ad7a790b6bae19c262c5970d78a9669dda7cacdb3e0e7f5 [INFO] running `Command { std: "docker" "start" "-a" "5c62047765a5f4553ad7a790b6bae19c262c5970d78a9669dda7cacdb3e0e7f5", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling xml-rs v0.8.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling num-traits v0.2.10 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling num_cpus v1.11.1 [INFO] [stderr] Compiling jobserver v0.1.17 [INFO] [stderr] Compiling wayland-scanner v0.23.6 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Compiling cc v1.0.48 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Checking lazycell v1.2.1 [INFO] [stderr] Checking stb_truetype v0.3.1 [INFO] [stderr] Checking arrayvec v0.5.1 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling glob v0.3.0 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Checking ordered-float v1.0.2 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Checking rusttype v0.8.2 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Checking downcast-rs v1.1.1 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Compiling zstd-sys v1.4.13+zstd.1.4.3 [INFO] [stderr] Checking rusttype v0.7.9 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Checking line_drawing v0.7.0 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Compiling x11-dl v2.18.4 [INFO] [stderr] Checking smallvec v1.1.0 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking wayland-sys v0.23.6 [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking parking_lot_core v0.7.0 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking lock_api v0.3.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling num-iter v0.1.39 [INFO] [stderr] Checking andrew v0.2.1 [INFO] [stderr] Compiling num-rational v0.2.2 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking parking_lot v0.10.0 [INFO] [stderr] Compiling wayland-client v0.23.6 [INFO] [stderr] Compiling wayland-protocols v0.23.6 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking wayland-commons v0.23.6 [INFO] [stderr] Checking calloop v0.4.4 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking instant v0.1.2 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Checking chrono v0.4.10 [INFO] [stderr] Checking owning_ref v0.4.0 [INFO] [stderr] Checking colored v1.9.0 [INFO] [stderr] Checking png v0.15.2 [INFO] [stderr] Checking jpeg-decoder v0.1.18 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking filetime v0.2.8 [INFO] [stderr] Checking xattr v0.2.2 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking fragile v0.3.0 [INFO] [stderr] Checking tar v0.4.26 [INFO] [stderr] Checking simple_logger v1.3.0 [INFO] [stderr] Checking tiff v0.3.1 [INFO] [stderr] Checking image v0.22.3 [INFO] [stderr] Checking smithay-client-toolkit v0.6.4 [INFO] [stderr] Checking winit v0.20.0 [INFO] [stderr] Checking swsurface v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated type alias `std::alloc::LayoutErr`: Name does not follow std convention, use LayoutError [INFO] [stdout] --> src/buffer.rs:2:66 [INFO] [stdout] | [INFO] [stdout] 2 | alloc::{alloc, dealloc, handle_alloc_error, realloc, Layout, LayoutErr}, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::alloc::LayoutErr`: Name does not follow std convention, use LayoutError [INFO] [stdout] --> src/buffer.rs:27:71 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn from_size_align(size: usize, align: usize) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:148:22 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn new(window: Window, context: &Context, config: &Config) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | Self { [INFO] [stdout] 148 | surface: Some(unsafe { Surface::new(&window, context, config) }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:149:21 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn new(window: Window, context: &Context, config: &Config) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | window: Some(window), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn into_window(mut self) -> Window { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | self.window.take().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:165:10 [INFO] [stdout] | [INFO] [stdout] 164 | pub unsafe fn split(mut self) -> (Surface, Window) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | (self.surface.take().unwrap(), self.window.take().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:165:40 [INFO] [stdout] | [INFO] [stdout] 164 | pub unsafe fn split(mut self) -> (Surface, Window) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | (self.surface.take().unwrap(), self.window.take().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:315:20 [INFO] [stdout] | [INFO] [stdout] 313 | pub fn build(self) -> Context { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | Context { [INFO] [stdout] 315 | inner: ContextImpl::new(self), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix/wayland.rs:70:23 [INFO] [stdout] | [INFO] [stdout] 40 | pub unsafe fn new(wl_dpy_ptr: *mut c_void, builder: ContextBuilder<'_, T>) -> Self { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let wl_dpy: wl_display::WlDisplay = wl::Proxy::from_c_ptr(wl_dpy_ptr as _).into(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | [INFO] [stdout] 43 | let manager = wl::GlobalManager::new(&wl_dpy); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let wl_shm: wl_shm::WlShm = manager [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | ready_cb: Rc::new(builder.ready_cb), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix/wayland.rs:176:20 [INFO] [stdout] | [INFO] [stdout] 166 | let images: Vec<_> = (0..config.image_count) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | let wl_srf: wl_surface::WlSurface = wl::Proxy::from_c_ptr(wl_srf_ptr as _).into(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | state: Rc::new(State { [INFO] [stdout] | ____________________^ [INFO] [stdout] 177 | | ctx: context.clone(), [INFO] [stdout] 178 | | wnd_id, [INFO] [stdout] 179 | | wl_srf, [INFO] [stdout] ... | [INFO] [stdout] 183 | | scanline_align, [INFO] [stdout] 184 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix/wayland.rs:168:22 [INFO] [stdout] | [INFO] [stdout] 168 | mem: RefCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix/wayland.rs:197:26 [INFO] [stdout] | [INFO] [stdout] 197 | .map(|image| image.mem.try_borrow_mut().expect("some images are locked")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix/wayland.rs:265:28 [INFO] [stdout] | [INFO] [stdout] 235 | let state = Rc::clone(&self.state); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | let state = Fragile::new(state); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | [INFO] [stdout] 244 | let on_release = move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | let mem_pool = MemPool::new(&self.state.ctx.wl_shm, on_release) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | (mem_pool, None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `swsurface` (lib) due to 12 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "5c62047765a5f4553ad7a790b6bae19c262c5970d78a9669dda7cacdb3e0e7f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c62047765a5f4553ad7a790b6bae19c262c5970d78a9669dda7cacdb3e0e7f5", kill_on_drop: false }` [INFO] [stdout] 5c62047765a5f4553ad7a790b6bae19c262c5970d78a9669dda7cacdb3e0e7f5