[INFO] fetching crate swp 1.0.3... [INFO] checking swp-1.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate swp 1.0.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate swp 1.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate swp 1.0.3 [INFO] finished tweaking crates.io crate swp 1.0.3 [INFO] tweaked toml for crates.io crate swp 1.0.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate swp 1.0.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1623eccb5e4c2ee3f794e279338e9aeaf99610d0b6c7c6b68cad85d477bcfb46 [INFO] running `Command { std: "docker" "start" "-a" "1623eccb5e4c2ee3f794e279338e9aeaf99610d0b6c7c6b68cad85d477bcfb46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1623eccb5e4c2ee3f794e279338e9aeaf99610d0b6c7c6b68cad85d477bcfb46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1623eccb5e4c2ee3f794e279338e9aeaf99610d0b6c7c6b68cad85d477bcfb46", kill_on_drop: false }` [INFO] [stdout] 1623eccb5e4c2ee3f794e279338e9aeaf99610d0b6c7c6b68cad85d477bcfb46 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4cb0aa8afce8c20098ffb1dd661b2ba211bc393c8182f6be2c1d03ba502dbf51 [INFO] running `Command { std: "docker" "start" "-a" "4cb0aa8afce8c20098ffb1dd661b2ba211bc393c8182f6be2c1d03ba502dbf51", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling syn v1.0.11 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking yansi v0.5.0 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking dunce v1.0.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking crossbeam-channel v0.4.0 [INFO] [stderr] Checking crossbeam-queue v0.2.0 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Checking num_cpus v1.11.1 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking crossbeam v0.7.3 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Compiling proc-macro-error v0.2.6 [INFO] [stderr] Compiling structopt-derive v0.3.5 [INFO] [stderr] Checking structopt v0.3.5 [INFO] [stderr] Checking swp v1.0.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `last_modified` is never read [INFO] [stdout] --> src/project.rs:16:2 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Project { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | last_modified: u64, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Project` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/settings.rs:135:4 [INFO] [stdout] | [INFO] [stdout] 134 | SettingsError::InvalidPath(_) => (), [INFO] [stdout] | ----------------------------- matches all the relevant values [INFO] [stdout] 135 | _ => panic!("Unexpected error returned"), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/output.rs:31:10 [INFO] [stdout] | [INFO] [stdout] 31 | panic!(format!("Label {} too long", label)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 31 - panic!(format!("Label {} too long", label)); [INFO] [stdout] 31 + panic!("Label {} too long", label); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:29:2 [INFO] [stdout] | [INFO] [stdout] 29 | / /// Exclude projects in directories matched by this regex pattern. [INFO] [stdout] 30 | | #[structopt(short = "i", long = "ignore")] [INFO] [stdout] 31 | | pub ignore: Option, [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:63:14 [INFO] [stdout] | [INFO] [stdout] 63 | .map(|p| canonicalize(p).map_err(|_| SettingsError::InvalidPath(p.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyse_projects/filter_by_modified_date.rs:112:20 [INFO] [stdout] | [INFO] [stdout] 112 | .filter_map(|p| p.metadata().ok()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyse_projects/filter_by_modified_date.rs:113:20 [INFO] [stdout] | [INFO] [stdout] 113 | .filter_map(|d| d.modified().ok()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/discover_projects/detect_cleanable_project.rs:21:37 [INFO] [stdout] | [INFO] [stdout] 21 | let mut project = Project::new(path.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 21 - let mut project = Project::new(path.clone()); [INFO] [stdout] 21 + let mut project = Project::new(path); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/file_utils.rs:13:6 [INFO] [stdout] | [INFO] [stdout] 13 | path.clone().join(filename).exists() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 13 - path.clone().join(filename).exists() [INFO] [stdout] 13 + path.join(filename).exists() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `swp` (bin "swp") due to 5 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `last_modified` is never read [INFO] [stdout] --> src/project.rs:16:2 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Project { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | last_modified: u64, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Project` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/output.rs:31:10 [INFO] [stdout] | [INFO] [stdout] 31 | panic!(format!("Label {} too long", label)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 31 - panic!(format!("Label {} too long", label)); [INFO] [stdout] 31 + panic!("Label {} too long", label); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:29:2 [INFO] [stdout] | [INFO] [stdout] 29 | / /// Exclude projects in directories matched by this regex pattern. [INFO] [stdout] 30 | | #[structopt(short = "i", long = "ignore")] [INFO] [stdout] 31 | | pub ignore: Option, [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:63:14 [INFO] [stdout] | [INFO] [stdout] 63 | .map(|p| canonicalize(p).map_err(|_| SettingsError::InvalidPath(p.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyse_projects/filter_by_modified_date.rs:112:20 [INFO] [stdout] | [INFO] [stdout] 112 | .filter_map(|p| p.metadata().ok()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyse_projects/filter_by_modified_date.rs:113:20 [INFO] [stdout] | [INFO] [stdout] 113 | .filter_map(|d| d.modified().ok()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/discover_projects/detect_cleanable_project.rs:21:37 [INFO] [stdout] | [INFO] [stdout] 21 | let mut project = Project::new(path.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 21 - let mut project = Project::new(path.clone()); [INFO] [stdout] 21 + let mut project = Project::new(path); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/file_utils.rs:13:6 [INFO] [stdout] | [INFO] [stdout] 13 | path.clone().join(filename).exists() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 13 - path.clone().join(filename).exists() [INFO] [stdout] 13 + path.join(filename).exists() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `swp` (bin "swp" test) due to 5 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4cb0aa8afce8c20098ffb1dd661b2ba211bc393c8182f6be2c1d03ba502dbf51", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4cb0aa8afce8c20098ffb1dd661b2ba211bc393c8182f6be2c1d03ba502dbf51", kill_on_drop: false }` [INFO] [stdout] 4cb0aa8afce8c20098ffb1dd661b2ba211bc393c8182f6be2c1d03ba502dbf51