[INFO] fetching crate svm-rs 0.5.6... [INFO] checking svm-rs-0.5.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate svm-rs 0.5.6 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate svm-rs 0.5.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate svm-rs 0.5.6 [INFO] finished tweaking crates.io crate svm-rs 0.5.6 [INFO] tweaked toml for crates.io crate svm-rs 0.5.6 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate svm-rs 0.5.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 183d442b8eea5703fc4daf974e93c9501b03eb818acc64b3b4b6ac2e6b4d62d5 [INFO] running `Command { std: "docker" "start" "-a" "183d442b8eea5703fc4daf974e93c9501b03eb818acc64b3b4b6ac2e6b4d62d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "183d442b8eea5703fc4daf974e93c9501b03eb818acc64b3b4b6ac2e6b4d62d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "183d442b8eea5703fc4daf974e93c9501b03eb818acc64b3b4b6ac2e6b4d62d5", kill_on_drop: false }` [INFO] [stdout] 183d442b8eea5703fc4daf974e93c9501b03eb818acc64b3b4b6ac2e6b4d62d5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3e785adf16f4a5d229732be89d7bcc6bcaec396a7eba8a814e01f57deff877e8 [INFO] running `Command { std: "docker" "start" "-a" "3e785adf16f4a5d229732be89d7bcc6bcaec396a7eba8a814e01f57deff877e8", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling cc v1.1.13 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Compiling serde v1.0.208 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Compiling powerfmt v0.2.0 [INFO] [stderr] Compiling vergen v8.3.2 [INFO] [stderr] Compiling num_threads v0.1.7 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling deranged v0.3.11 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling serde_json v1.0.125 [INFO] [stderr] Compiling portable-atomic v1.7.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking rustls-native-certs v0.7.2 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking webpki-roots v0.26.3 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking const-hex v1.12.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking sdd v3.0.2 [INFO] [stderr] Checking scc v2.1.16 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling time v0.3.36 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking fs4 v0.9.1 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling svm-rs v0.5.6 (/opt/rustwide/workdir) [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] warning: svm-rs@0.5.6: not within a suitable 'git' worktree! [INFO] [stderr] warning: svm-rs@0.5.6: VERGEN_GIT_SHA set to default [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.208 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling serial_test_derive v3.1.1 [INFO] [stderr] Checking serial_test v3.1.1 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rustls-webpki v0.102.6 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-socks v0.5.2 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | Ok(Version::parse(v.trim_end_matches('\n')).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install.rs:127:8 [INFO] [stdout] | [INFO] [stdout] 120 | let _lock_file = fs::OpenOptions::new() [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | Ok(LockFile { [INFO] [stdout] | ________^ [INFO] [stdout] 128 | | lock_path, [INFO] [stdout] 129 | | _lock_file, [INFO] [stdout] 130 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/releases.rs:205:37 [INFO] [stdout] | [INFO] [stdout] 205 | .retain(|v, _| *v < MACOS_AARCH64_NATIVE || *v > UNIVERSAL_MACOS_BINARIES); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/releases.rs:205:66 [INFO] [stdout] | [INFO] [stdout] 205 | .retain(|v, _| *v < MACOS_AARCH64_NATIVE || *v > UNIVERSAL_MACOS_BINARIES); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] The following warnings were emitted during compilation: [INFO] [stderr] [INFO] [stderr] warning: svm-rs@0.5.6: not within a suitable 'git' worktree! [INFO] [stderr] warning: svm-rs@0.5.6: VERGEN_GIT_SHA set to default [INFO] [stderr] [INFO] [stderr] error: could not compile `svm-rs` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | Ok(Version::parse(v.trim_end_matches('\n')).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install.rs:127:8 [INFO] [stdout] | [INFO] [stdout] 120 | let _lock_file = fs::OpenOptions::new() [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | Ok(LockFile { [INFO] [stdout] | ________^ [INFO] [stdout] 128 | | lock_path, [INFO] [stdout] 129 | | _lock_file, [INFO] [stdout] 130 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install.rs:357:74 [INFO] [stdout] | [INFO] [stdout] 356 | let cloned_version = version.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 357 | let t = tokio::task::spawn(async move { install(&cloned_version).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/releases.rs:205:37 [INFO] [stdout] | [INFO] [stdout] 205 | .retain(|v, _| *v < MACOS_AARCH64_NATIVE || *v > UNIVERSAL_MACOS_BINARIES); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/releases.rs:205:66 [INFO] [stdout] | [INFO] [stdout] 205 | .retain(|v, _| *v < MACOS_AARCH64_NATIVE || *v > UNIVERSAL_MACOS_BINARIES); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/releases.rs:300:13 [INFO] [stdout] | [INFO] [stdout] 297 | let version = Version::new(0, 5, 0); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | artifact_url(Platform::LinuxAarch64, &version, artifact).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] The following warnings were emitted during compilation: [INFO] [stderr] [INFO] [stderr] warning: svm-rs@0.5.6: not within a suitable 'git' worktree! [INFO] [stderr] warning: svm-rs@0.5.6: VERGEN_GIT_SHA set to default [INFO] [stderr] [INFO] [stderr] error: could not compile `svm-rs` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "3e785adf16f4a5d229732be89d7bcc6bcaec396a7eba8a814e01f57deff877e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e785adf16f4a5d229732be89d7bcc6bcaec396a7eba8a814e01f57deff877e8", kill_on_drop: false }` [INFO] [stdout] 3e785adf16f4a5d229732be89d7bcc6bcaec396a7eba8a814e01f57deff877e8