[INFO] fetching crate sv 0.2.2... [INFO] checking sv-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sv 0.2.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate sv 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sv 0.2.2 [INFO] finished tweaking crates.io crate sv 0.2.2 [INFO] tweaked toml for crates.io crate sv 0.2.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 51 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding block-buffer v0.3.3 (latest: v0.10.4) [INFO] [stderr] Adding byte-tools v0.2.0 (latest: v0.3.1) [INFO] [stderr] Adding cc v1.0.26 (latest: v1.1.15) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding digest v0.7.6 (latest: v0.10.7) [INFO] [stderr] Adding dns-lookup v0.9.1 (latest: v2.0.4) [INFO] [stderr] Adding generic-array v0.9.1 (latest: v1.1.0) [INFO] [stderr] Adding hex v0.3.2 (latest: v0.4.3) [INFO] [stderr] Adding murmur3 v0.4.1 (latest: v0.5.2) [INFO] [stderr] Adding num-bigint v0.2.6 (latest: v0.4.6) [INFO] [stderr] Adding rand v0.3.23 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.5.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding ring v0.14.6 (latest: v0.17.8) [INFO] [stderr] Adding ripemd160 v0.7.0 (latest: v0.10.0) [INFO] [stderr] Adding secp256k1 v0.12.2 (latest: v0.29.0) [INFO] [stderr] Adding socket2 v0.3.19 (latest: v0.5.7) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding untrusted v0.6.2 (latest: v0.9.0) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ae50c1f957b3ab93f95eb0b683502706b8e78f83f6341e426900692894395d1e [INFO] running `Command { std: "docker" "start" "-a" "ae50c1f957b3ab93f95eb0b683502706b8e78f83f6341e426900692894395d1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ae50c1f957b3ab93f95eb0b683502706b8e78f83f6341e426900692894395d1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae50c1f957b3ab93f95eb0b683502706b8e78f83f6341e426900692894395d1e", kill_on_drop: false }` [INFO] [stdout] ae50c1f957b3ab93f95eb0b683502706b8e78f83f6341e426900692894395d1e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 44b85c5b8c4acc65336c48adf6ad1655a0500ed343d1dbd617f65298bd400fd5 [INFO] running `Command { std: "docker" "start" "-a" "44b85c5b8c4acc65336c48adf6ad1655a0500ed343d1dbd617f65298bd400fd5", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling cc v1.0.26 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Checking byte-tools v0.2.0 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking untrusted v0.6.2 [INFO] [stderr] Checking snowflake v1.3.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking murmur3 v0.4.1 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking generic-array v0.9.1 [INFO] [stderr] Checking block-buffer v0.3.3 [INFO] [stderr] Checking digest v0.7.6 [INFO] [stderr] Checking ripemd160 v0.7.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling ring v0.14.6 [INFO] [stderr] Compiling secp256k1 v0.12.2 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking socket2 v0.3.19 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking dns-lookup v0.9.1 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking rust-base58 v0.0.4 [INFO] [stderr] Checking sv v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/messages/message.rs:151:15 [INFO] [stdout] | [INFO] [stdout] 151 | match Message::read_partial(reader, &header) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/future.rs:41:21 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn single(value: T) -> Future { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let latch = Latch::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | result: Arc::new(Mutex::new(Some(value))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/future.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn get_timeout(self, duration: Duration) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let mut lock = self.result.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let mut ret = None; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | swap(&mut ret, &mut *lock); [INFO] [stdout] 62 | Ok(ret.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/rx.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 28 | let (poller, future) = Poller::new(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | self.subscribe(&poller); [INFO] [stdout] 30 | match future.get_timeout(duration) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/rx.rs:68:41 [INFO] [stdout] | [INFO] [stdout] 68 | observers.retain(|observer| observer.upgrade().is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/rx.rs:84:15 [INFO] [stdout] | [INFO] [stdout] 82 | let weak_observer = Arc::downgrade(observer) as Weak>; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | [INFO] [stdout] 84 | match self.observers.try_write() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/rx.rs:143:10 [INFO] [stdout] | [INFO] [stdout] 142 | let (future, future_provider) = Future::new(); [INFO] [stdout] | ------ --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | (Arc::new(Poller { future_provider }), future) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sv` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/messages/message.rs:151:15 [INFO] [stdout] | [INFO] [stdout] 151 | match Message::read_partial(reader, &header) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/future.rs:41:21 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn single(value: T) -> Future { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let latch = Latch::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | result: Arc::new(Mutex::new(Some(value))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/future.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn get_timeout(self, duration: Duration) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let mut lock = self.result.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let mut ret = None; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | swap(&mut ret, &mut *lock); [INFO] [stdout] 62 | Ok(ret.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/rx.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 28 | let (poller, future) = Poller::new(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | self.subscribe(&poller); [INFO] [stdout] 30 | match future.get_timeout(duration) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/rx.rs:68:41 [INFO] [stdout] | [INFO] [stdout] 68 | observers.retain(|observer| observer.upgrade().is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/rx.rs:84:15 [INFO] [stdout] | [INFO] [stdout] 82 | let weak_observer = Arc::downgrade(observer) as Weak>; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | [INFO] [stdout] 84 | match self.observers.try_write() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/rx.rs:143:10 [INFO] [stdout] | [INFO] [stdout] 142 | let (future, future_provider) = Future::new(); [INFO] [stdout] | ------ --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | (Arc::new(Poller { future_provider }), future) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sv` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "44b85c5b8c4acc65336c48adf6ad1655a0500ed343d1dbd617f65298bd400fd5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "44b85c5b8c4acc65336c48adf6ad1655a0500ed343d1dbd617f65298bd400fd5", kill_on_drop: false }` [INFO] [stdout] 44b85c5b8c4acc65336c48adf6ad1655a0500ed343d1dbd617f65298bd400fd5