[INFO] fetching crate suspend_fn_proc_macro 0.1.0... [INFO] checking suspend_fn_proc_macro-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate suspend_fn_proc_macro 0.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate suspend_fn_proc_macro 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate suspend_fn_proc_macro 0.1.0 [INFO] finished tweaking crates.io crate suspend_fn_proc_macro 0.1.0 [INFO] tweaked toml for crates.io crate suspend_fn_proc_macro 0.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf6464a286fbd8f7829774246b2b1a36718ac3ea7a764a8e9ae238e020dc1b2a [INFO] running `Command { std: "docker" "start" "-a" "bf6464a286fbd8f7829774246b2b1a36718ac3ea7a764a8e9ae238e020dc1b2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf6464a286fbd8f7829774246b2b1a36718ac3ea7a764a8e9ae238e020dc1b2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf6464a286fbd8f7829774246b2b1a36718ac3ea7a764a8e9ae238e020dc1b2a", kill_on_drop: false }` [INFO] [stdout] bf6464a286fbd8f7829774246b2b1a36718ac3ea7a764a8e9ae238e020dc1b2a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e90951351fa3358a126d20e5e4f61ea9ec6a3c312e47f242b00721a332b370e1 [INFO] running `Command { std: "docker" "start" "-a" "e90951351fa3358a126d20e5e4f61ea9ec6a3c312e47f242b00721a332b370e1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v1.0.109 [INFO] [stderr] Checking suspend_fn_proc_macro v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/expr.rs:231:26 [INFO] [stdout] | [INFO] [stdout] 231 | for (_, expr) in &mut self.guard { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 231 | while let Some((_, expr)) = &mut self.guard { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 231 | if let Some((_, expr)) = &mut self.guard { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/stmt.rs:17:26 [INFO] [stdout] | [INFO] [stdout] 17 | for (_, expr) in &mut self.init { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 17 | while let Some((_, expr)) = &mut self.init { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 17 | if let Some((_, expr)) = &mut self.init { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wrap_expr.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn wrap_expr(expr: Expr) -> Expr { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | let span = expr.span(); [INFO] [stdout] 12 | Expr::Paren(syn::ExprParen { [INFO] [stdout] | _________________^ [INFO] [stdout] 13 | | attrs: vec![], [INFO] [stdout] 14 | | paren_token: token::Paren(span), [INFO] [stdout] 15 | | expr: Box::new(Expr::Await(syn::ExprAwait { [INFO] [stdout] ... | [INFO] [stdout] 59 | | })), [INFO] [stdout] 60 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/expr.rs:231:26 [INFO] [stdout] | [INFO] [stdout] 231 | for (_, expr) in &mut self.guard { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 231 | while let Some((_, expr)) = &mut self.guard { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 231 | if let Some((_, expr)) = &mut self.guard { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/stmt.rs:17:26 [INFO] [stdout] | [INFO] [stdout] 17 | for (_, expr) in &mut self.init { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 17 | while let Some((_, expr)) = &mut self.init { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 17 | if let Some((_, expr)) = &mut self.init { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wrap_expr.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn wrap_expr(expr: Expr) -> Expr { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | let span = expr.span(); [INFO] [stdout] 12 | Expr::Paren(syn::ExprParen { [INFO] [stdout] | _________________^ [INFO] [stdout] 13 | | attrs: vec![], [INFO] [stdout] 14 | | paren_token: token::Paren(span), [INFO] [stdout] 15 | | expr: Box::new(Expr::Await(syn::ExprAwait { [INFO] [stdout] ... | [INFO] [stdout] 59 | | })), [INFO] [stdout] 60 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `suspend_fn_proc_macro` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `suspend_fn_proc_macro` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e90951351fa3358a126d20e5e4f61ea9ec6a3c312e47f242b00721a332b370e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e90951351fa3358a126d20e5e4f61ea9ec6a3c312e47f242b00721a332b370e1", kill_on_drop: false }` [INFO] [stdout] e90951351fa3358a126d20e5e4f61ea9ec6a3c312e47f242b00721a332b370e1